From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94FDDC77B70 for ; Mon, 17 Apr 2023 10:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L4mlz4ECsgCQuSc12hxqzqDwry53bdT5OHUe3JR3kOw=; b=W+uGAttjSRE73i yEA9NXs3SmgeMtx9WxXSKqts0EKAaB7CNplBJX7K/0sa7i+QqgZnK0Lbz3+IDBJ4KwUStw0YAEP3w GhhdH54dLxK1GXZl2DuHfgPXWzkSdYxYap7Fn5n3XZHB94NEqzuApWBtyFNxXTBpOXN7jXL0gQj21 nIdrGBrGMhfcWHUHNejK7Os9+1zEGVrzGyurcOEdsW+2f92Jd1uu2FtaZX4fCX7K1K8wbCrlCreyf BGdOVg5ngF4L+MNMZ89sfsC8eM3ThYhsg+lc8mefL+MBzrryALHzrICUptLmLa3Joq7htHslenk2Y b6szPMegP8Sln3XZoNdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poLe6-00FeDa-0S; Mon, 17 Apr 2023 09:59:38 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poLdz-00FeCa-12 for linux-arm-kernel@lists.infradead.org; Mon, 17 Apr 2023 09:59:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1681725571; x=1713261571; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b/8P0WGhAa/Cc5Bb3QAKq9k0biS4kx5qfPVA+BMlmjs=; b=Xq0q4wlF6u0A+uHZsn0ZxuV+fjODSyOfwYuY3RzpigDY6DEhLQ1+4OTs +CB593OLhHPPi/IM0jHPOH5bUCIciZ9vumvWoHphZtid4/Qc5T2X4I5pj k5DXY0g/mQZ32BAEWOF/JkSY8hUISgc1eHYdlEOoj3xdEOu33f1fdbPzC uOxc2CAartWouZ8qcbAaDGdiDysQsAatqtIY/kXEXhIrAdtup/+IRL6jn 6Awc4wQBiqWtIujUEiXgNTOKlRaceS38rsQREmwMAXKGJlp4AtB2jNN4W OrIHLE9VNp/WyZEMku7Me1QWaFjEtZzr9pe/7S/UQQv5EBqzuCn/JqDq6 Q==; X-IronPort-AV: E=Sophos;i="5.99,203,1677538800"; d="scan'208";a="30364744" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 17 Apr 2023 11:59:27 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 17 Apr 2023 11:59:27 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 17 Apr 2023 11:59:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1681725567; x=1713261567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b/8P0WGhAa/Cc5Bb3QAKq9k0biS4kx5qfPVA+BMlmjs=; b=L7vK7M+27Zq5hO2gFV99eTmlGC2x9BS7e7jaQWJt5xzWltqJZimF5seS P12V568buhFVCcepDb1oAFFqI9Izl/u2W0kPMPEIa4c0GT/CJ9eMpdJK+ XkAStRwbQGZTC0wRvQLz+UsO0uKzsxK0GruKV/J0d9z5iIT5Z06xspfRC zpru3ItHvCtF61SB0hiVGtqbVAZqsKIMvuYbo8aMA34lKLQOTKZkX9J0g bKhobu/FGIYzYdy6oLoY8dEankUZM+/CjLfToIweppvm2aEe11f/+cqN3 XVT/6aYtSM7x8e5L7WOCRC+xy6okZ0HMoI0mVihZRyJUoS4TqIdR8kaZe Q==; X-IronPort-AV: E=Sophos;i="5.99,203,1677538800"; d="scan'208";a="30364743" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Apr 2023 11:59:27 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id ECF37280072; Mon, 17 Apr 2023 11:59:26 +0200 (CEST) From: Alexander Stein To: Marco Felsch , linux-arm-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Xavier Roumegue , Rob Herring , linux-imx@nxp.com, Krzysztof Kozlowski , Jacopo Mondi , Shawn Guo , linux-media@vger.kernel.org, Laurent Pinchart Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes Date: Mon, 17 Apr 2023 11:59:25 +0200 Message-ID: <3232774.44csPzL39Z@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230417081510.GA19964@pendragon.ideasonboard.com> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417080117.jiqpynebq2we2hh4@pengutronix.de> <20230417081510.GA19964@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_025931_765941_8C8324C1 X-CRM114-Status: GOOD ( 34.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 17. April 2023, 10:15:10 CEST schrieb Laurent Pinchart: > Hi Marco, > = > On Mon, Apr 17, 2023 at 10:01:17AM +0200, Marco Felsch wrote: > > On 23-04-17, Laurent Pinchart wrote: > > > On Mon, Apr 17, 2023 at 08:50:59AM +0200, Marco Felsch wrote: > > > > Hi Laurent, > > > > = > > > > your patch LGTM just one nit/idea, please see below. > > > > = > > > > On 23-04-17, Laurent Pinchart wrote: > > > > > Add DT nodes for the two CSI-2 receivers of the i.MX8MP. > > > > > = > > > > > Signed-off-by: Laurent Pinchart > > > > > --- > > > > > = > > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 60 > > > > > +++++++++++++++++++++++ > > > > > 1 file changed, 60 insertions(+) > > > > > = > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > > > > > 2dd60e3252f3..2a374a4c14a2 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > @@ -1239,6 +1239,66 @@ ldb_lvds_ch1: endpoint { > > > > > = > > > > > }; > > > > > = > > > > > }; > > > > > = > > > > > + mipi_csi_0: csi@32e40000 { > > > > > + compatible =3D "fsl,imx8mp- mipi-csi2", "fsl,imx8mm-mipi-csi2"; > > > > > + reg =3D <0x32e40000 0x10000>; > > > > > + interrupts =3D ; > > > > > + clock-frequency =3D = <500000000>; > > > > > + clocks =3D <&clk = IMX8MP_CLK_MEDIA_APB_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_AXI_ROOT>; > > > > > + clock-names =3D "pclk", = "wrap", "phy", "axi"; > > > > > + assigned-clocks =3D <&clk = IMX8MP_CLK_MEDIA_CAM1_PIX>; > > > > > + assigned-clock-parents =3D = <&clk IMX8MP_SYS_PLL2_1000M>; > > > > > + assigned-clock-rates =3D = <500000000>; > > > > > + power-domains =3D = <&media_blk_ctrl > > > > > IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > > > > > + status =3D "disabled"; > > > > > + > > > > > + ports { > > > > > + #address-cells =3D = <1>; > > > > > + #size-cells =3D <0>; > > > > > + > > > > > + port@0 { > > > > > + reg =3D = <0>; > > > > = > > > > If we would add: > > > > mipi_csi_0_in: = endpoint {}; > > > > = > > > > here we could refernce it from overlays/board dts files more easily. > > > = > > > Isn't there an unwritten rule (or consensus) that an endpoint should > > > always have a remote-endpoint property ? > > = > > I don't know if there is one. > > = > > > While ports describe hardware properties of a device and should always > > > be there regardless of connections, endpoints describe connections and > > > I don't think they should be instantiated with a valid > > > remote-endpoint. > > = > > I know, therefore I mentioned it as idea to make it 'easier' to add > > camera nodes. > = > As a middleground, would it be useful to have a label for the port ? > Something like > = > mipi_csi_0: csi@32e40000 { > ports { > mipi_csi_0_port_0: port@0 { > }; > }; > }; > = > An overlay could then reference that and create the endpoint. I'm not > entirely sure how useful that would be though, as the overlay would need > to enable the CSI node anyway. Compare > = > -------- > &mipi_csi_0 { > status =3D "okay"; > }; > = > &mipi_csi_0_port_0 { > mipi_csi_0_in: endpoint { > remote-endpoint =3D <&imx327_out>; > }; > }; > -------- > = > with > = > -------- > &mipi_csi_0 { > status =3D "okay"; > = > ports { > port@0 { > mipi_csi_0_in: endpoint { > remote-endpoint =3D <&imx327_out>; > }; > }; > }; > }; > -------- > = > I have a slight preference for the latter as it groups all the CSI0 data > in a single overlay target, but if the former is generally preferred, > I'm fine with that too. The former is more compact, but also raises the following dtc warnings whil= e = creating the .dtbo: Warning (graph_endpoint): /fragment@4/__overlay__: graph endpoint node name = should be 'endpoint' Warning (graph_endpoint): /fragment@4/__overlay__: graph connection to node= '/ fragment@1/__overlay__/ports/port@1/endpoint' is not bidirectional for the following snippet: &mipi_csi_0_out { remote-endpoint =3D <&isp1_in>; }; I'm not sure if there is a chance to fix at all. Best regards, Alexander > = > > > > > + }; > > > > > + > > > > > + port@1 { > > > > > + reg =3D = <1>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > + > > > > > + mipi_csi_1: csi@32e50000 { > > > > > + compatible =3D "fsl,imx8mp- mipi-csi2", "fsl,imx8mm-mipi-csi2"; > > > > > + reg =3D <0x32e50000 0x10000>; > > > > > + interrupts =3D ; > > > > > + clock-frequency =3D = <266000000>; > > > > > + clocks =3D <&clk = IMX8MP_CLK_MEDIA_APB_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_CAM2_PIX_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > > > > > + <&clk = IMX8MP_CLK_MEDIA_AXI_ROOT>; > > > > > + clock-names =3D "pclk", = "wrap", "phy", "axi"; > > > > > + assigned-clocks =3D <&clk = IMX8MP_CLK_MEDIA_CAM2_PIX>; > > > > > + assigned-clock-parents =3D = <&clk IMX8MP_SYS_PLL2_1000M>; > > > > > + assigned-clock-rates =3D = <266000000>; > > > > > + power-domains =3D = <&media_blk_ctrl > > > > > IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > > > > > + status =3D "disabled"; > > > > > + > > > > > + ports { > > > > > + #address-cells =3D = <1>; > > > > > + #size-cells =3D <0>; > > > > > + > > > > > + port@0 { > > > > > + reg =3D = <0>; > > > > > + }; > > > > > + > > > > > + port@1 { > > > > > + reg =3D = <1>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > + > > > > > = > > > > > pcie_phy: pcie-phy@32f00000 { > > > > > = > > > > > compatible =3D "fsl,imx8mp- pcie-phy"; > > > > > reg =3D <0x32f00000 0x10000>; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94552C77B70 for ; Mon, 17 Apr 2023 10:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbjDQKBU (ORCPT ); Mon, 17 Apr 2023 06:01:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjDQKBT (ORCPT ); Mon, 17 Apr 2023 06:01:19 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64E852D62; Mon, 17 Apr 2023 03:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1681725635; x=1713261635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b/8P0WGhAa/Cc5Bb3QAKq9k0biS4kx5qfPVA+BMlmjs=; b=YVc7MD3hExk/dZeu7xbCKZpBsk/cevgu2StUj1ub+TDD1IfHk7q6U3/o 1Q8lXPKpYlaAXvdyaK6pdCz++rtSTL/GshvxK8XodOhQW8b57l324YxMP cyNKyFjCRRAvtoAkRbqfjqC6oLzoSpgazP2INyoDc3nm3mzGM7+wQNV+H dX5SGcHOIcbrpWJ6BH1KkTvHOslyB7s8iwju7LIAuervGdYYy9CtUl41X ZF5iQP3bGsNpeN2Npcm8ZeL/lMB4pzCvbiZm9jI7AmfxGoNyZz6ngTlW6 IFuPWGZZOeK7LMCZkVwlh0cKYvVtPtF+VU7CDF2ZukfNE6wiUaIfGmIfQ g==; X-IronPort-AV: E=Sophos;i="5.99,203,1677538800"; d="scan'208";a="30364744" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 17 Apr 2023 11:59:27 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 17 Apr 2023 11:59:27 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 17 Apr 2023 11:59:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1681725567; x=1713261567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b/8P0WGhAa/Cc5Bb3QAKq9k0biS4kx5qfPVA+BMlmjs=; b=L7vK7M+27Zq5hO2gFV99eTmlGC2x9BS7e7jaQWJt5xzWltqJZimF5seS P12V568buhFVCcepDb1oAFFqI9Izl/u2W0kPMPEIa4c0GT/CJ9eMpdJK+ XkAStRwbQGZTC0wRvQLz+UsO0uKzsxK0GruKV/J0d9z5iIT5Z06xspfRC zpru3ItHvCtF61SB0hiVGtqbVAZqsKIMvuYbo8aMA34lKLQOTKZkX9J0g bKhobu/FGIYzYdy6oLoY8dEankUZM+/CjLfToIweppvm2aEe11f/+cqN3 XVT/6aYtSM7x8e5L7WOCRC+xy6okZ0HMoI0mVihZRyJUoS4TqIdR8kaZe Q==; X-IronPort-AV: E=Sophos;i="5.99,203,1677538800"; d="scan'208";a="30364743" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Apr 2023 11:59:27 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id ECF37280072; Mon, 17 Apr 2023 11:59:26 +0200 (CEST) From: Alexander Stein To: Marco Felsch , linux-arm-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Xavier Roumegue , Rob Herring , linux-imx@nxp.com, Krzysztof Kozlowski , Jacopo Mondi , Shawn Guo , linux-media@vger.kernel.org, Laurent Pinchart Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes Date: Mon, 17 Apr 2023 11:59:25 +0200 Message-ID: <3232774.44csPzL39Z@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230417081510.GA19964@pendragon.ideasonboard.com> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417080117.jiqpynebq2we2hh4@pengutronix.de> <20230417081510.GA19964@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Montag, 17. April 2023, 10:15:10 CEST schrieb Laurent Pinchart: > Hi Marco, >=20 > On Mon, Apr 17, 2023 at 10:01:17AM +0200, Marco Felsch wrote: > > On 23-04-17, Laurent Pinchart wrote: > > > On Mon, Apr 17, 2023 at 08:50:59AM +0200, Marco Felsch wrote: > > > > Hi Laurent, > > > >=20 > > > > your patch LGTM just one nit/idea, please see below. > > > >=20 > > > > On 23-04-17, Laurent Pinchart wrote: > > > > > Add DT nodes for the two CSI-2 receivers of the i.MX8MP. > > > > >=20 > > > > > Signed-off-by: Laurent Pinchart > > > > > --- > > > > >=20 > > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 60 > > > > > +++++++++++++++++++++++ > > > > > 1 file changed, 60 insertions(+) > > > > >=20 > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > > > > > 2dd60e3252f3..2a374a4c14a2 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > > @@ -1239,6 +1239,66 @@ ldb_lvds_ch1: endpoint { > > > > >=20 > > > > > }; > > > > > =09 > > > > > }; > > > > >=20 > > > > > + mipi_csi_0: csi@32e40000 { > > > > > + compatible =3D "fsl,imx8mp- mipi-csi2", "fsl,imx8mm-mipi-csi2"; > > > > > + reg =3D <0x32e40000 0x10000>; > > > > > + interrupts =3D ; > > > > > + clock-frequency =3D=20 <500000000>; > > > > > + clocks =3D <&clk=20 IMX8MP_CLK_MEDIA_APB_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_AXI_ROOT>; > > > > > + clock-names =3D "pclk",=20 "wrap", "phy", "axi"; > > > > > + assigned-clocks =3D <&clk=20 IMX8MP_CLK_MEDIA_CAM1_PIX>; > > > > > + assigned-clock-parents =3D=20 <&clk IMX8MP_SYS_PLL2_1000M>; > > > > > + assigned-clock-rates =3D=20 <500000000>; > > > > > + power-domains =3D=20 <&media_blk_ctrl > > > > > IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > > > > > + status =3D "disabled"; > > > > > + > > > > > + ports { > > > > > + #address-cells =3D=20 <1>; > > > > > + #size-cells =3D <0>; > > > > > + > > > > > + port@0 { > > > > > + reg =3D=20 <0>; > > > >=20 > > > > If we would add: > > > > mipi_csi_0_in:=20 endpoint {}; > > > >=20 > > > > here we could refernce it from overlays/board dts files more easily. > > >=20 > > > Isn't there an unwritten rule (or consensus) that an endpoint should > > > always have a remote-endpoint property ? > >=20 > > I don't know if there is one. > >=20 > > > While ports describe hardware properties of a device and should always > > > be there regardless of connections, endpoints describe connections and > > > I don't think they should be instantiated with a valid > > > remote-endpoint. > >=20 > > I know, therefore I mentioned it as idea to make it 'easier' to add > > camera nodes. >=20 > As a middleground, would it be useful to have a label for the port ? > Something like >=20 > mipi_csi_0: csi@32e40000 { > ports { > mipi_csi_0_port_0: port@0 { > }; > }; > }; >=20 > An overlay could then reference that and create the endpoint. I'm not > entirely sure how useful that would be though, as the overlay would need > to enable the CSI node anyway. Compare >=20 > -------- > &mipi_csi_0 { > status =3D "okay"; > }; >=20 > &mipi_csi_0_port_0 { > mipi_csi_0_in: endpoint { > remote-endpoint =3D <&imx327_out>; > }; > }; > -------- >=20 > with >=20 > -------- > &mipi_csi_0 { > status =3D "okay"; >=20 > ports { > port@0 { > mipi_csi_0_in: endpoint { > remote-endpoint =3D <&imx327_out>; > }; > }; > }; > }; > -------- >=20 > I have a slight preference for the latter as it groups all the CSI0 data > in a single overlay target, but if the former is generally preferred, > I'm fine with that too. The former is more compact, but also raises the following dtc warnings whil= e=20 creating the .dtbo: Warning (graph_endpoint): /fragment@4/__overlay__: graph endpoint node name= =20 should be 'endpoint' Warning (graph_endpoint): /fragment@4/__overlay__: graph connection to node= '/ fragment@1/__overlay__/ports/port@1/endpoint' is not bidirectional for the following snippet: &mipi_csi_0_out { remote-endpoint =3D <&isp1_in>; }; I'm not sure if there is a chance to fix at all. Best regards, Alexander >=20 > > > > > + }; > > > > > + > > > > > + port@1 { > > > > > + reg =3D=20 <1>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > + > > > > > + mipi_csi_1: csi@32e50000 { > > > > > + compatible =3D "fsl,imx8mp- mipi-csi2", "fsl,imx8mm-mipi-csi2"; > > > > > + reg =3D <0x32e50000 0x10000>; > > > > > + interrupts =3D ; > > > > > + clock-frequency =3D=20 <266000000>; > > > > > + clocks =3D <&clk=20 IMX8MP_CLK_MEDIA_APB_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_CAM2_PIX_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > > > > > + <&clk=20 IMX8MP_CLK_MEDIA_AXI_ROOT>; > > > > > + clock-names =3D "pclk",=20 "wrap", "phy", "axi"; > > > > > + assigned-clocks =3D <&clk=20 IMX8MP_CLK_MEDIA_CAM2_PIX>; > > > > > + assigned-clock-parents =3D=20 <&clk IMX8MP_SYS_PLL2_1000M>; > > > > > + assigned-clock-rates =3D=20 <266000000>; > > > > > + power-domains =3D=20 <&media_blk_ctrl > > > > > IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > > > > > + status =3D "disabled"; > > > > > + > > > > > + ports { > > > > > + #address-cells =3D=20 <1>; > > > > > + #size-cells =3D <0>; > > > > > + > > > > > + port@0 { > > > > > + reg =3D=20 <0>; > > > > > + }; > > > > > + > > > > > + port@1 { > > > > > + reg =3D=20 <1>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > + > > > > >=20 > > > > > pcie_phy: pcie-phy@32f00000 { > > > > > =09 > > > > > compatible =3D "fsl,imx8mp- pcie-phy"; > > > > > reg =3D <0x32f00000 0x10000>; =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/