All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel/time/jiffies.c - make variable static
@ 2019-03-12  8:38 Valdis Klētnieks
  2019-03-22 12:43 ` [tip:timers/urgent] time/jiffies: Make refined_jiffies static tip-bot for Valdis Kletnieks
  0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2019-03-12  8:38 UTC (permalink / raw)
  To: Ingo Molnar, Thomas Gleixner; +Cc: linux-kernel

sparse complains:

  CHECK   kernel/time/jiffies.c
kernel/time/jiffies.c:92:20: warning: symbol 'refined_jiffies' was not declared. Should it be static?

__clocksource_register() is passed a pointer, and nothing else refers to it. Make it static.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index dc1b6f1929f9..ac9c03dd6c7d 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -89,7 +89,7 @@ struct clocksource * __init __weak clocksource_default_clock(void)
 	return &clocksource_jiffies;
 }
 
-struct clocksource refined_jiffies;
+static struct clocksource refined_jiffies;
 
 int register_refined_jiffies(long cycles_per_second)
 {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:timers/urgent] time/jiffies: Make refined_jiffies static
  2019-03-12  8:38 [PATCH] kernel/time/jiffies.c - make variable static Valdis Klētnieks
@ 2019-03-22 12:43 ` tip-bot for Valdis Kletnieks
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Valdis Kletnieks @ 2019-03-22 12:43 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: hpa, linux-kernel, valdis.kletnieks, tglx, mingo

Commit-ID:  e8750053d64a3317cbc15f8341f0f11ca751bfeb
Gitweb:     https://git.kernel.org/tip/e8750053d64a3317cbc15f8341f0f11ca751bfeb
Author:     Valdis Kletnieks <valdis.kletnieks@vt.edu>
AuthorDate: Tue, 12 Mar 2019 04:38:35 -0400
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 22 Mar 2019 13:38:26 +0100

time/jiffies: Make refined_jiffies static

sparse complains:

  CHECK   kernel/time/jiffies.c
kernel/time/jiffies.c:92:20: warning: symbol 'refined_jiffies' was not
			     	      declared. Should it be static?

Its only used in file scope. Make it static.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/32342.1552379915@turing-police

---
 kernel/time/jiffies.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index dc1b6f1929f9..ac9c03dd6c7d 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -89,7 +89,7 @@ struct clocksource * __init __weak clocksource_default_clock(void)
 	return &clocksource_jiffies;
 }
 
-struct clocksource refined_jiffies;
+static struct clocksource refined_jiffies;
 
 int register_refined_jiffies(long cycles_per_second)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-22 12:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12  8:38 [PATCH] kernel/time/jiffies.c - make variable static Valdis Klētnieks
2019-03-22 12:43 ` [tip:timers/urgent] time/jiffies: Make refined_jiffies static tip-bot for Valdis Kletnieks

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.