From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 490E4C3A5A9 for ; Mon, 4 May 2020 23:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C976206EB for ; Mon, 4 May 2020 23:49:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="rYVmW9zd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728430AbgEDXtV (ORCPT ); Mon, 4 May 2020 19:49:21 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:55250 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728353AbgEDXtV (ORCPT ); Mon, 4 May 2020 19:49:21 -0400 Received: from [192.168.254.4] (unknown [50.34.219.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 70B6A13C2B0; Mon, 4 May 2020 16:49:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 70B6A13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1588636160; bh=FOB1U3QVYCyG3wm/IhkIjxv7yks2Kjv4QKsl8PiY2XI=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=rYVmW9zddMvVkJtdh6fQKF9z6ggOQhrOrWt5RnIty5MjBywlAbB7z3iQErMSEKz9s jcNBAcHhXe/yEYB02rQ0Bj7JdhvEag92sGPfxuVVXVJ5NWq2EMYzbJwbuTt0HuXhYH BS4jR+VTl9QBkB2gBIhzJJ0Q0M+K1sEOQcqtkd9s= Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics To: Rajkumar Manoharan , Markus Theil References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, linux-wireless-owner@vger.kernel.org From: Ben Greear Message-ID: <323b4d4f-a967-cf63-6f5a-04f53802c50a@candelatech.com> Date: Mon, 4 May 2020 16:49:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: > On 2020-05-04 08:41, Markus Theil wrote: >> ath10k currently reports survey results for the last interval between each >> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this >> can lead to unexpectedly small results, e.g. when hostapd uses survey >> data and iw survey dump is invoked in parallel. Fix this by returning >> cumulative results, that don't depend on the last invocation. Other >> drivers, e.g. ath9k or mt76 also use this behavior. >> >> Signed-off-by: Markus Theil >> > > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. > Simple one line change is enough. > > https://patchwork.kernel.org/patch/10550707/ > > -Rajkumar Have you tested this with wave-1? Lots of older, at least, firmware has brokenness in this area. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> From: Ben Greear Message-ID: <323b4d4f-a967-cf63-6f5a-04f53802c50a@candelatech.com> Date: Mon, 4 May 2020 16:49:19 -0700 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan , Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: > On 2020-05-04 08:41, Markus Theil wrote: >> ath10k currently reports survey results for the last interval between each >> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this >> can lead to unexpectedly small results, e.g. when hostapd uses survey >> data and iw survey dump is invoked in parallel. Fix this by returning >> cumulative results, that don't depend on the last invocation. Other >> drivers, e.g. ath9k or mt76 also use this behavior. >> >> Signed-off-by: Markus Theil >> > > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. > Simple one line change is enough. > > https://patchwork.kernel.org/patch/10550707/ > > -Rajkumar Have you tested this with wave-1? Lots of older, at least, firmware has brokenness in this area. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> From: Ben Greear Message-ID: <323b4d4f-a967-cf63-6f5a-04f53802c50a@candelatech.com> Date: Mon, 4 May 2020 16:49:19 -0700 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan , Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote: > On 2020-05-04 08:41, Markus Theil wrote: >> ath10k currently reports survey results for the last interval between each >> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this >> can lead to unexpectedly small results, e.g. when hostapd uses survey >> data and iw survey dump is invoked in parallel. Fix this by returning >> cumulative results, that don't depend on the last invocation. Other >> drivers, e.g. ath9k or mt76 also use this behavior. >> >> Signed-off-by: Markus Theil >> > > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. > Simple one line change is enough. > > https://patchwork.kernel.org/patch/10550707/ > > -Rajkumar Have you tested this with wave-1? Lots of older, at least, firmware has brokenness in this area. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k