From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC99C433E1 for ; Fri, 14 Aug 2020 17:12:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44DD220838 for ; Fri, 14 Aug 2020 17:12:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N3zwz4kQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728397AbgHNRMP (ORCPT ); Fri, 14 Aug 2020 13:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbgHNRMP (ORCPT ); Fri, 14 Aug 2020 13:12:15 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB2AC061385 for ; Fri, 14 Aug 2020 10:12:14 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id b30so5170279lfj.12 for ; Fri, 14 Aug 2020 10:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oTnqLQcun1oAd2jUgg7+f/faki/0xT/2c6vC8h9xpbw=; b=N3zwz4kQcVvMDiCWrRIXQz2rRp6Dmu6TWX489BnbDLouEXbPNNxetAQAHQn7vcfPdu D9dcGIwxDz5vTquvaVCKu8GwUZ6SxBY5udXv80hJnLBc4vR2jd3e4cGFahp67Xp6XZWE mxNwn2EuMvR6D0c6CP82qtNyRQrf2d8koRH03SsRhkmFhZqZWBxAlMQtIJMenvRsPp79 9bea1KRn3PBOL0pvZXzkH2XhjfiP90TOPxtXA0XCDKHhIlzkJ+CPggG27aaCShGiNEC1 RnhRYAG3Nx4KQ15TPkWH5lpOwxRJoFnFcRUEEF0+RctAWC1tIcMCmdR4DKvdpiyvkLPf VQdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oTnqLQcun1oAd2jUgg7+f/faki/0xT/2c6vC8h9xpbw=; b=BGLQFSFbRHuX4jnFeweRmRVVcdr4KDSC3a2cELfMPjpQD0jxr575XWCegtftL7EyHj 3yXYyNIxPaW1p9PoDYTZvTaqZKBiN9mkVST+A1Nuc3U/1YMLt6F1LR6ZjZV9b4UOvPun Sn7lBcrc79gCALzUIWR3VqR5AcNEMDQAoj/EH4Pbvr/SxwXVI1eKVf/XDCEqwQvmwr5T jOacnexxgJ2bkF1M3foFARr03Blled2oAh3npId8E22Yp2710GWlcMMQGI8qXaWC3gTx oKeNm683QoVjQ7kmOqeWfL8hrQEGZB5IrQ7SCez+TgZt5n/n4OpNDxJ3bCre7k2K4i0D NEgQ== X-Gm-Message-State: AOAM533b6LQdnUDORSYsxt6Ti716q4740pvMKR6QdtB5sPbrHUquAApx EQcV9Da6nXIT0PsVvNN04xJ0AA== X-Google-Smtp-Source: ABdhPJwthnbVLKpJB0/hPo/55RCT2z4Bd1DEwwzsboqMb6G7MLrh7IK+1wUoKkMpH/2PdYyI/Fnvuw== X-Received: by 2002:ac2:5468:: with SMTP id e8mr1656731lfn.83.1597425132894; Fri, 14 Aug 2020 10:12:12 -0700 (PDT) Received: from [192.168.43.7] ([188.162.64.200]) by smtp.gmail.com with ESMTPSA id q10sm1874788ljh.110.2020.08.14.10.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2020 10:12:12 -0700 (PDT) Subject: Re: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support To: Tanmay Shah , swboyd@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com Cc: linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, seanpaul@chromium.org, daniel@ffwll.ch, airlied@linux.ie, aravindh@codeaurora.org, abhinavk@codeaurora.org, khsieh@codeaurora.org, Chandan Uddaraju , Vara Reddy , Guenter Roeck References: <20200812044223.19279-1-tanmay@codeaurora.org> <20200812044223.19279-3-tanmay@codeaurora.org> From: Dmitry Baryshkov Message-ID: <324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org> Date: Fri, 14 Aug 2020 20:12:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200812044223.19279-3-tanmay@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello, On 12/08/2020 07:42, Tanmay Shah wrote: > From: Chandan Uddaraju [skipped] > + } else if ((dp_parser_check_prefix("ctrl", clk_name) || > + dp_parser_check_prefix("stream", clk_name)) && > + ctrl_clk_index < ctrl_clk_count) { > + struct dss_clk *clk = > + &ctrl_power->clk_config[ctrl_clk_index]; > + strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name)); > + ctrl_clk_index++; > + > + if (!strncmp(clk_name, "ctrl_link", > + strlen("ctrl_link")) || > + !strncmp(clk_name, "stream_pixel", > + strlen("ctrl_pixel"))) This should be "stream_pixel", I believe. I don't like macros, but most probably it would help here. Also function/brace alignment could be better (sorry, it really hides the issue here). > + clk->type = DSS_CLK_PCLK; > + else > + clk->type = DSS_CLK_AHB; > + } > + } -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB60AC433E1 for ; Mon, 17 Aug 2020 07:07:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE1A62072D for ; Mon, 17 Aug 2020 07:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N3zwz4kQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE1A62072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE4D16E44D; Mon, 17 Aug 2020 07:06:40 +0000 (UTC) Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AF2C6EB90 for ; Fri, 14 Aug 2020 17:12:14 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id h8so5180496lfp.9 for ; Fri, 14 Aug 2020 10:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oTnqLQcun1oAd2jUgg7+f/faki/0xT/2c6vC8h9xpbw=; b=N3zwz4kQcVvMDiCWrRIXQz2rRp6Dmu6TWX489BnbDLouEXbPNNxetAQAHQn7vcfPdu D9dcGIwxDz5vTquvaVCKu8GwUZ6SxBY5udXv80hJnLBc4vR2jd3e4cGFahp67Xp6XZWE mxNwn2EuMvR6D0c6CP82qtNyRQrf2d8koRH03SsRhkmFhZqZWBxAlMQtIJMenvRsPp79 9bea1KRn3PBOL0pvZXzkH2XhjfiP90TOPxtXA0XCDKHhIlzkJ+CPggG27aaCShGiNEC1 RnhRYAG3Nx4KQ15TPkWH5lpOwxRJoFnFcRUEEF0+RctAWC1tIcMCmdR4DKvdpiyvkLPf VQdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oTnqLQcun1oAd2jUgg7+f/faki/0xT/2c6vC8h9xpbw=; b=i1B9+2NlgEd7/TfKtXv5xysF4tnmsc1Ku8UiwixUPfhADobSjsg7Ri3YeRaKqqHyV2 eY5QKmTjWJaLUC1CmlFS5tIK3GWSHsVGLbfLnnPC1PsgwxabgPHsmfAcDhaSffqpu73c 2gvwi1spRGjrOTLAUvHTyAfTkuhRhL6uSCKsmc8d/eqp8IeAMSaL/hJstSyeNpkVieQ6 YpaSSNfBgNY6jAp0iaG0m4brWGWocp2e0JSRkZJHfAux0O3SJvw/rGes/fzy93S1c6bL Jzu++6aAGrS9FJ77GYLytHZRG3O1O1i1iEBPQe1G5oVpUHIQ4q6NiWCzWHZu+zmFMQ0b /ZnQ== X-Gm-Message-State: AOAM5312uR7DciMMGVYuw7947wU+KDx0PZOzkVf+tKycCs/o1ZVDuxO7 AGptHEv79tH+zMwa+CtvHgeXfg== X-Google-Smtp-Source: ABdhPJwthnbVLKpJB0/hPo/55RCT2z4Bd1DEwwzsboqMb6G7MLrh7IK+1wUoKkMpH/2PdYyI/Fnvuw== X-Received: by 2002:ac2:5468:: with SMTP id e8mr1656731lfn.83.1597425132894; Fri, 14 Aug 2020 10:12:12 -0700 (PDT) Received: from [192.168.43.7] ([188.162.64.200]) by smtp.gmail.com with ESMTPSA id q10sm1874788ljh.110.2020.08.14.10.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2020 10:12:12 -0700 (PDT) Subject: Re: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support To: Tanmay Shah , swboyd@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com References: <20200812044223.19279-1-tanmay@codeaurora.org> <20200812044223.19279-3-tanmay@codeaurora.org> From: Dmitry Baryshkov Message-ID: <324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org> Date: Fri, 14 Aug 2020 20:12:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200812044223.19279-3-tanmay@codeaurora.org> Content-Language: en-US X-Mailman-Approved-At: Mon, 17 Aug 2020 07:06:11 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, khsieh@codeaurora.org, seanpaul@chromium.org, Guenter Roeck , Vara Reddy , aravindh@codeaurora.org, freedreno@lists.freedesktop.org, Chandan Uddaraju Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, On 12/08/2020 07:42, Tanmay Shah wrote: > From: Chandan Uddaraju [skipped] > + } else if ((dp_parser_check_prefix("ctrl", clk_name) || > + dp_parser_check_prefix("stream", clk_name)) && > + ctrl_clk_index < ctrl_clk_count) { > + struct dss_clk *clk = > + &ctrl_power->clk_config[ctrl_clk_index]; > + strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name)); > + ctrl_clk_index++; > + > + if (!strncmp(clk_name, "ctrl_link", > + strlen("ctrl_link")) || > + !strncmp(clk_name, "stream_pixel", > + strlen("ctrl_pixel"))) This should be "stream_pixel", I believe. I don't like macros, but most probably it would help here. Also function/brace alignment could be better (sorry, it really hides the issue here). > + clk->type = DSS_CLK_PCLK; > + else > + clk->type = DSS_CLK_AHB; > + } > + } -- With best wishes Dmitry _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel