From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCA2C433F5 for ; Fri, 11 Feb 2022 18:55:51 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F0AB4068E; Fri, 11 Feb 2022 19:55:50 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id A2C8140140 for ; Fri, 11 Feb 2022 19:55:48 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 24A523201D90; Fri, 11 Feb 2022 13:55:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 11 Feb 2022 13:55:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=g9nHogv+oe1+Dg QXVZ/W1k4keJfGx22egTRQEbNYt4s=; b=W797Vrrp91REVxoEeLO/vFjCQ2/2pP SklPvQRQgoA+Am95zk4Kn9jfXyeyLaoH3HKosXcMxO4F/WarJt4ahWjtzcDR6ThN igJBNfnzT0uiXihaFraeZ7HYqQ82D5vER6CQ9flalJAKYihubcqMH+GtjTFs//lr z5kYSPMLxtzwIjBEKwZlztbDOwVglDHubhrCxdwk6xvo0Dey4tvo4NDxOjv3mVXO I7NuEjFpsPoB3M+jUl265h7vbMrpV/gSeLnpUTyK2m4AJwc+FYNXIx5uhVxy7fJ/ EVO+n/JvCcO92YhxhkAMICaml1hmulNA8mv5h4zJ1ZOfXXiyh+uxO2fA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=g9nHogv+oe1+DgQXVZ/W1k4keJfGx22egTRQEbNYt 4s=; b=ObBNR4lUjS1zeDpwEQgMEvWHrLUbLqY4WPSwnhOKmdDzT6lRfU7TAUf+e 7HIH3Q2preLSI5jVo1zU0QZ/WZZKmDJrku/iHR5gc0YW8OUPtQ9CMgkfjoevxinK kl1+wNpH6mLiDfx+Qn8ek4oCBvL18uZuq6LyGzcoqZliCUDObd1oHLA9ps8Z2TIq kz17Co1A9N2hgdvUDPQYz4Iz/NHGHZZhSKxw4HoXhEIFYoRZGYFA8YZUY6JX1pqS ibayVbTNWgLzir4hvxvevpglMtGtairZpakG/IsLtnyGimeBxdCsz5+kYxfQf85Y /qw55zy4sREl01XSzGZXAm7xlKgPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieefgdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Feb 2022 13:55:45 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , Anatoly Burakov , dev@dpdk.org Subject: Re: [PATCH v4 2/2] ethdev: move driver interface functions to its own file Date: Fri, 11 Feb 2022 19:55:44 +0100 Message-ID: <3252260.usfYGdeWWP@thomas> In-Reply-To: <20220211183832.1904132-2-ferruh.yigit@intel.com> References: <20220208194437.426143-1-ferruh.yigit@intel.com> <20220211183832.1904132-1-ferruh.yigit@intel.com> <20220211183832.1904132-2-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/02/2022 19:38, Ferruh Yigit: > ethdev has two interfaces, one interface between applications and > library, these APIs are declared in the ethdev.h public header. > Other interface is between drivers and library, these functions are > declared in ethdev_driver.h and marked as internal. > > But all functions are defined in rte_ethdev.c file. This patch moves > functions for drivers to its own file, ethdev_driver.c for cleanup, no > functional change in functions. > > Some public APIs and driver APIs call common internal functions, which here > were mostly static since both were in same file. To be able to move > driver APIs, common functions are moved into ethdev_private.c. and there, "driver APIs" should be "driver helpers", right? > (ethdev_private.c is used for functions that are internal to the library > and shared by multiple .c files in the ethdev library.) > > Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon