From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv6 00/33] NXP DPAA2 PMD Date: Thu, 26 Jan 2017 19:02:06 +0100 Message-ID: <3259922.9T20GZHyr3@xps13> References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <67f91414-0439-952d-e07f-23556db110d9@intel.com> <99c7a139-6098-b7ce-25a1-ee3efb045ff0@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com To: Hemant Agrawal , Ferruh Yigit Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 1F85B108D for ; Thu, 26 Jan 2017 19:02:08 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id c206so97814930wme.0 for ; Thu, 26 Jan 2017 10:02:08 -0800 (PST) In-Reply-To: <99c7a139-6098-b7ce-25a1-ee3efb045ff0@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-26 17:48, Hemant Agrawal: > On 1/26/2017 5:25 PM, Ferruh Yigit wrote: > > On 1/23/2017 5:56 PM, Ferruh Yigit wrote: > >> I have some concerns about this PMD, > >> > >> - This is a big one, as seen above, and it is hard to review it all, I > >> don't feel confident about the amount of review done, more reviewers are > >> welcome. And we are already post RC1. > >> > >> - Although this driver introduces a new bus type, in some parts, driver > >> still has virtual devices like usage, perhaps this is not because of > >> this PMD but mostly because of overall dpdk bus structure. Still I have > >> concerns about getting driver like this, and would like to hear more > >> comments. > > > > As a result of above concerns, I propose postponing this PMD to 17.05 > > release. > > > > The dependent rte_bus just get into main repo less than two weeks ago, > > also this driver comes with a few new things first of its kind, and it > > matters to make first samples correct. > > > > I believe it is good to let the PMD be around a little more to give > > chance to both PMD and rte_bus to become more mature. > > > > I agree that this driver is coming with few new thing and it is taking > time to come up with agreeable and good solution for some of this new stuff. > > Finalizing the right framework for adding SoC based drivers took a > little longer than expected. But thanks to Thomas help in the last that > we got the basic bus framework integrated. > > Thomos- is it possible to integrate it early in 17.05 cycle, rather than > waiting till end? Yes that's a really good question. I could reword it to "when do we pull from next-* trees"? I think you and Ferruh can work to integrate it in next-net before the beginning of 17.05. So I could do a first pull of next-net when starting the 17.05 cycle. Note that 17.05 will start in few weeks.