From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 1/2] net/virtio: fix unchecked return value Date: Fri, 9 Nov 2018 12:38:05 +0100 Message-ID: <325febfb-13ae-24c1-83d6-cc0a67e53da6@redhat.com> References: <20181107090102.9364-1-tiwei.bie@intel.com> <20181107090102.9364-2-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CCC244C96 for ; Fri, 9 Nov 2018 12:38:09 +0100 (CET) In-Reply-To: <20181107090102.9364-2-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/7/18 10:01 AM, Tiwei Bie wrote: > Coverity issue: 302861 > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > > Signed-off-by: Tiwei Bie > --- > This patch can't be backported because it depends on the > API change introduced by below commit in this release. > > commit e8d435f1f3a1 ("bus/pci: harmonize return value of config read") > > drivers/net/virtio/virtio_pci.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index 21110cd69..c8883c32e 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -614,9 +614,15 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > hw->common_cfg = get_cfg_addr(dev, &cap); > break; > case VIRTIO_PCI_CAP_NOTIFY_CFG: > - rte_pci_read_config(dev, &hw->notify_off_multiplier, > + ret = rte_pci_read_config(dev, > + &hw->notify_off_multiplier, > 4, pos + sizeof(cap)); > - hw->notify_base = get_cfg_addr(dev, &cap); > + if (ret != 4) > + PMD_INIT_LOG(DEBUG, > + "failed to read notify_off_multiplier, ret %d", > + ret); > + else > + hw->notify_base = get_cfg_addr(dev, &cap); > break; > case VIRTIO_PCI_CAP_DEVICE_CFG: > hw->dev_cfg = get_cfg_addr(dev, &cap); > Reviewed-by: Maxime Coquelin Thanks, Maxime