From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B58C07E95 for ; Tue, 13 Jul 2021 07:21:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A41B6120A for ; Tue, 13 Jul 2021 07:21:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A41B6120A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3CjN-00086n-C5 for qemu-devel@archiver.kernel.org; Tue, 13 Jul 2021 03:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Cil-0007Mr-CP for qemu-devel@nongnu.org; Tue, 13 Jul 2021 03:20:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Cii-0000Em-Rv for qemu-devel@nongnu.org; Tue, 13 Jul 2021 03:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626160842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cMUl4bvtYHg14qM6CDsT7VUCZvY8oWye3QJI/iGDfYw=; b=AzAk9nt8FgF5pZwljlxw78XGyv0jskCUzt+wctUrlA11S0R2gzoqwkCGY0y+eYaHv0MOad UFFDnhlABQ9W0k75pnU64itQJLvI+sbOG7el4klhC2cm5157K1Eb7NtkxnlSoFc7sdyAgW xgT7EtHy4uLmEjGZ1wodR/z+25iX7cw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-TFP775Z5PhOvVNFa-A1lQw-1; Tue, 13 Jul 2021 03:20:41 -0400 X-MC-Unique: TFP775Z5PhOvVNFa-A1lQw-1 Received: by mail-wr1-f69.google.com with SMTP id u13-20020a5d6dad0000b029012e76845945so8303264wrs.11 for ; Tue, 13 Jul 2021 00:20:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cMUl4bvtYHg14qM6CDsT7VUCZvY8oWye3QJI/iGDfYw=; b=GQDkr0oIKxvOqYZ/oCWaAUlSWUGhqTL9lGkTfGkniql5MpEbFAEYBlNHowALdO9O/M mNrjYPC5f+kcHQxChXZO2kY2sndIjyoFH4LzytUCJ+ZJ6EguAAoshmXmFAwSSf2TY5Wb cebGqoPmYi1MhsTXKTkLeBCfLLuadhYPxxgg4dm8QEOvdgWNwfjHGypqee2tcSlgxHec GIMjTZ7gRcfukfNbL4tJ4pcM+F0d35DTwr5/x6SiVFavsnbwU97KU4vJDnCJBQ/VNRYv QUw6UQEXokjz1PsGfJmFj7CyQPGRIjatOIL7moYD/WGMMQT60ylJUBfuxvp7QKKwbK6H 8XOQ== X-Gm-Message-State: AOAM532Fg6pD8ppazZW06fKwFmAkeLJQFGv4NVQhqRrF71Gud1oRrMLw s1Fsd6mzYM81IApoi52Ov+cxnedCtjXiHVIp6mMctu1w4MgR7x9OslCxxjRA728VTISUXF9k+/h UWZcV21iJ38Nh8gw= X-Received: by 2002:a5d:4812:: with SMTP id l18mr3866028wrq.68.1626160840358; Tue, 13 Jul 2021 00:20:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzI9adlffvd4aafQPKN71r8UCbr129n8uE9wG8FoTE0cyziCRUc+IX3D2B8+BKitiK5D/TPw== X-Received: by 2002:a5d:4812:: with SMTP id l18mr3866007wrq.68.1626160840176; Tue, 13 Jul 2021 00:20:40 -0700 (PDT) Received: from thuth.remote.csb (pd9575fd2.dip0.t-ipconnect.de. [217.87.95.210]) by smtp.gmail.com with ESMTPSA id c2sm12767075wrn.28.2021.07.13.00.20.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 00:20:39 -0700 (PDT) Subject: Re: configure --without-default-features confusion To: Cole Robinson , qemu-devel References: From: Thomas Huth Message-ID: <3261e019-9240-0fe2-0872-e5a77100957e@redhat.com> Date: Tue, 13 Jul 2021 09:20:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.479, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/07/2021 21.12, Cole Robinson wrote: > Hi all, > > I'm a bit confused about the intended scope of ./configure > --without-default-features. When I try it here there's still lots of > stuff enabled: > > $ ./configure --without-default-features > ... > VNC support : YES > VNC SASL support : YES > VNC JPEG support : YES > VNC PNG support : YES > brlapi support : YES > vde support : NO > netmap support : NO > Linux AIO support : NO > Linux io_uring support : YES > ATTR/XATTR support : YES > RDMA support : NO > PVRDMA support : NO > ... > > So rdma/pvrdma, which I have libs for, are disabled, but brlapi, which I > have libs for, is auto enabled. VNC is not dependent on any external > libraries, but it's still enabled. Etc. > > ...okay now that I poke at this a bit, the brlapi bit and most (but not > all) other features are disabled if I fix this: > >> diff --git a/configure b/configure >> index 650d9c0735..a71ebe10ff 100755 >> --- a/configure >> +++ b/configure >> @@ -5189,7 +5189,7 @@ if test "$skip_meson" = no; then >> -Ddocs=$docs -Dsphinx_build=$sphinx_build -Dinstall_blobs=$blobs \ >> -Dvhost_user_blk_server=$vhost_user_blk_server -Dmultiprocess=$multiprocess \ >> -Dfuse=$fuse -Dfuse_lseek=$fuse_lseek -Dguest_agent_msi=$guest_agent_msi -Dbpf=$bpf\ >> - $(if test "$default_features" = no; then echo "-Dauto_features=disabled"; fi) \ >> + $(if test "$default_feature" = no; then echo "-Dauto_features=disabled"; fi) \ Looks like you've found a bug... Could you please send this as a proper patch to the mailing list? > But there's still a handful of things that are left enabled, for example > VNC, xen, vhost-vdpa, ... > > Is the intention for this knob to be a 'disable everything'? I guess yes, but I think it's still work in progress ... not every feature has been revisited since this switch has been introduced. Thomas