From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39342C433ED for ; Wed, 14 Apr 2021 06:13:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16381611EE for ; Wed, 14 Apr 2021 06:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347758AbhDNGNj (ORCPT ); Wed, 14 Apr 2021 02:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347755AbhDNGNd (ORCPT ); Wed, 14 Apr 2021 02:13:33 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 379CFC061574 for ; Tue, 13 Apr 2021 23:13:12 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id m9so5917039wrx.3 for ; Tue, 13 Apr 2021 23:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s/qsaNKElXIqYcGQ3D9DhLtEdzKDUnrwltbMdfbQlx0=; b=z5yWzlbbBA5oiAa5E9YPhUpCjJps/8D8DoXo7AUo//kcHKxstSr1W3PiGiDYTBfRc0 rpoaVDTVB6EWoyuen2alnsuMoBphaebFgJj4YipbWNxMv8KszEayslHsoKRaFOzXAe5L GHkVacYvI7DOQhkXxe2CvB0riGW0reg6A3T4sb/dmljJN+Hk7DBVhYMeMkP2rg0QiQcY 4xi9Vwu/T9ZWqYieGF962BtTz7wNnwm0G6axLl2KhYYhfnhRSpMmg4zl6fntOCNORNfB 3Zsti8DyeRAbksoa4aNJBMfeqR6X9lMz53VkTycJg5ifitXmVeYGb8dhNvKW/hku4CpX xocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s/qsaNKElXIqYcGQ3D9DhLtEdzKDUnrwltbMdfbQlx0=; b=oqIyVsv56/nqIiMr3OU6jW01WHzXbLLLs8Xz2+MowBKNAbcYb7KShaOhK/nVz+ZvzK csR6Mv6qlXzxNiD07fJLjSaw92bt+bc9tLKGmNjle+7OjUZuEFBZ8YSHP+HVi7BaJxgT U7+6fPr0mHOYbERAImjRWr6dEv+sU66Y7et0e3MWxVqmA2HmoSZUyWSUwSLO0nJ1hIVo Z3aT2EwXKIdTmwH+jIGJCDiiJApX4PWZ484ccUPuGQYnS4VMeHcGeSJKLIXMRRHHxSXk maIqUqL1cVPJNeCMHnpOodUewwrCQKhWX7oox3KuwkI0ZTSWjJ0YAfIwF3m2LNJcHP9a JR+A== X-Gm-Message-State: AOAM5317XEvfOgpzbhd4U4Ht65DMyW3jKD9h8bM2cnmKkWmUkja0wykr O+y+Jdg0sjGemZ6JqsjxAat/IA== X-Google-Smtp-Source: ABdhPJwtomDmRAYyV/PE1J2o23D5cj/StMzlkJ7UI2FhKySrxYRdf2Mp0Id9tFDETM2GCVkQPT+JuQ== X-Received: by 2002:a5d:4312:: with SMTP id h18mr40293249wrq.193.1618380790874; Tue, 13 Apr 2021 23:13:10 -0700 (PDT) Received: from Armstrongs-MacBook-Pro.local ([2a01:e0a:90c:e290:29e7:a4d9:c2b0:1adc]) by smtp.gmail.com with ESMTPSA id l13sm4324434wmj.3.2021.04.13.23.13.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 23:13:10 -0700 (PDT) Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Robert Foss Cc: Andrzej Hajda , Laurent Pinchart , paul@crapouillou.net, Jonas Karlman , Jernej Skrabec , dri-devel , linux-kernel , Phong LE References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> From: Neil Armstrong Message-ID: <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> Date: Wed, 14 Apr 2021 08:13:08 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Le 13/04/2021 à 22:21, Robert Foss a écrit : > Hey Neil & Phong, > > Thanks for submitting this series! > >> + >> +static const struct drm_bridge_funcs it66121_bridge_funcs = { >> + .attach = it66121_bridge_attach, >> + .enable = it66121_bridge_enable, >> + .disable = it66121_bridge_disable, >> + .mode_set = it66121_bridge_mode_set, >> + .mode_valid = it66121_bridge_mode_valid, >> + .detect = it66121_bridge_detect, >> + .get_edid = it66121_bridge_get_edid, >> + .atomic_get_output_bus_fmts = it66121_bridge_atomic_get_output_bus_fmts, >> + .atomic_get_input_bus_fmts = it66121_bridge_atomic_get_input_bus_fmts, >> +}; > > I would like to see an implementation of HPD, since it is supported by > the hardware[1] (and required by the documentation). IRQ status bit 0 > seems to be the responsible for notifying us about hot plug detection > events. It's implemented in the IRQ handler with the IT66121_INT_STATUS1_HPD_STATUS event. Neil > > [1] https://rockchip.fr/radxa/IT66121_Programming_Guide.v1.05.pdf > > > Rob. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB63C433B4 for ; Wed, 14 Apr 2021 06:13:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06FCB60FD8 for ; Wed, 14 Apr 2021 06:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06FCB60FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 409AD6E448; Wed, 14 Apr 2021 06:13:13 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F8586E448 for ; Wed, 14 Apr 2021 06:13:12 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id g9so2616878wrx.0 for ; Tue, 13 Apr 2021 23:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s/qsaNKElXIqYcGQ3D9DhLtEdzKDUnrwltbMdfbQlx0=; b=z5yWzlbbBA5oiAa5E9YPhUpCjJps/8D8DoXo7AUo//kcHKxstSr1W3PiGiDYTBfRc0 rpoaVDTVB6EWoyuen2alnsuMoBphaebFgJj4YipbWNxMv8KszEayslHsoKRaFOzXAe5L GHkVacYvI7DOQhkXxe2CvB0riGW0reg6A3T4sb/dmljJN+Hk7DBVhYMeMkP2rg0QiQcY 4xi9Vwu/T9ZWqYieGF962BtTz7wNnwm0G6axLl2KhYYhfnhRSpMmg4zl6fntOCNORNfB 3Zsti8DyeRAbksoa4aNJBMfeqR6X9lMz53VkTycJg5ifitXmVeYGb8dhNvKW/hku4CpX xocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s/qsaNKElXIqYcGQ3D9DhLtEdzKDUnrwltbMdfbQlx0=; b=RhYnR8aB+aDTOl0gXNsDrX9ftZykyTdPFLvv/RoGSE2x4Zc7GA4LiVMvH97cSwXKqf o2FPRCCIc4w8JnSeGW2m63XtvhI3VSFhQ9balfcbuOE2C0GqtqYvysOOifnFFeybclyX BNd9ziOEHIk05Qx1r8zFL5wn6mSV6IOhxH/afGcgOUK4M0sjK5zBE/YvfW1xitZqgP7y kfurAQqyAiiGC8oEAn5RytBnUomh0TYBHZH0nxfUG/kbvdz1agm/rNAu9eYKCAhDyg7o jVaHyEMBSxlBqtFd7C6FPp5grQcZAJejE7XItMRQ9z7tNivKC102pDUQnxDwZcs7tZiN fRIQ== X-Gm-Message-State: AOAM530DSlubaxYeiUEs5x3AZWpVIzJbKP1nel54ieAFEiYJ1EIlS/bH ptssYiTGqghG2OIUPuTqNEaEPg== X-Google-Smtp-Source: ABdhPJwtomDmRAYyV/PE1J2o23D5cj/StMzlkJ7UI2FhKySrxYRdf2Mp0Id9tFDETM2GCVkQPT+JuQ== X-Received: by 2002:a5d:4312:: with SMTP id h18mr40293249wrq.193.1618380790874; Tue, 13 Apr 2021 23:13:10 -0700 (PDT) Received: from Armstrongs-MacBook-Pro.local ([2a01:e0a:90c:e290:29e7:a4d9:c2b0:1adc]) by smtp.gmail.com with ESMTPSA id l13sm4324434wmj.3.2021.04.13.23.13.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 23:13:10 -0700 (PDT) Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Robert Foss References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> From: Neil Armstrong Message-ID: <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> Date: Wed, 14 Apr 2021 08:13:08 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: fr X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Phong LE , Jernej Skrabec , Jonas Karlman , linux-kernel , dri-devel , paul@crapouillou.net, Andrzej Hajda , Laurent Pinchart Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgUm9iLAoKTGUgMTMvMDQvMjAyMSDDoCAyMjoyMSwgUm9iZXJ0IEZvc3MgYSDDqWNyaXTCoDoK PiBIZXkgTmVpbCAmIFBob25nLAo+IAo+IFRoYW5rcyBmb3Igc3VibWl0dGluZyB0aGlzIHNlcmll cyEKPiAKPj4gKwo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fYnJpZGdlX2Z1bmNzIGl0NjYx MjFfYnJpZGdlX2Z1bmNzID0gewo+PiArICAgICAgIC5hdHRhY2ggPSBpdDY2MTIxX2JyaWRnZV9h dHRhY2gsCj4+ICsgICAgICAgLmVuYWJsZSA9IGl0NjYxMjFfYnJpZGdlX2VuYWJsZSwKPj4gKyAg ICAgICAuZGlzYWJsZSA9IGl0NjYxMjFfYnJpZGdlX2Rpc2FibGUsCj4+ICsgICAgICAgLm1vZGVf c2V0ID0gaXQ2NjEyMV9icmlkZ2VfbW9kZV9zZXQsCj4+ICsgICAgICAgLm1vZGVfdmFsaWQgPSBp dDY2MTIxX2JyaWRnZV9tb2RlX3ZhbGlkLAo+PiArICAgICAgIC5kZXRlY3QgPSBpdDY2MTIxX2Jy aWRnZV9kZXRlY3QsCj4+ICsgICAgICAgLmdldF9lZGlkID0gaXQ2NjEyMV9icmlkZ2VfZ2V0X2Vk aWQsCj4+ICsgICAgICAgLmF0b21pY19nZXRfb3V0cHV0X2J1c19mbXRzID0gaXQ2NjEyMV9icmlk Z2VfYXRvbWljX2dldF9vdXRwdXRfYnVzX2ZtdHMsCj4+ICsgICAgICAgLmF0b21pY19nZXRfaW5w dXRfYnVzX2ZtdHMgPSBpdDY2MTIxX2JyaWRnZV9hdG9taWNfZ2V0X2lucHV0X2J1c19mbXRzLAo+ PiArfTsKPiAKPiBJIHdvdWxkIGxpa2UgdG8gc2VlIGFuIGltcGxlbWVudGF0aW9uIG9mIEhQRCwg c2luY2UgaXQgaXMgc3VwcG9ydGVkIGJ5Cj4gdGhlIGhhcmR3YXJlWzFdIChhbmQgcmVxdWlyZWQg YnkgdGhlIGRvY3VtZW50YXRpb24pLiBJUlEgc3RhdHVzIGJpdCAwCj4gc2VlbXMgdG8gYmUgdGhl IHJlc3BvbnNpYmxlIGZvciBub3RpZnlpbmcgdXMgYWJvdXQgaG90IHBsdWcgZGV0ZWN0aW9uCj4g ZXZlbnRzLgoKSXQncyBpbXBsZW1lbnRlZCBpbiB0aGUgSVJRIGhhbmRsZXIgd2l0aCB0aGUgSVQ2 NjEyMV9JTlRfU1RBVFVTMV9IUERfU1RBVFVTIGV2ZW50LgoKTmVpbAoKPiAKPiBbMV0gaHR0cHM6 Ly9yb2NrY2hpcC5mci9yYWR4YS9JVDY2MTIxX1Byb2dyYW1taW5nX0d1aWRlLnYxLjA1LnBkZgo+ IAo+IAo+IFJvYi4KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==