From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965128AbcBCV1S (ORCPT ); Wed, 3 Feb 2016 16:27:18 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:61733 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755540AbcBCV1O (ORCPT ); Wed, 3 Feb 2016 16:27:14 -0500 From: Arnd Bergmann To: Deepa Dinamani Cc: "Yan, Zheng" , linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, Dave Chinner , "Theodore Ts'o" , linux-kernel@vger.kernel.org, "Yan, Zheng" , Sage Weil , Ilya Dryomov , ceph-devel Subject: Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Date: Wed, 03 Feb 2016 22:27:02 +0100 Message-ID: <3267742.ulDeDOimis@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160203161720.GA9546@deepa-ubuntu> References: <1454479670-8204-1-git-send-email-deepa.kernel@gmail.com> <20160203161720.GA9546@deepa-ubuntu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:hX2X6N1zbaOzJqrQO+C3lM+RkTRm81/Ld/3hFd+tGUGgFuvH/LZ YoChbLoec1lJ01NsXC9HGdFqT2qJq0McUMyMeG5b6o9LdQqjL+V0cr+EIGAKwhHemIEp8OE TV2bEGAVVCzux5CZR2Yj/lIMc3lhUhND7weoXeJ8YMCOBEyi6VfX+zPNCgDcTKasN0igvXq h15BtH8HQ4qxf9CDh9I6g== X-UI-Out-Filterresults: notjunk:1;V01:K0:5JKhi+i0OS8=:8Xi/94eksYeSl7ALp3G4Gs e152AAaM6o+niW9QKeX/iqaZAV7YkHGFgDQ8FS1gYowcUt3CVDVmsscJfExHJgW6LXxrl75Ns 15V2rKS6wmv7ise9EEIqylY/a9TsTsQbnNk7QGa6lsE8aLoPak50kuyn6WEnPwuNWxnx9dvNH eiwpWu2f5UTi/97ntgirBkxv3EZy0X+1TWBqTprOLUttEZgnL2DPlDVhacMQmzr4Qv8XTJWYm 2f2xBvBkEQ/GhZWZ2hf7D/n8tCuDJmoLPVmyDCLTGh5aZVpbgT3RRADN58dAsyPtCwomTZO3d j5rx11cu3s9OdC9lPvAt8psNERZZ7otdk+KKfNoFzvi/rZOpjOjwUtjuHL/vyFnCD0dczy7wf uI/3g5J98wA0tXFyDnLFNhvdxX1JRjedv6hjd511O6Zu6or/KOBhD2Zxto9WJ0sFVLiLpoDH6 lDxjU27LojlBMJ5axg8i3iEKpzuYB0yHY1VdtdH1TWJcj82hGibQduy+imNqlnT9c+OakTm1V xA15hsV7NUIe1y8YdkpnXYpoXx/7rNyioJGY6lkT5JUul2X+2hjTM0E/0ZC5mARzMEQOND5rT YWrzDnUW3nClmJwzwnaEJxzaZl6p7BDqwQv9dVzsBi1ySGGVGNRPWgLxwo9lc3NfgjOdGBLjW /b3x0yOLuzX8r7ee1NAV9wgbCs35qlUeCSF4N4e5gmUUhX6Ph2Shum62xmOa46r3w/NAXBaMQ GoeYNLu8Iy1lDQmb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 February 2016 08:17:23 Deepa Dinamani wrote: > On Wed, Feb 03, 2016 at 10:34:00PM +0800, Yan, Zheng wrote: > > On Wed, Feb 3, 2016 at 2:07 PM, Deepa Dinamani wrote: > > > --- a/fs/ceph/mds_client.c > > > +++ b/fs/ceph/mds_client.c > > > @@ -1721,7 +1721,7 @@ ceph_mdsc_create_request(struct ceph_mds_client *mdsc, int op, int mode) > > > init_completion(&req->r_safe_completion); > > > INIT_LIST_HEAD(&req->r_unsafe_item); > > > > > > - req->r_stamp = CURRENT_TIME; > > > + ktime_get_real_ts(&req->r_stamp); > > > > I think we should use current_fs_time() here. I have squash the change > > into another patch > > Ok. I missed this commit b8e69066d8afa8d2670dc697252ff0e5907aafad > earlier which says that the r_stamp is used as ctime now. > I had assumed that this is a message timestamp. > > I was not able to find any documentation on what the server does > with the message sent by the client. Where can I find that? > > So, this should actually look like > > req->r_stamp = current_fs_time(mdsc->fsc->sb); > > Let me know if you want me to resend. I see that the timestamp is sent using ceph_encode_copy(&p, &req->r_stamp, sizeof(req->r_stamp)); What happens with the timestamp across reboots if we change the type? I assume the data will not be used across reboots, if it does, we already have a problem on machines that can boot both big-endian and little-endian kernels, or that can boot both 32-bit and 64-bit kernels. Arnd