All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Artem Savkov <asavkov@redhat.com>
Cc: dhowells@redhat.com, Kirill Marinushkin <k.marinushkin@gmail.com>,
	paul.gortmaker@windriver.com, james.l.morris@oracle.com,
	keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
Date: Mon, 24 Oct 2016 15:50:54 +0100	[thread overview]
Message-ID: <32688.1477320654@warthog.procyon.org.uk> (raw)
In-Reply-To: <20161006080021.GD19785@shodan.usersys.redhat.com>

Artem Savkov <asavkov@redhat.com> wrote:

> > > IMO, the preferable fix depends on your future plan.
> > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the
> > > patch suggested by Artem Savkov.
> > > If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I
> > > suggest my patch.
> > 
> > No such plans, TBH.
> 
> I agre with Kirill here, so if we are not trying to reduce ANSI X9.31
> DRNG usage can we move on with the suggested patch, or are there any
> issues with it that need addressing?

Which suggested patch?  One of Kirill's (there are at least two) or yours?

Note that we *also* need the "KEYS: Sort out big_key initialisation" patch -
just changing the Kconfig is not sufficient a fix in and of itself.

David

  parent reply	other threads:[~2016-10-24 14:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 12:37 [PATCH] security/keys: make BIG_KEYS dependent on stdrng Artem Savkov
2016-09-06 12:58 ` David Howells
2016-09-06 13:06   ` Artem Savkov
2016-09-06 13:11   ` David Howells
2016-09-06 13:16     ` Stephan Mueller
2016-09-06 13:25     ` Artem Savkov
2016-09-06 16:32     ` Kirill Marinushkin
2016-09-06 18:16     ` David Howells
2016-10-06  8:00       ` Artem Savkov
2016-10-24 14:50       ` David Howells [this message]
2016-10-25 10:26         ` Artem Savkov
2016-10-25 11:37         ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32688.1477320654@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=asavkov@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=k.marinushkin@gmail.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.