From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 3/3] syscalls/pipe2_03: Add new test for pipe2 O_DIRECT flag
Date: Thu, 23 Apr 2020 18:30:09 +0800 [thread overview]
Message-ID: <3268f153-6730-708f-ed93-19ca4cf85fdd@cn.fujitsu.com> (raw)
In-Reply-To: <CAEemH2cF-kziNEHuN1GayTtzwdxFFzsu0wRGB85yJ=LaKS-XBw@mail.gmail.com>
Hi LI
>
>
> On Thu, Apr 23, 2020 at 4:45 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com
> <mailto:xuyang2018.jy@cn.fujitsu.com>> wrote:
>
> ...
> > I got a failure on the ppc64le platform(page size: 65536kB).
> >
> > # ./pipe2_03
> > tst_test.c:1246: INFO: Timeout per run is 0h 05m 00s
> > pipe_size = 1048576
> > PIPE_BUF = 4096
> > packet_num = 256
> > safe_macros.c:457: BROK: pipe2_03.c:58:
> > write(4,0x1001d2b8,18446744073709551615) failed:
> EAGAIN/EWOULDBLOCK (11)
> I think we should remove PIPE_BUF and use page_size? because we use a
> page to store data not a fixed size buffer in kernel. as below(also,
> man-pages[1] is need to update):
>
>
> Emm, If PIPE_BUF doesn't work correctly, shouldn't this a kernel pipe
> bug? I think we need to take a close look at what happened there but not
> to replace by?using page_size directly.
> --
It is only defined in limit.h(I only think it is a error in limit.h) and
PIPE_BUF doesn't be used in kernel.
In kernel code, pipes use struct pipe_buffer to store buffer data and
other info,
struct pipe_buffer {
struct page *page; //alloc page to store data
unsigned int offset, len;
const struct pipe_buf_operations *ops;
unsigned int flags; //
unsigned long private;
};
as my pipe2_01.c said we only make buf with PIPE_BUF_FLAG_PACKET flag in
write end , and read will check this flag. This unit is a page instead
of this PIPE_BUF macro.
Best Regards
Yang Xu
> Regards,
> Li Wang
next prev parent reply other threads:[~2020-04-23 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 10:45 [LTP] [PATCH v4 1/3] syscalls/pipe2_01: convert into new API Yang Xu
2020-04-22 10:45 ` [LTP] [PATCH v4 2/3] syscalls/pipe2_02: Add new test for pipe2 O_CLOEXEC flag Yang Xu
2020-04-22 10:45 ` [LTP] [PATCH v4 3/3] syscalls/pipe2_03: Add new test for pipe2 O_DIRECT flag Yang Xu
2020-04-23 8:08 ` Li Wang
2020-04-23 8:45 ` Yang Xu
2020-04-23 10:04 ` Li Wang
2020-04-23 10:30 ` Yang Xu [this message]
2020-04-26 11:59 ` Li Wang
2020-04-26 17:45 ` Linus Torvalds
2020-04-26 17:45 ` Linus Torvalds
2020-04-30 3:23 ` Yang Xu
2020-04-30 3:23 ` Yang Xu
2020-04-30 6:57 ` Li Wang
2020-04-26 9:31 ` [LTP] [PATCH v4 1/3] syscalls/pipe2_01: convert into new API Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3268f153-6730-708f-ed93-19ca4cf85fdd@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.