From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Sat, 13 Jul 2019 23:13:20 +0200 Subject: [Buildroot] [PATCH v4 10/15] arch/arm: some cores have a different name with gcc-9 In-Reply-To: <20190620100725.105587-11-giulio.benetti@micronovasrl.com> References: <20190620100725.105587-1-giulio.benetti@micronovasrl.com> <20190620100725.105587-11-giulio.benetti@micronovasrl.com> Message-ID: <3271a2ff-fcd9-6169-a59e-6f29fca3c34f@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 20/06/2019 12:07, Giulio Benetti wrote: > From: "Yann E. MORIN" [snip] > The ordering of the 'default' clauses in kconfig is important, with the > first default which conditions is satisfied, to be used, so we just add > the new core names under a more liberal condition than the older names. This is not so readable / readily understandable, IMO. Therefore, I've changed this into: [snip] > + default "thunderx" if BR2_thunderx && !BR2_TOOLCHAIN_GCC_AT_LEAST_9 > + default "octeontx" if BR2_thunderx default "thunderx" if BR2_thunderx && !BR2_TOOLCHAIN_GCC_AT_LEAST_9 default "octeontx" if BR2_thunderx && BR2_TOOLCHAIN_GCC_AT_LEAST_9 etc. Regards, Arnout > + default "thunderxt81" if BR2_thunderxt81 && !BR2_TOOLCHAIN_GCC_AT_LEAST_9 > + default "octeontx81" if BR2_thunderxt81 > + default "thunderxt83" if BR2_thunderxt83 && !BR2_TOOLCHAIN_GCC_AT_LEAST_9 > + default "octeontx83" if BR2_thunderxt83 > default "thunderxt88" if BR2_thunderxt88 > default "thunderxt88p1" if BR2_thunderxt88p1 > default "xgene1" if BR2_xgene1 >