All of lore.kernel.org
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [virtio] Re: [virtio-dev] Re: [PATCH v3 1/6] notifications: unify notifications wording in core
Date: Mon, 25 Jun 2018 17:15:44 +0200	[thread overview]
Message-ID: <327ac53a-3a25-1aa0-c67b-d0930f9615a6@linux.ibm.com> (raw)
In-Reply-To: <20180625164512.720767c5.cohuck@redhat.com>



On 06/25/2018 04:45 PM, Cornelia Huck wrote:
> On Mon, 25 Jun 2018 14:21:27 +0200
> Halil Pasic <pasic@linux.ibm.com> wrote:
> 
>> Let us unify the wording when talking about notifications. This change
>> establishes the terms available buffer notification for what was usually

[..]

>>   Device reports the number of bytes it has written to memory for
>>   each buffer it uses. This is referred to as ``used length''.
> 
> Unrelated: Device and driver are missing the definite article in some
> places. Might be an idea for an additional patch :)
> 

Yes, there are definitively other things that could be improved. For example
the capitalization in listing:

\begin{itemize}
\item Device status field
\item Feature bits
\item Notifications
\item Device Configuration space

Capital C in *C*onfiguration is most likely wrong.

\item One or more virtqueues
\end{itemize}

Regarding bullet points and capitalization, if the bullet
point is not a sentence but a fragment there seems to be multiple
viable styles. But I'm afraid we aren't consequent across the spec.

Another question is capitalization of 'virtio terms' like Available Ring.
On some occasions we write 'Available Ring' on others 'available ring'.

It would be nice to have a polished document. But for now I will try
to target fragments where the semantics suffers too. (I had another
series that I already presented as RFC but decided to not push in
parallel with this one).


> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>

Thanks!

Regards,
Halil


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


  reply	other threads:[~2018-06-25 15:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 12:21 [virtio] [PATCH v3 0/6] rework notifications terminology Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 1/6] notifications: unify notifications wording in core Halil Pasic
2018-06-25 14:45   ` [virtio] " Cornelia Huck
2018-06-25 15:15     ` Halil Pasic [this message]
2018-06-25 12:21 ` [virtio] [PATCH v3 2/6] notifications: notifications as basic virtio facility Halil Pasic
2018-06-25 14:37   ` [virtio] " Cornelia Huck
2018-06-25 12:21 ` [virtio] [PATCH v3 3/6] ccw: map common notifications terminology to ccw Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 4/6] pci: map common notifications terminology to PCI Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 5/6] mmio: map common notifications terminology to MMIO Halil Pasic
2018-06-25 14:34   ` [virtio] " Cornelia Huck
2018-06-25 12:21 ` [virtio] [PATCH v3 6/6] notifications: update notifications terminology for devices Halil Pasic
2018-07-02 15:51 ` [virtio] Re: [PATCH v3 0/6] rework notifications terminology Stefan Hajnoczi
2018-07-03  0:01 ` [virtio] Re: [virtio-dev] " Michael S. Tsirkin
2018-07-03  7:45   ` Cornelia Huck
2018-07-03  9:00   ` Halil Pasic
2018-07-03 12:07     ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-07-17 16:47       ` Halil Pasic
2018-07-27 11:33         ` Halil Pasic
2018-07-27 11:45           ` Michael S. Tsirkin
2018-08-01 13:04             ` Halil Pasic
2018-08-01 22:30               ` Michael S. Tsirkin
2018-08-02 17:12                 ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=327ac53a-3a25-1aa0-c67b-d0930f9615a6@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.