From: Chanwoo Choi <cwchoi00@gmail.com>
To: "Arnd Bergmann" <arnd@kernel.org>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: usbc-tusb320: add USB_ROLE_SWITCH dependency
Date: Thu, 23 Mar 2023 23:19:00 +0900 [thread overview]
Message-ID: <328208b5-f276-0099-e476-8fa721178916@gmail.com> (raw)
In-Reply-To: <20230322111708.1042312-1-arnd@kernel.org>
On 23. 3. 22. 20:16, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_USB_ROLE_SWITCH=m, tusb320 cannot be built-in:
>
> ld.lld: error: undefined symbol: fwnode_usb_role_switch_get
>>>> referenced by extcon-usbc-tusb320.c
>>>> drivers/extcon/extcon-usbc-tusb320.o:(tusb320_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: usb_role_switch_set_role
>>>> referenced by extcon-usbc-tusb320.c
>>>> drivers/extcon/extcon-usbc-tusb320.o:(tusb320_state_update_handler) in archive vmlinux.a
>
> Add the appropriate Kconfig dependency to prevent this
> configuration but still allow the driver to be built-in
> when USB_ROLE_SWITCH is disabled.
>
> Fixes: 19685ae43489 ("extcon: usbc-tusb320: add usb_role_switch support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 290186e44e6b..0ef1971d22bb 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -185,6 +185,7 @@ config EXTCON_USBC_TUSB320
> tristate "TI TUSB320 USB-C extcon support"
> depends on I2C && TYPEC
> select REGMAP_I2C
> + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB Type C cable detection extcon
> support using a TUSB320.
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2023-03-23 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:16 [PATCH] extcon: usbc-tusb320: add USB_ROLE_SWITCH dependency Arnd Bergmann
2023-03-22 13:05 ` Alvin Šipraga
2023-03-23 14:19 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=328208b5-f276-0099-e476-8fa721178916@gmail.com \
--to=cwchoi00@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.