All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinghao.liu@zju.edu.cn
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	kjlu@umn.edu, "David S. Miller" <davem@davemloft.net>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe
Date: Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00)	[thread overview]
Message-ID: <328f073a.222d7.176d7572f29.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20201230133618.7c242856@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

> On Mon, 28 Dec 2020 16:14:17 -0500 Konstantin Ryabitsev wrote:
> > On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote:
> > > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote:  
> > > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote:  
> > > >>>> Konstantin, would you be willing to mod the kernel.org instance of
> > > >>>> patchwork to populate Fixes tags in the generated mboxes?  
> > > >>>
> > > >>> I'd really rather not -- we try not to diverge from project upstream if at all
> > > >>> possible, as this dramatically complicates upgrades.  
> > > >>
> > > >> Well that is really unfortunate then because the Linux developer
> > > >> community settled on using the Fixes: tag for years now and having
> > > >> patchwork automatically append those tags would greatly help maintainers.  
> > > > 
> > > > I agree -- but this is something that needs to be implemented upstream.
> > > > Picking up a one-off patch just for patchwork.kernel.org is not the right way
> > > > to go about this.  
> > > 
> > > You should be able to tune this from the patchwork administrative
> > > interface and add new tags there, would not that be acceptable?  
> > 
> > Oh, oops, I got confused by the mention of a rejected upstream patch -- I
> > didn't realize that this is already possible with a configuration setting.
> > 
> > Sure, I added a match for ^Fixes: -- let me know if it's not doing the right
> > thing.
> 
> I used this one for a test:
> 
> https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com/
> 
> I'm not getting the Fixes tag when I download the mbox.

It seems that automatically generating Fixes tags is a hard work.
Both patches and bugs could be complex. Sometimes even human cannot
determine which commit introduced a target bug.

Is this an already implemented functionality?

Regards,
Dinghao 

  reply	other threads:[~2021-01-06 10:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 11:06 [PATCH] net: ethernet: Fix memleak in ethoc_probe Dinghao Liu
2020-12-23 15:33 ` Andrew Lunn
2020-12-23 20:32   ` Jakub Kicinski
2020-12-23 21:00     ` Andrew Lunn
2020-12-23 21:11       ` Jakub Kicinski
2020-12-23 22:17         ` Florian Fainelli
2020-12-24  1:41           ` Jakub Kicinski
2020-12-24 18:06             ` Konstantin Ryabitsev
2020-12-24 21:57               ` Florian Fainelli
2020-12-28 20:23                 ` Konstantin Ryabitsev
2020-12-28 21:05                   ` Florian Fainelli
2020-12-28 21:14                     ` Konstantin Ryabitsev
2020-12-30 21:36                       ` Jakub Kicinski
2021-01-06 10:56                         ` dinghao.liu [this message]
2021-01-06 16:44                           ` Jakub Kicinski
2021-01-07  7:54                             ` dinghao.liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=328f073a.222d7.176d7572f29.Coremail.dinghao.liu@zju.edu.cn \
    --to=dinghao.liu@zju.edu.cn \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kjlu@umn.edu \
    --cc=konstantin@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.