All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: david@redhat.com, linux-s390@vger.kernel.org,
	seiden@linux.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 7/9] s390x: Makefile: Remove snippet flatlib linking
Date: Mon, 27 Sep 2021 19:47:00 +0200	[thread overview]
Message-ID: <329948a8-b4ea-1c4a-5392-3fd6aa8540f6@redhat.com> (raw)
In-Reply-To: <20210922071811.1913-8-frankja@linux.ibm.com>

On 22/09/2021 09.18, Janosch Frank wrote:
> We can't link the flatlib as we do not export everything that it needs
> and we don't (want to) call the init functions.
> 
> In the future we might implement a tiny lib that uses select lib

s/select/selected/ ?

> object files and re-implements functions like assert() and
> test_facility() to be able to use some parts of the lib.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>   s390x/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/Makefile b/s390x/Makefile
> index 5d1a33a0..d09c0a17 100644
> --- a/s390x/Makefile
> +++ b/s390x/Makefile
> @@ -92,7 +92,7 @@ $(SNIPPET_DIR)/asm/%.gbin: $(SNIPPET_DIR)/asm/%.o $(FLATLIBS)
>   	$(OBJCOPY) -I binary -O elf64-s390 -B "s390:64-bit" $@ $@
>   
>   $(SNIPPET_DIR)/c/%.gbin: $(SNIPPET_DIR)/c/%.o $(snippet_asmlib) $(FLATLIBS)
> -	$(CC) $(LDFLAGS) -o $@ -T $(SRCDIR)/s390x/snippets/c/flat.lds $(patsubst %.gbin,%.o,$@) $(snippet_asmlib) $(FLATLIBS)
> +	$(CC) $(LDFLAGS) -o $@ -T $(SRCDIR)/s390x/snippets/c/flat.lds $(patsubst %.gbin,%.o,$@) $(snippet_asmlib)

Don't we need memcpy() and friends in some cases? ... well, likely not, 
otherwise linking would fail... So:

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2021-09-27 17:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  7:18 [kvm-unit-tests PATCH 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 1/9] s390x: uv: Tolerate 0x100 query return code Janosch Frank
2021-09-22  9:12   ` Claudio Imbrenda
2021-09-22 11:36     ` Janosch Frank
2021-09-27 15:19       ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 2/9] s390x: pfmf: Fix 1MB handling Janosch Frank
2021-09-22  9:16   ` Claudio Imbrenda
2021-09-27 15:23   ` Thomas Huth
2021-09-28  9:50     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 3/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-09-22  9:18   ` Claudio Imbrenda
2021-09-27 15:26   ` Thomas Huth
2021-09-28 11:21     ` Janosch Frank
2021-09-28 16:28       ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 4/9] lib: s390x: uv: Fix share return value and print Janosch Frank
2021-09-22  9:19   ` Claudio Imbrenda
2021-09-27 17:38   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 5/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-09-22  9:23   ` Claudio Imbrenda
2021-09-22 11:37     ` Janosch Frank
2021-09-27 17:41   ` Thomas Huth
2021-09-28 10:00     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-09-22  9:24   ` Claudio Imbrenda
2021-09-27 17:43   ` Thomas Huth
2021-09-22  7:18 ` [kvm-unit-tests PATCH 7/9] s390x: Makefile: Remove snippet flatlib linking Janosch Frank
2021-09-27 17:47   ` Thomas Huth [this message]
2021-09-28  9:57     ` Janosch Frank
2021-09-22  7:18 ` [kvm-unit-tests PATCH 8/9] s390x: Add sthyi cc==0 r2+1 verification Janosch Frank
2021-09-22  9:31   ` Claudio Imbrenda
2021-09-22  7:18 ` [kvm-unit-tests PATCH 9/9] s390x: skrf: Fix tprot assembly Janosch Frank
2021-09-22  9:34   ` Claudio Imbrenda
2021-09-22 11:47     ` Janosch Frank
     [not found]   ` <20210922134112.174842-1-scgl@linux.ibm.com>
2021-09-22 13:53     ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=329948a8-b4ea-1c4a-5392-3fd6aa8540f6@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=seiden@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.