From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FF2C5519F for ; Wed, 25 Nov 2020 09:06:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08ADD206B5 for ; Wed, 25 Nov 2020 09:06:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kpPifnF6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726158AbgKYJGW (ORCPT ); Wed, 25 Nov 2020 04:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgKYJGV (ORCPT ); Wed, 25 Nov 2020 04:06:21 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C023C0613D6 for ; Wed, 25 Nov 2020 01:06:21 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id k1so1686681eds.13 for ; Wed, 25 Nov 2020 01:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v4gNQmDRHbR01jUPm5SYwLaqDhJEPbPGmwjuf8wFdX8=; b=kpPifnF6YK8KEwZbf7ulYTIOe65yvPOgYzVylt2M23h/mjcCibmfUmC+bERkFtDYzY pqVdfd/+KgOI6WZAKoNHZxwoY2pH1CG+Ll10ZeBNVTyoP8DFx1MeT5yyk0MJnatBa3mP f+GImqlX72fKrEJ1V6LDZ4w37gGa+v5Znwi0wkWkG6u/6ZMNLDh1EwaJhcj11jPPvAfX vZsDgoUtw5Jw6L+0xvD8Jf7OGmSlAABpifFIqNYR1PJRccXqK4wm3fhHdk5uygvyYVIo 7NLyU2fiH970XHNHJPaSKOLk1XZHjDUt+oNDMamoiVJdelAWHdaYH2QcHyCdLqCTjfP2 ZUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v4gNQmDRHbR01jUPm5SYwLaqDhJEPbPGmwjuf8wFdX8=; b=nDJ7hpzhLIVNvaqc4XePJe0QdJLC2bI/juNPokazTT7xw9fmoBl4dGVp7qs3/Y1HCW SRx35vTAmiLwOA0D0Ya0viWEltPL7FVTDLEIgB2li2M6M3aBoAylh2g9Ib/1wwnRjnqW JCfASWFELNc+B80ejFwKyp/DtQFWcH/hCeRGLwkYO5jFiocrkq1mXewx1f04EVljgP1N 7qzTZVWBnVCQyxZJ5c4pkMDVCcvR2cRsLbUyZG9Xfj6wen3bhBDaA/4DJi20xdbiqvPO pVVFRjoHPwusYUUEVMyc9ah1es3M9DQtFkbnI1he95Icwp/UB33dJyOXqePyG9h3oKJ+ AnVA== X-Gm-Message-State: AOAM533Zw/tGMlL8iqGGZ84AG6UYJPgMbiu5X20yskVCn8vJcFOv72Y3 0MPJDATpLsxGZFes4UqrqrvzE5wkv2Y= X-Google-Smtp-Source: ABdhPJxwSAnZ+nf5yhBT04qrDGVstKwu9//EGa3SSFc8pBIRpUPMGJWkTirjVj+PBN1ktrKrXKRRUQ== X-Received: by 2002:a50:c04c:: with SMTP id u12mr1241414edd.188.1606295179876; Wed, 25 Nov 2020 01:06:19 -0800 (PST) Received: from [192.168.0.110] ([77.127.85.120]) by smtp.gmail.com with ESMTPSA id d23sm819443edp.36.2020.11.25.01.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Nov 2020 01:06:19 -0800 (PST) Subject: Re: [PATCH net] netdevice.h: Fix unintentional disable of ALL_FOR_ALL features on upper device To: Herbert Xu , Eric Dumazet Cc: Tariq Toukan , "David S. Miller" , Jakub Kicinski , netdev , Moshe Shemesh , Maxim Mikityanskiy , Saeed Mahameed References: <20201123141256.14208-1-tariqt@nvidia.com> <9bf8ba40-cd40-2af6-d358-48dd98526434@gmail.com> <20201125032549.GA13059@gondor.apana.org.au> From: Tariq Toukan Message-ID: <329952c5-b208-1781-5604-2b408796ec90@gmail.com> Date: Wed, 25 Nov 2020 11:06:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201125032549.GA13059@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/25/2020 5:25 AM, Herbert Xu wrote: > On Tue, Nov 24, 2020 at 11:48:35AM +0100, Eric Dumazet wrote: >> >> Well, the 'increment' part was suggesting the function was adding >> flags, not removing them. > > The idea of the increment part is that we're adding a constituent > device, not that we're adding features. There have always been > features which were conjunctions, i.e., they must be supported by > all underlying devices for them to be enabled on the virtual device. > > Your use of the increment function is unusual, as you're not adding > features that belong to one underlying device, but rather you're > trying to enable a feature on the virtual device unconditionally. > >> We might ask Herbert Xu if we : >> >> 1) Need to comment the function, or change its name to be more descriptive. >> 2) Change the behavior (as you suggested) >> 3) Other choice. > > I think Tariq's patch is fine, although a comment should be added > to netdev_add_tso_features as this use of the increment function > is nonstandard. > Thanks Herbert, I'll add a comment and re-spin. > Thanks, >