From: Thomas Monjalon <thomas@monjalon.net>
To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"O'loingsigh, Mairtin" <mairtin.oloingsigh@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors
Date: Tue, 14 Apr 2020 11:06:52 +0200 [thread overview]
Message-ID: <3299752.PIDvDuAF1L@thomas> (raw)
In-Reply-To: <BL0PR11MB30906F2B4342C4D2AA82B1F584DA0@BL0PR11MB3090.namprd11.prod.outlook.com>
14/04/2020 10:49, De Lara Guarch, Pablo:
> From: Thomas Monjalon
> > 10/04/2020 17:03, Mairtin o Loingsigh:
> > > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > > target PMD
> >
> > There is really something wrong in the cryptodev API.
> > Why the PMD must be selected in the tests?
> > Isn't there some capabilities in cryptodev?
> > Whitelisting PMD in the test prevents testing capabilities API.
> >
> > It looks the required refactoring is not progressing enough.
> > I suggest blocking all crypto-related patches until is is fixed.
> >
>
> You are right, but Mairtin was following the same approach as it was taken previously.
I know. His patch was accepted.
> I agree that this approach is not the best one and we are currently working
> on a better solution.
Now that's clear, let's not merge any new crypto patch until
the capabilities are working and tested.
prev parent reply other threads:[~2020-04-14 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 14:04 [dpdk-dev] [PATCH v3] crypto/aesni_mb: support DOCSIS AES-256 Mairtin o Loingsigh
2020-04-10 15:03 ` [dpdk-dev] [PATCH v4 1/2] " Mairtin o Loingsigh
2020-04-14 8:45 ` De Lara Guarch, Pablo
2020-04-15 9:04 ` [dpdk-dev] [PATCH v5] " Mairtin o Loingsigh
2020-04-15 11:07 ` De Lara Guarch, Pablo
2020-04-15 11:51 ` [dpdk-dev] [PATCH v6] " Mairtin o Loingsigh
2020-04-17 16:31 ` Akhil Goyal
2020-04-17 20:59 ` Akhil Goyal
2020-04-10 15:03 ` [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors Mairtin o Loingsigh
2020-04-12 16:43 ` Thomas Monjalon
2020-04-14 8:49 ` De Lara Guarch, Pablo
2020-04-14 9:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3299752.PIDvDuAF1L@thomas \
--to=thomas@monjalon.net \
--cc=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mairtin.oloingsigh@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.