From: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
"John, Jubin" <jubin.john@intel.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: RE: [PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue
Date: Fri, 20 Nov 2015 16:01:18 +0000 [thread overview]
Message-ID: <32E1700B9017364D9B60AED9960492BC259BD8A2@fmsmsx120.amr.corp.intel.com> (raw)
In-Reply-To: <20151120011135.GH11695@kroah.com>
> That sounds like a horrid hack, and this implies that a slower machine will
> still have this problem...
Greg,
I'm NAK'ing this patch for two reasons:
1. Code underneath the CONFIG option is only used during rework
2. It is a hack as you have noted
We are going to take this up internally to get to the root cause.
Go ahead and drop or whatever you do.
Mike
next prev parent reply other threads:[~2015-11-20 16:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 3:36 [PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names Jubin John
2015-11-14 3:37 ` [PATCH 02/18] staging/rdma/hfi1: Decode CNP opcode Jubin John
[not found] ` <1447472236-622-2-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:09 ` Greg KH
2015-11-20 14:37 ` Marciniszyn, Mike
2015-11-14 3:37 ` [PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode Jubin John
[not found] ` <1447472236-622-3-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:09 ` Greg KH
[not found] ` <20151120010940.GC11695-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-20 21:43 ` Marciniszyn, Mike
2015-11-14 3:37 ` [PATCH 04/18] staging/rdma/hfi1: Fix qp.h comments Jubin John
2015-11-14 3:37 ` [PATCH 05/18] staging/rdma/hfi1: Clean up comments Jubin John
[not found] ` <1447472236-622-5-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:10 ` Greg KH
[not found] ` <20151120011000.GD11695-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-20 14:46 ` Marciniszyn, Mike
2015-11-14 3:37 ` [PATCH 06/18] staging/rdma/hfi: Add one-time LCB reset Jubin John
2015-11-20 1:10 ` Greg KH
2015-11-14 3:37 ` [PATCH 07/18] staging/rdma/hfi1: Extend quiet timeout Jubin John
[not found] ` <1447472236-622-7-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:10 ` Greg KH
[not found] ` <20151120011052.GG11695-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-20 15:21 ` Marciniszyn, Mike
[not found] ` <32E1700B9017364D9B60AED9960492BC259BD7AF-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-20 22:04 ` Dan Carpenter
2015-11-14 3:37 ` [PATCH 08/18] staging/rdma/hfi1: Add a credit push on diagpkt allocate fail Jubin John
2015-11-14 3:37 ` [PATCH 09/18] staging/rdma/hfi1: Correctly limit VLs against SDMA engines Jubin John
[not found] ` <1447472236-622-9-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:10 ` Greg KH
[not found] ` <20151120011017.GE11695-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-20 14:59 ` Marciniszyn, Mike
2015-11-14 3:37 ` [PATCH 10/18] staging/rdma/hfi1: Adds software counters for bitfields within various error status fields Jubin John
2015-11-14 3:37 ` [PATCH 11/18] staging/rdma/hfi1: Destroy workqueues if hfi1_register_ib_device() call returns error Jubin John
2015-11-14 3:37 ` [PATCH 12/18] staging/rdma/hfi1: Unexpected link up pkey values are not an error Jubin John
2015-11-14 3:37 ` [PATCH 13/18] staging/rdma/hfi1: remove SPC freeze error messages Jubin John
2015-11-14 3:37 ` [PATCH 14/18] staging/rdma/hfi1: unknown frame messages are not errors Jubin John
2015-11-14 3:37 ` [PATCH 15/18] staging/rdma/hfi1: Consider VL15 MTU also when calculating the maximum VL MTU Jubin John
2015-11-14 3:37 ` [PATCH 16/18] staging/rdma/hfi1: Fix Xmit Wait calculation Jubin John
2015-11-14 3:37 ` [PATCH 17/18] staging/rdma/hfi1: Adding counter resolutions for DataPortCounters Jubin John
2015-11-14 3:37 ` [PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue Jubin John
[not found] ` <1447472236-622-18-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:11 ` Greg KH
2015-11-20 16:01 ` Marciniszyn, Mike [this message]
[not found] ` <32E1700B9017364D9B60AED9960492BC259BD8A2-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-20 17:57 ` Greg KH
[not found] ` <1447472236-622-1-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 1:08 ` [PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32E1700B9017364D9B60AED9960492BC259BD8A2@fmsmsx120.amr.corp.intel.com \
--to=mike.marciniszyn@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jubin.john@intel.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.