From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Marciniszyn, Mike" Subject: RE: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Date: Mon, 14 Dec 2015 15:28:46 +0000 Message-ID: <32E1700B9017364D9B60AED9960492BC259CD82D@fmsmsx120.amr.corp.intel.com> References: <1450104189-2653-1-git-send-email-hofrat@osadl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1450104189-2653-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicholas Mc Guire Cc: Doug Ledford , "Hefty, Sean" , Hal Rosenstock , Greg Kroah-Hartman , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org > --- a/drivers/staging/rdma/hfi1/chip.c > +++ b/drivers/staging/rdma/hfi1/chip.c > @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd, > u32 first_ctxt) > goto bail; > if (num_vls * qpns_per_vl > dd->chip_rcv_contexts) > goto bail; > - rsmmap = kmalloc_array(NUM_MAP_REGS, sizeof(u64), > GFP_KERNEL); > - memset(rsmmap, rxcontext, NUM_MAP_REGS * sizeof(u64)); > + rsmmap = kcalloc(NUM_MAP_REGS, sizeof(u64), GFP_KERNEL); > /* init the local copy of the table */ > for (i = 0, ctxt = first_ctxt; i < num_vls; i++) { > unsigned tctxt; > -- I'm NAKing this. There is a chip specific difference that accounts for the current code. Mike -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbbLNP25 (ORCPT ); Mon, 14 Dec 2015 10:28:57 -0500 Received: from mga14.intel.com ([192.55.52.115]:12386 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbbLNP24 convert rfc822-to-8bit (ORCPT ); Mon, 14 Dec 2015 10:28:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,427,1444719600"; d="scan'208";a="707073994" From: "Marciniszyn, Mike" To: Nicholas Mc Guire CC: Doug Ledford , "Hefty, Sean" , Hal Rosenstock , Greg Kroah-Hartman , "linux-rdma@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Thread-Topic: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Thread-Index: AQHRNn8NTvwjWj0+nkeZkHviK16FTJ7Kmwyw Date: Mon, 14 Dec 2015 15:28:46 +0000 Message-ID: <32E1700B9017364D9B60AED9960492BC259CD82D@fmsmsx120.amr.corp.intel.com> References: <1450104189-2653-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1450104189-2653-1-git-send-email-hofrat@osadl.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI2ZjIxN2JhOC0zNGE0LTQyMWQtOGMxZi0zNmE1OWNhYmRjNTMiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJ0NUMwVTdLMVNhcWpVRVpHRlhoc0k0ajJQbGRjMmQ0SDNOTnQ0ZzNxZkJZPSJ9 x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > --- a/drivers/staging/rdma/hfi1/chip.c > +++ b/drivers/staging/rdma/hfi1/chip.c > @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd, > u32 first_ctxt) > goto bail; > if (num_vls * qpns_per_vl > dd->chip_rcv_contexts) > goto bail; > - rsmmap = kmalloc_array(NUM_MAP_REGS, sizeof(u64), > GFP_KERNEL); > - memset(rsmmap, rxcontext, NUM_MAP_REGS * sizeof(u64)); > + rsmmap = kcalloc(NUM_MAP_REGS, sizeof(u64), GFP_KERNEL); > /* init the local copy of the table */ > for (i = 0, ctxt = first_ctxt; i < num_vls; i++) { > unsigned tctxt; > -- I'm NAKing this. There is a chip specific difference that accounts for the current code. Mike