All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marciniszyn, Mike" <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Thomas Rosenstein
	<thomas.rosenstein-+32LHaKS/h5VtLMLtJdGzA@public.gmane.org>
Subject: RE: [PATCH] IB/iser: Handle lack of memory management extentions correctly
Date: Wed, 28 Jun 2017 17:46:49 +0000	[thread overview]
Message-ID: <32E1700B9017364D9B60AED9960492BC34327953@fmsmsx120.amr.corp.intel.com> (raw)
In-Reply-To: <55a85363-da66-f6d6-f5cc-08b20f148f36-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

> Hi Mike, for the patch itself, it addresses a bug so,
> 
> Acked-by: Sagi Grimberg <sagi@grimberg.me>
> 
> But,
> 
> As for not having any max pages for FMR it's really annoying.
> 
> What do you think about exposing max_fast_reg_page_list_len to
> limit also for FMRs? We can also rename it to max_reg_page_list_len
> to get rid of the FRWR association.
> 
> Thoughts?

I have no issue with your proposal, but I would rather get this fixed and adjust the API with an additional fix.   I suspect we probably want to mark this fix stable.

I did audit the kernel ULPs for FMR vs. FRMR usage and the only one that looked at max_fast_reg_page_list_len unconditionally was iser.

Thomas, can you verify this patch and reply with a Tested-by:

Meanwhile, I will audit kernel providers for which ones besides qib do not support the extensions and FMR.

Mike

  parent reply	other threads:[~2017-06-28 17:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 19:01 [PATCH] IB/iser: Handle lack of memory management extentions correctly Mike Marciniszyn
     [not found] ` <20170622190110.27788.19910.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-06-27  9:35   ` Sagi Grimberg
     [not found]     ` <55a85363-da66-f6d6-f5cc-08b20f148f36-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 17:46       ` Marciniszyn, Mike [this message]
     [not found]         ` <32E1700B9017364D9B60AED9960492BC34327953-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-06-28 18:03           ` Thomas Rosenstein
     [not found]             ` <3AAAAD6A-8C14-4B33-AB7A-2AFB49239DFB-+32LHaKS/h5VtLMLtJdGzA@public.gmane.org>
2017-06-28 18:26               ` Marciniszyn, Mike
2017-06-29  5:41           ` Sagi Grimberg
2017-07-02 10:19           ` Sagi Grimberg
     [not found]             ` <a5bcb1b5-6f9a-f6bd-cd3a-bf750bc19869-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06  7:22               ` Sagi Grimberg
     [not found]                 ` <873c3816-990a-ab20-058d-2aa15c7318b4-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06 13:54                   ` Marciniszyn, Mike
2017-06-29 13:24   ` Thomas Rosenstein
2017-07-22 17:15   ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32E1700B9017364D9B60AED9960492BC34327953@fmsmsx120.amr.corp.intel.com \
    --to=mike.marciniszyn-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=thomas.rosenstein-+32LHaKS/h5VtLMLtJdGzA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.