From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAED3C63777 for ; Wed, 18 Nov 2020 14:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B8EC246F9 for ; Wed, 18 Nov 2020 14:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbgKROzV convert rfc822-to-8bit (ORCPT ); Wed, 18 Nov 2020 09:55:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgKROzU (ORCPT ); Wed, 18 Nov 2020 09:55:20 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBF99C0613D4 for ; Wed, 18 Nov 2020 06:55:20 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfOrZ-0002K7-DQ; Wed, 18 Nov 2020 15:55:13 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kfOrY-0003vm-BW; Wed, 18 Nov 2020 15:55:12 +0100 Message-ID: <32aaa90cabfb68952803ca91933bc0e105e34a53.camel@pengutronix.de> Subject: Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests From: Philipp Zabel To: Krzysztof Kozlowski , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 18 Nov 2020 15:55:12 +0100 In-Reply-To: <20201117182419.73853-1-krzk@kernel.org> References: <20201117182419.73853-1-krzk@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote: > The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable': > imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent' > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Put depends in DRM_IMX_LDB option only. > --- > drivers/gpu/drm/imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig > index 6231048aa5aa..73fe2bc5633c 100644 > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -28,6 +28,7 @@ config DRM_IMX_TVE > config DRM_IMX_LDB > tristate "Support for LVDS displays" > depends on DRM_IMX && MFD_SYSCON > + depends on COMMON_CLK > select DRM_PANEL > help > Choose this to enable the internal LVDS Display Bridge (LDB) Thank you, applied to imx-drm/next. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BB9C5519F for ; Wed, 18 Nov 2020 14:56:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C61EE246F9 for ; Wed, 18 Nov 2020 14:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xd93w5ke" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C61EE246F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3ZfSiivFmD7H/HIuyO2oUzYE8B2zCap2cvawpcV4geE=; b=Xd93w5keziF0+F+lz9IwdMZGec TmVxmBqPnhKZ4GAyM0JyYuo53Z+vIBeFKTjBvDZCfjZh38YowSYnSabEOGERFIdgj30hm893HACdT wbisqjYUwr6rUzTxIgkp2wHME1B8BylmKb67q63Dsx9WZq7eMWcHQnH5Gp9OBYHTPHuW3RT59iaGf u3g3Fii6TNisRoZhI6sgTNWgfgWRFHDypkJyuvgYiQ9dsENFm0+W9VqIN/uH1Mf/DNeFmv68rHKwu D3ECovIerdHaqwCHMgEUmmUKAyyEBDRh4awvjVxR1ANrbcPkElZn+spyz30QxLaoccWMNkXJPnTVu P8q52b8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfOrl-0007oE-Eo; Wed, 18 Nov 2020 14:55:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfOri-0007nM-S6 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 14:55:23 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfOrZ-0002K7-DQ; Wed, 18 Nov 2020 15:55:13 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kfOrY-0003vm-BW; Wed, 18 Nov 2020 15:55:12 +0100 Message-ID: <32aaa90cabfb68952803ca91933bc0e105e34a53.camel@pengutronix.de> Subject: Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests From: Philipp Zabel To: Krzysztof Kozlowski , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 18 Nov 2020 15:55:12 +0100 In-Reply-To: <20201117182419.73853-1-krzk@kernel.org> References: <20201117182419.73853-1-krzk@kernel.org> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_095522_929979_1D3684EF X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote: > The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable': > imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent' > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Put depends in DRM_IMX_LDB option only. > --- > drivers/gpu/drm/imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig > index 6231048aa5aa..73fe2bc5633c 100644 > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -28,6 +28,7 @@ config DRM_IMX_TVE > config DRM_IMX_LDB > tristate "Support for LVDS displays" > depends on DRM_IMX && MFD_SYSCON > + depends on COMMON_CLK > select DRM_PANEL > help > Choose this to enable the internal LVDS Display Bridge (LDB) Thank you, applied to imx-drm/next. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720C2C5519F for ; Wed, 18 Nov 2020 14:55:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 676C92470D for ; Wed, 18 Nov 2020 14:55:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 676C92470D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BE9C6E3D6; Wed, 18 Nov 2020 14:55:20 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72D476E3D6 for ; Wed, 18 Nov 2020 14:55:19 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfOrZ-0002K7-DQ; Wed, 18 Nov 2020 15:55:13 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kfOrY-0003vm-BW; Wed, 18 Nov 2020 15:55:12 +0100 Message-ID: <32aaa90cabfb68952803ca91933bc0e105e34a53.camel@pengutronix.de> Subject: Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests From: Philipp Zabel To: Krzysztof Kozlowski , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 18 Nov 2020 15:55:12 +0100 In-Reply-To: <20201117182419.73853-1-krzk@kernel.org> References: <20201117182419.73853-1-krzk@kernel.org> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Krzysztof, On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote: > The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable': > imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent' > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Put depends in DRM_IMX_LDB option only. > --- > drivers/gpu/drm/imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig > index 6231048aa5aa..73fe2bc5633c 100644 > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -28,6 +28,7 @@ config DRM_IMX_TVE > config DRM_IMX_LDB > tristate "Support for LVDS displays" > depends on DRM_IMX && MFD_SYSCON > + depends on COMMON_CLK > select DRM_PANEL > help > Choose this to enable the internal LVDS Display Bridge (LDB) Thank you, applied to imx-drm/next. regards Philipp _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel