All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/9] test: add test for lib/lmb.c
Date: Mon, 14 Jan 2019 20:19:34 +0100	[thread overview]
Message-ID: <32b0b4e3-c350-6085-a513-f4dd3ac3b46c@gmail.com> (raw)
In-Reply-To: <CAPnjgZ1dsikhBUmVksDd_5khONaFYQtaP=d4BAm0hutbPe80yw@mail.gmail.com>

Am 05.01.2019 um 02:56 schrieb Simon Glass:
> Hi Simon,
> 
> On Fri, 14 Dec 2018 at 13:14, Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>>
>> Add basic tests for the lmb memory allocation code used to reserve and
>> allocate memory during boot.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> ---
>>
>> Changes in v6: None
>> Changes in v5:
>> - this patch is new in v5
>>
>> Changes in v4: None
>> Changes in v2: None
>>
>>   test/lib/Makefile |   1 +
>>   test/lib/lmb.c    | 297 ++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 298 insertions(+)
>>   create mode 100644 test/lib/lmb.c
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Seems fine. I wonder if it would be easier to simulate a 10-byte
> memory size? It shouldn't matter how big it is.

This one slipped through somehow, sorry.

I wrote the test by simulating real values. Since there is no memory 
involved, only numbers, personally, I don't think simulating 10 bytes 
makes it easier than simulating 512 MiB. I'd leave it like it is, unless 
you insist...

Regards,
Simon

  reply	other threads:[~2019-01-14 19:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 20:13 [U-Boot] [PATCH v6 0/9] Fix CVE-2018-18440 and CVE-2018-18439 Simon Goldschmidt
2018-12-14 20:13 ` [U-Boot] [PATCH v6 1/9] test: add test for lib/lmb.c Simon Goldschmidt
2019-01-05  1:56   ` Simon Glass
2019-01-14 19:19     ` Simon Goldschmidt [this message]
2018-12-14 20:13 ` [U-Boot] [PATCH v6 2/9] lmb: fix allocation at end of address range Simon Goldschmidt
2018-12-14 20:13 ` [U-Boot] [PATCH v6 3/9] lib: lmb: reserving overlapping regions should fail Simon Goldschmidt
2018-12-15 15:10   ` Tom Rini
2018-12-14 20:13 ` [U-Boot] [PATCH v6 4/9] fdt: parse "reserved-memory" for memory reservation Simon Goldschmidt
2019-01-05  1:56   ` Simon Glass
2018-12-14 20:13 ` [U-Boot] [PATCH v6 5/9] lib: lmb: extend lmb for checks at load time Simon Goldschmidt
2018-12-14 20:13 ` [U-Boot] [PATCH v6 6/9] fs: prevent overwriting reserved memory Simon Goldschmidt
2019-01-05  1:56   ` Simon Glass
2019-01-14 15:15     ` Simon Goldschmidt
2018-12-14 20:13 ` [U-Boot] [PATCH v6 7/9] bootm: use new common function lmb_init_and_reserve Simon Goldschmidt
2019-01-05  1:56   ` Simon Glass
2018-12-14 20:13 ` [U-Boot] [PATCH v6 8/9] lmb: remove unused extern declaration Simon Goldschmidt
2018-12-14 20:13 ` [U-Boot] [PATCH v6 9/9] tftp: prevent overwriting reserved memory Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32b0b4e3-c350-6085-a513-f4dd3ac3b46c@gmail.com \
    --to=simon.k.r.goldschmidt@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.