All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: <netdev@vger.kernel.org>
Cc: <alexandr.lobakin@intel.com>, <dchumak@nvidia.com>,
	<maximmi@nvidia.com>, <jiri@resnulli.us>,
	<simon.horman@corigine.com>, <jacob.e.keller@intel.com>,
	<jesse.brandeburg@intel.com>, <przemyslaw.kitszel@intel.com>
Subject: Re: [RFC PATCH net-next v4 0/6] Implement devlink-rate API and extend it
Date: Thu, 15 Sep 2022 15:57:34 +0200	[thread overview]
Message-ID: <32b1423d-abe3-393e-2044-3169bbf2a52c@intel.com> (raw)
In-Reply-To: <20220915134239.1935604-1-michal.wilczynski@intel.com>



On 9/15/2022 3:42 PM, Michal Wilczynski wrote:
> This patch series implements devlink-rate for ice driver. Unfortunately
> current API isn't flexible enough for our use case, so there is a need to
> extend it. New object type 'queue' is being introduced, and more functions
> has been changed to non-static, to enable the driver to export current
> Tx scheduling configuration.
>
> This patch series is a follow up for this thread:
> https://lore.kernel.org/netdev/20220704114513.2958937-1-michal.wilczynski@intel.com/T/#u
>
> V4:
> - changed static variable counter to per port IDA to
>    uniquely identify nodes
>
> V3:
> - removed shift macros, since FIELD_PREP is used
> - added static_assert for struct
> - removed unnecessary functions
> - used tab instead of space in define
>
> V2:
> - fixed Alexandr comments
> - refactored code to fix checkpatch issues
> - added mutual exclusion for RDMA, DCB

I realized now that I haven't removed versioning from internal review,
please ignore this.
BR,
Michał

>
>
> Ben Shelton (1):
>    ice: Add function for move/reconfigure TxQ AQ command
>
> Michal Wilczynski (5):
>    devlink: Extend devlink-rate api with queues and new parameters
>    ice: Introduce new parameters in ice_sched_node
>    ice: Implement devlink-rate API
>    ice: Export Tx scheduler configuration to devlink-rate
>    ice: Prevent ADQ, DCB and RDMA coexistence with Custom Tx scheduler
>
>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  41 +-
>   drivers/net/ethernet/intel/ice/ice_common.c   |  75 ++-
>   drivers/net/ethernet/intel/ice/ice_common.h   |   8 +
>   drivers/net/ethernet/intel/ice/ice_dcb.c      |   2 +-
>   drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   4 +
>   drivers/net/ethernet/intel/ice/ice_devlink.c  | 598 ++++++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_devlink.h  |   2 +
>   drivers/net/ethernet/intel/ice/ice_idc.c      |   5 +
>   drivers/net/ethernet/intel/ice/ice_main.c     |   2 +
>   drivers/net/ethernet/intel/ice/ice_sched.c    |  81 ++-
>   drivers/net/ethernet/intel/ice/ice_sched.h    |  27 +-
>   drivers/net/ethernet/intel/ice/ice_type.h     |   7 +
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |  10 +
>   .../net/ethernet/mellanox/mlx5/core/devlink.c |   6 +-
>   .../mellanox/mlx5/core/esw/devlink_port.c     |   8 +-
>   .../net/ethernet/mellanox/mlx5/core/esw/qos.c |  12 +-
>   .../net/ethernet/mellanox/mlx5/core/esw/qos.h |  10 +-
>   drivers/net/netdevsim/dev.c                   |  32 +-
>   include/net/devlink.h                         |  56 +-
>   include/uapi/linux/devlink.h                  |   8 +-
>   net/core/devlink.c                            | 407 ++++++++++--
>   21 files changed, 1284 insertions(+), 117 deletions(-)
>


  parent reply	other threads:[~2022-09-15 13:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 13:42 [RFC PATCH net-next v4 0/6] Implement devlink-rate API and extend it Michal Wilczynski
2022-09-15 13:42 ` [RFC PATCH net-next v4 1/6] ice: Add function for move/reconfigure TxQ AQ command Michal Wilczynski
2022-09-15 13:42 ` [RFC PATCH net-next v4 2/6] devlink: Extend devlink-rate api with queues and new parameters Michal Wilczynski
2022-09-15 15:31   ` Edward Cree
2022-09-15 18:41     ` Wilczynski, Michal
2022-09-15 21:01       ` Edward Cree
2022-09-19 13:12         ` Wilczynski, Michal
2022-09-20 11:09           ` Edward Cree
2022-09-26 11:58             ` Jiri Pirko
2022-09-28 11:53               ` Wilczynski, Michal
2022-09-29  7:08                 ` Jiri Pirko
2022-09-21 23:33       ` Jakub Kicinski
2022-09-22 11:44         ` Wilczynski, Michal
2022-09-22 12:50           ` Jakub Kicinski
2022-09-22 13:45             ` Wilczynski, Michal
2022-09-22 20:29               ` Jakub Kicinski
2022-09-23 12:11                 ` Wilczynski, Michal
2022-09-23 13:16                   ` Jakub Kicinski
2022-09-23 15:46                     ` Wilczynski, Michal
2022-09-27  0:16                       ` Jakub Kicinski
2022-09-28 12:02                         ` Wilczynski, Michal
2022-09-28 17:39                           ` Jakub Kicinski
2022-09-26 11:51       ` Jiri Pirko
2022-09-28 11:47         ` Wilczynski, Michal
2022-09-29  7:12           ` Jiri Pirko
2022-10-11 13:28             ` Wilczynski, Michal
2022-10-11 14:17               ` Jiri Pirko
2022-09-15 13:42 ` [RFC PATCH net-next v4 3/6] ice: Introduce new parameters in ice_sched_node Michal Wilczynski
2022-09-15 13:42 ` [RFC PATCH net-next v4 4/6] ice: Implement devlink-rate API Michal Wilczynski
2022-09-22 13:08   ` Przemek Kitszel
2022-09-15 13:42 ` [RFC PATCH net-next v4 5/6] ice: Export Tx scheduler configuration to devlink-rate Michal Wilczynski
2022-09-15 13:42 ` [RFC PATCH net-next v4 6/6] ice: Prevent ADQ, DCB and RDMA coexistence with Custom Tx scheduler Michal Wilczynski
2022-09-15 13:57 ` Wilczynski, Michal [this message]
2022-09-19  7:22 [RFC PATCH net-next v4 2/6] devlink: Extend devlink-rate api with queues and new parameters kernel test robot
2022-09-19  9:22 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32b1423d-abe3-393e-2044-3169bbf2a52c@intel.com \
    --to=michal.wilczynski@intel.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=dchumak@nvidia.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@resnulli.us \
    --cc=maximmi@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.