From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2 1/2] eal: fix potential incorrect pinning
 for ctrl threads
Date: Thu, 14 Feb 2019 16:12:24 +0000
Message-ID: <32bd2385-b979-12f8-26ef-e03e28e53462@intel.com>
References: <1550074412-31285-1-git-send-email-david.marchand@redhat.com>
 <1550151042-9764-1-git-send-email-david.marchand@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: olivier.matz@6wind.com, ktraynor@redhat.com, stable@dpdk.org
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1550151042-9764-1-git-send-email-david.marchand@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 14-Feb-19 1:30 PM, David Marchand wrote:
> pthread_setaffinity_np returns a >0 value on error.
> We could end up letting the ctrl threads on the current process cpu
> affinity.
> 
> Fixes: d651ee4919cd ("eal: set affinity for control threads")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/librte_eal/common/eal_common_thread.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
> index 48ef4d6..a3985ce 100644
> --- a/lib/librte_eal/common/eal_common_thread.c
> +++ b/lib/librte_eal/common/eal_common_thread.c
> @@ -209,7 +209,7 @@ static void *rte_thread_init(void *arg)
>   		CPU_SET(rte_get_master_lcore(), &cpuset);
>   
>   	ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
> -	if (ret < 0)
> +	if (ret)
>   		goto fail;
>   
>   	ret = pthread_barrier_wait(&params->configured);
> 

CC: stable?

-- 
Thanks,
Anatoly