All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
	xen-devel@lists.xenproject.org, sstabellini@kernel.org
Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap
Date: Thu, 17 Feb 2022 19:47:05 +0000	[thread overview]
Message-ID: <32c0c8f9-6e34-1a1a-3638-d3f68b7d6819@xen.org> (raw)
In-Reply-To: <7d934fd7-b1e2-8a9e-10dd-a213db93c689@xen.org>

Hi,

On 17/02/2022 11:01, Julien Grall wrote:
> On 16/02/2022 09:34, Jan Beulich wrote:
>> On 15.02.2022 21:26, Julien Grall wrote:
>>> (+ Jan)
>>>
>>> Hi Penny,
>>>
>>> I am CCing Jan to give him a chance to...
>>
>> Thanks, but ...
>>
>>> On 14/02/2022 03:19, Penny Zheng wrote:
>>>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
>>>> index cfb0b47f13..24eb4cc7d3 100644
>>>> --- a/xen/include/xen/domain.h
>>>> +++ b/xen/include/xen/domain.h
>>>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>>>>    /* CDF_* constant. Internal flags for domain creation. */
>>>>    /* Is this a privileged domain? */
>>>>    #define CDF_privileged           (1U << 0)
>>>> +#ifdef CONFIG_ARM
>>>> +/* Should domain memory be directly mapped? */
>>>> +#define CDF_directmap            (1U << 1)
>>>> +#endif
>>>
>>> ... comment on this approach. I would be happy to switch to an ASSERT()
>>> if that's preferred.
>>
>> ... I think I did signal agreement with this approach beforehand.
> 
> You raised a concern and it wasn't 100% obvious whether you would still 
> be happy if we merged it as-is.
> 
> So I preferred to ask rather than merging it and getting an angry 
> e-mail/message afterwards :).
> 
> Anyway, this series is now fully acked. So I will commit the series in a 
> bit.

Well, I forgot to explicitely Acked this patch. So:

Acked-by: Julien Grall <jgrall@amazon.com>

This series is now fully committed. Thank you for your contribution!

Cheers,

-- 
Julien Grall


  reply	other threads:[~2022-02-17 19:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14  3:19 [PATCH v6 00/11] direct-map memory map Penny Zheng
2022-02-14  3:19 ` [PATCH v6 01/11] xen: introduce internal CDF_xxx flags for domain creation Penny Zheng
2022-02-14  3:19 ` [PATCH v6 02/11] xen: introduce CDF_directmap Penny Zheng
2022-02-15 20:26   ` Julien Grall
2022-02-16  9:34     ` Jan Beulich
2022-02-17 11:01       ` Julien Grall
2022-02-17 19:47         ` Julien Grall [this message]
2022-02-14  3:19 ` [PATCH v6 03/11] xen/arm: Allow device-passthrough even the IOMMU is off Penny Zheng
2022-02-15 20:26   ` Julien Grall
2022-02-14  3:19 ` [PATCH v6 04/11] xen/arm: introduce new helper parse_static_mem_prop and acquire_static_memory_bank Penny Zheng
2022-02-14  3:19 ` [PATCH v6 05/11] xen/arm: introduce direct-map for domUs Penny Zheng
2022-02-14  3:19 ` [PATCH v6 06/11] xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory Penny Zheng
2022-02-14  3:19 ` [PATCH v6 07/11] xen/arm: if direct-map domain use native addresses for GICv2 Penny Zheng
2022-02-14  3:19 ` [PATCH v6 08/11] xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3 Penny Zheng
2022-02-14  3:19 ` [PATCH v6 09/11] xen/arm: if direct-map domain use native addresses for GICv3 Penny Zheng
2022-02-14  3:19 ` [PATCH v6 10/11] xen/arm: if direct-map domain use native UART address and IRQ number for vPL011 Penny Zheng
2022-02-14  3:19 ` [PATCH v6 11/11] xen/docs: Document how to do passthrough without IOMMU Penny Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c0c8f9-6e34-1a1a-3638-d3f68b7d6819@xen.org \
    --to=julien@xen.org \
    --cc=Bertrand.Marquis@arm.com \
    --cc=Wei.Chen@arm.com \
    --cc=penny.zheng@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.