All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Qiming Chen <chenqiming_huawei@163.com>, dev@dpdk.org
Cc: haiyue.wang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mbuf leak
Date: Tue, 31 Aug 2021 11:00:04 +0100	[thread overview]
Message-ID: <32c26bad-9da6-baa0-e810-b3efa1d729fd@redhat.com> (raw)
In-Reply-To: <20210831080630.5719-1-chenqiming_huawei@163.com>

On 31/08/2021 09:06, Qiming Chen wrote:
> A local test found that repeated port start and stop operations during
> the continuous SSE vector bufflist receiving process will cause the mbuf
> resource to run out. The final positioning is when the port is stopped,
> the mbuf of the pkt_first_seg pointer is not released. Resources leak.
> The patch scheme is to judge whether the pointer is empty when the port
> is stopped, and release the corresponding mbuf if it is not empty.
> 
> Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")

That is a file rename, it should be when the functionality was
introduced, so in this case:
Fixes: af75078fece3 ("first public release")

> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> v2:
>   Sync to stable@dpdk.org
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index c814a28cb4..bfdfd5e755 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2981,6 +2981,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
>  	rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);
>  	rxq->rx_tail = 0;
>  	rxq->nb_rx_hold = 0;
> +
> +	if (rxq->pkt_first_seg != NULL)
> +		rte_pktmbuf_free(rxq->pkt_first_seg);
> +
>  	rxq->pkt_first_seg = NULL;
>  	rxq->pkt_last_seg = NULL;
>  
> 


  reply	other threads:[~2021-08-31 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  3:28 [dpdk-dev] [PATCH] net/ixgbe: slove mbuf leak Qiming Chen
2021-08-31  6:04 ` Wang, Haiyue
2021-08-31  6:40   ` Qiming Chen
2021-08-31  6:51     ` Wang, Haiyue
2021-08-31  8:03 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix " Qiming Chen
2021-08-31  8:06 ` Qiming Chen
2021-08-31 10:00   ` Kevin Traynor [this message]
2021-09-01  1:50     ` Qiming Chen
2021-09-01  3:17       ` Wang, Haiyue
2021-09-01  7:22   ` [dpdk-dev] [PATCH v3] " Qiming Chen
2021-09-06  1:22     ` Wang, Haiyue
2021-09-06  1:45       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c26bad-9da6-baa0-e810-b3efa1d729fd@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=chenqiming_huawei@163.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.