From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FDABC00144 for ; Fri, 29 Jul 2022 07:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1GENxlC9pJX61Nikpn27f8zaLbnd8/DEj/GFodYiqqA=; b=DnoOMC9ooByvIE rtHBso7QIUw2AUjINYTKnOPWnjSkeSTedMLhFjRWYzyR/Kvhx4nxilyvUfAMQTEuQ9BtXv/iUQhtu qp/P9KSgdTuVFUZEWGeGjwuVluW36nYaNW/f7OnRy4uk+xqkv8qbkKTEpUcyUXoysCj54G9qWfgWi chWrStQ+9UbD411St2gHrGyz0U7WR2vF9jJv52SvjpXufrGx4akFn60akPlbnBPHNi/L0VLFuA9aA WAui24TDMEe5tOhdXJUxLr98/3tBs4A4+nUyRmGRcdCTA7MVUuTJAAi7LxodE+nS8dxxGmWGUkblK CAJsYOwPVnCMhSw97FYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKau-002gfL-52; Fri, 29 Jul 2022 07:39:36 +0000 Received: from 7.mo548.mail-out.ovh.net ([46.105.33.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKap-002gcA-Fs for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 07:39:33 +0000 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.183]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 69E68227C8; Fri, 29 Jul 2022 07:39:23 +0000 (UTC) Received: from kaod.org (37.59.142.102) by DAG4EX2.mxp5.local (172.16.2.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 29 Jul 2022 09:39:21 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-102R0041218b063-a24c-41c6-87ed-1d34e970e8a6, FAFF5065920E43DA0D2CF6C40E58A39B80E28978) smtp.auth=clg@kaod.org X-OVh-ClientIp: 90.89.72.120 Message-ID: <32c4045d-7fce-5954-9710-4f6b0c6b0d2a@kaod.org> Date: Fri, 29 Jul 2022 09:39:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH linux dev-5.15] soc: aspeed: abr: Add sysfs attrs for flash toggle Content-Language: en-US To: Andrew Jeffery , Jian Zhang , , Joel Stanley CC: , Mark Brown , open list , "open list:SPI SUBSYSTEM" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" References: <20220501105644.355062-1-zhangjian.3032@bytedance.com> <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> X-Originating-IP: [37.59.142.102] X-ClientProxiedBy: DAG9EX1.mxp5.local (172.16.2.81) To DAG4EX2.mxp5.local (172.16.2.32) X-Ovh-Tracer-GUID: a6453bd3-2138-4703-b325-6e2aced1d2b3 X-Ovh-Tracer-Id: 10280310576058174386 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduiedgieegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeelleeiiefgkeefiedtvdeigeetueetkeffkeelheeugfetteegvdekgfehgffgkeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdgrshhpvggvugeslhhishhtshdrohiilhgrsghsrdhorhhgpdfovfetjfhoshhtpehmohehgeek X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_003931_727234_A80FAF75 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 7/29/22 04:37, Andrew Jeffery wrote: > Hi Jian Zhang, > > On Sun, 1 May 2022, at 20:26, Jian Zhang wrote: >> Implement the flash toggle function in soc ast2600. >> Add two sysfs attrs named "access_primary" and "access_backup" > > If you're proposing this patch for upstream then it needs to be based on > an upstream kernel tree, not the OpenBMC kernel tree. You also should > not use e.g. `linux dev-5.15` in the patch subject prefix, as that would > be inappropriate for an upstream patch. > > As you're adding sysfs attributes you'll also need to add the > corresponding ABI documentation. Yes. I think we need to discuss the ABI/sysfs files a bit. I am not sure we should toggle the sysfs files depending on the boot mode : primary vs. alternate. We could have the same files always and return EIO if some conditions are not met. Something like : * boot mode : primary/alternate. Write changes the next boot. * watchdog management Also, there is no need to introduce a new include file with large inline functions. Thanks, C. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE7BC00144 for ; Fri, 29 Jul 2022 10:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235593AbiG2KHK (ORCPT ); Fri, 29 Jul 2022 06:07:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231878AbiG2KHI (ORCPT ); Fri, 29 Jul 2022 06:07:08 -0400 X-Greylist: delayed 7805 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 29 Jul 2022 03:07:02 PDT Received: from 4.mo548.mail-out.ovh.net (4.mo548.mail-out.ovh.net [188.165.42.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D16F381B01 for ; Fri, 29 Jul 2022 03:07:02 -0700 (PDT) Received: from mxplan5.mail.ovh.net (unknown [10.109.143.183]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 69E68227C8; Fri, 29 Jul 2022 07:39:23 +0000 (UTC) Received: from kaod.org (37.59.142.102) by DAG4EX2.mxp5.local (172.16.2.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 29 Jul 2022 09:39:21 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-102R0041218b063-a24c-41c6-87ed-1d34e970e8a6, FAFF5065920E43DA0D2CF6C40E58A39B80E28978) smtp.auth=clg@kaod.org X-OVh-ClientIp: 90.89.72.120 Message-ID: <32c4045d-7fce-5954-9710-4f6b0c6b0d2a@kaod.org> Date: Fri, 29 Jul 2022 09:39:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH linux dev-5.15] soc: aspeed: abr: Add sysfs attrs for flash toggle Content-Language: en-US To: Andrew Jeffery , Jian Zhang , , Joel Stanley CC: , Mark Brown , open list , "open list:SPI SUBSYSTEM" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" References: <20220501105644.355062-1-zhangjian.3032@bytedance.com> <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.102] X-ClientProxiedBy: DAG9EX1.mxp5.local (172.16.2.81) To DAG4EX2.mxp5.local (172.16.2.32) X-Ovh-Tracer-GUID: a6453bd3-2138-4703-b325-6e2aced1d2b3 X-Ovh-Tracer-Id: 10280310576058174386 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduiedgieegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeelleeiiefgkeefiedtvdeigeetueetkeffkeelheeugfetteegvdekgfehgffgkeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdgrshhpvggvugeslhhishhtshdrohiilhgrsghsrdhorhhgpdfovfetjfhoshhtpehmohehgeek Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 7/29/22 04:37, Andrew Jeffery wrote: > Hi Jian Zhang, > > On Sun, 1 May 2022, at 20:26, Jian Zhang wrote: >> Implement the flash toggle function in soc ast2600. >> Add two sysfs attrs named "access_primary" and "access_backup" > > If you're proposing this patch for upstream then it needs to be based on > an upstream kernel tree, not the OpenBMC kernel tree. You also should > not use e.g. `linux dev-5.15` in the patch subject prefix, as that would > be inappropriate for an upstream patch. > > As you're adding sysfs attributes you'll also need to add the > corresponding ABI documentation. Yes. I think we need to discuss the ABI/sysfs files a bit. I am not sure we should toggle the sysfs files depending on the boot mode : primary vs. alternate. We could have the same files always and return EIO if some conditions are not met. Something like : * boot mode : primary/alternate. Write changes the next boot. * watchdog management Also, there is no need to introduce a new include file with large inline functions. Thanks, C. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67096C00144 for ; Fri, 29 Jul 2022 08:57:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LvLxd3Vqbz304j for ; Fri, 29 Jul 2022 18:57:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=188.165.58.48; helo=6.mo548.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) X-Greylist: delayed 2391 seconds by postgrey-1.36 at boromir; Fri, 29 Jul 2022 18:56:57 AEST Received: from 6.mo548.mail-out.ovh.net (6.mo548.mail-out.ovh.net [188.165.58.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LvLx54ccGz2xH9 for ; Fri, 29 Jul 2022 18:56:54 +1000 (AEST) Received: from mxplan5.mail.ovh.net (unknown [10.109.143.183]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 69E68227C8; Fri, 29 Jul 2022 07:39:23 +0000 (UTC) Received: from kaod.org (37.59.142.102) by DAG4EX2.mxp5.local (172.16.2.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 29 Jul 2022 09:39:21 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-102R0041218b063-a24c-41c6-87ed-1d34e970e8a6, FAFF5065920E43DA0D2CF6C40E58A39B80E28978) smtp.auth=clg@kaod.org X-OVh-ClientIp: 90.89.72.120 Message-ID: <32c4045d-7fce-5954-9710-4f6b0c6b0d2a@kaod.org> Date: Fri, 29 Jul 2022 09:39:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH linux dev-5.15] soc: aspeed: abr: Add sysfs attrs for flash toggle Content-Language: en-US To: Andrew Jeffery , Jian Zhang , , Joel Stanley References: <20220501105644.355062-1-zhangjian.3032@bytedance.com> <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.102] X-ClientProxiedBy: DAG9EX1.mxp5.local (172.16.2.81) To DAG4EX2.mxp5.local (172.16.2.32) X-Ovh-Tracer-GUID: a6453bd3-2138-4703-b325-6e2aced1d2b3 X-Ovh-Tracer-Id: 10280310576058174386 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduiedgieegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeelleeiiefgkeefiedtvdeigeetueetkeffkeelheeugfetteegvdekgfehgffgkeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdgrshhpvggvugeslhhishhtshdrohiilhgrsghsrdhorhhgpdfovfetjfhoshhtpehmohehgeek X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangjian_linux@163.com, "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "open list:SPI SUBSYSTEM" , Mark Brown , "moderated list:ARM/ASPEED MACHINE SUPPORT" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hello, On 7/29/22 04:37, Andrew Jeffery wrote: > Hi Jian Zhang, > > On Sun, 1 May 2022, at 20:26, Jian Zhang wrote: >> Implement the flash toggle function in soc ast2600. >> Add two sysfs attrs named "access_primary" and "access_backup" > > If you're proposing this patch for upstream then it needs to be based on > an upstream kernel tree, not the OpenBMC kernel tree. You also should > not use e.g. `linux dev-5.15` in the patch subject prefix, as that would > be inappropriate for an upstream patch. > > As you're adding sysfs attributes you'll also need to add the > corresponding ABI documentation. Yes. I think we need to discuss the ABI/sysfs files a bit. I am not sure we should toggle the sysfs files depending on the boot mode : primary vs. alternate. We could have the same files always and return EIO if some conditions are not met. Something like : * boot mode : primary/alternate. Write changes the next boot. * watchdog management Also, there is no need to introduce a new include file with large inline functions. Thanks, C.