From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8EDC48BCD for ; Wed, 9 Jun 2021 15:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40EF661359 for ; Wed, 9 Jun 2021 15:26:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236273AbhFIP2s (ORCPT ); Wed, 9 Jun 2021 11:28:48 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:46493 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236254AbhFIP2l (ORCPT ); Wed, 9 Jun 2021 11:28:41 -0400 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lr06P-0000Ia-OR for linux-kernel@vger.kernel.org; Wed, 09 Jun 2021 15:26:45 +0000 Received: by mail-wr1-f70.google.com with SMTP id z3-20020adfdf830000b02901198337bc39so10345023wrl.0 for ; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uc80ffGUW4bvL26aSzQf5lcnkR5pCyi0tKOquETfeS4=; b=pJYNN6VYP4WHpNU/Hkx/G76l8rCGWdr9YHhrf/pmJgAnrAur/hP4mKcjQRWdbjLLD/ okJsyWBWp56sIh/vxrbLdoIqkg1O16uebvlDEiOAULbYPAbLl8RpxLixDwU+PVzBqcvf oc0mVriameKJEumj7akM5ccyQGwE0WEpSxc+Pi0PP//fQDIHeE4EqTkoSb+GJu+/FKui P5ij7PDWh/k3L5gY9dLrSbhGFR4w9sQBjads4u+ptH8zgCwOGFmg1P5koP1XocoiW/bz wkHxC6pda2amYEYd0lFm+xBwS7/FDoZBKH23ER9p3pcqL6fMXLdRedaqrPPkCy9Z94kJ B7DQ== X-Gm-Message-State: AOAM53382avwBoKKwXnvqmpezazN5WMbSeISYx+em/zzW0LbQRrR9SPs lWq85+dDadbfIJr8cGHtxWhkLW8xydK9u5YP58WimAVBQ7FJkbVM2u8TZi4qVVEpb929dXLi+HJ XY37ladwyoB14VbdKCxehrTwIPZEzR92aqXkFYVNC0g== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr424020wro.164.1623252405364; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhA14PyEmBvm9o5LBw9p40ein5C/0++XCyNMvnaDvIOg27HB9rKWvzvpDI5U68qhBmz6kV4A== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr423998wro.164.1623252405214; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id k42sm7937283wms.0.2021.06.09.08.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 08:26:44 -0700 (PDT) Subject: Re: [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-10-miquel.raynal@bootlin.com> <20210609153410.53eadf8e@xps13> <77db74d3-c44a-6aa3-1b61-f6bed565fa04@canonical.com> <20210609161128.16cdf5ec@xps13> From: Krzysztof Kozlowski Message-ID: <32c7adf2-6f4e-ef2d-a137-a9674f9e6baa@canonical.com> Date: Wed, 9 Jun 2021 17:26:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609161128.16cdf5ec@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2021 16:11, Miquel Raynal wrote: > Hi Krzysztof, Rob, > > Krzysztof Kozlowski wrote on Wed, 9 > Jun 2021 15:54:19 +0200: > >> On 09/06/2021 15:34, Miquel Raynal wrote: >>> Hi Krzysztof, >>> >>> Krzysztof Kozlowski wrote on Wed, 9 >>> Jun 2021 14:12:40 +0200: >>> >>>> On 09/06/2021 10:01, Miquel Raynal wrote: >>>>> Convert this binding file to yaml schema. >>>>> >>>>> Signed-off-by: Miquel Raynal >>>>> --- >>>>> .../memory-controllers/arm,pl353-smc.yaml | 133 ++++++++++++++++++ >>>>> .../bindings/memory-controllers/pl353-smc.txt | 45 ------ >>>>> 2 files changed, 133 insertions(+), 45 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> new file mode 100644 >>>>> index 000000000000..1de6f87d4986 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> @@ -0,0 +1,133 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/memory-controllers/arm,pl353-smc.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: ARM PL353 Static Memory Controller (SMC) device-tree bindings >>>>> + >>>>> +maintainers: >>>>> + - Miquel Raynal >>>>> + - Naga Sureshkumar Relli >>>>> + >>>>> +description: >>>>> + The PL353 Static Memory Controller is a bus where you can connect two kinds >>>>> + of memory interfaces, which are NAND and memory mapped interfaces (such as >>>>> + SRAM or NOR). >>>>> + >>>>> +# We need a select here so we don't match all nodes with 'arm,primecell' >>>>> +select: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - arm,pl353-smc-r2p1 >>>> >>>> That's a const... but also I don't get the need for select. >>> >>> I think this is needed to ensure this binding is not enforced against >>> arm,primecell compatible nodes which are not featuring the >>> arm,pl353-smc-r2p1 compatible. >> >> Which seems to be result of unusual compatible match, so once you >> convert to regular match, this select is not needed. > > I don't think so, I received a hint from Rob some time ago, he told > me to add this additional select line as in all other arm,primecell > binding. > > Rob, any additional info regarding this? Hmm, I think you' are right. Since arm,primecell is used in many other compatibles (including ones without schema yet), the select is needed. In such case the select can be only: select: properties: compatible: contains: const: arm,pl353-smc-r2p1 Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44ABC48BD1 for ; Wed, 9 Jun 2021 16:40:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 784BA610A1 for ; Wed, 9 Jun 2021 16:40:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 784BA610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=K7Y65O4a+nYJVXdnOfiw4iJnWRroNRMeDLnOkmUSotU=; b=Jep4cUWSLU4BQ2RuPIAV3ckJYY s1awBM+Iu0u2kpY1mm/IxAJAan3nqFzr6VVAEoGqI7DK3CWI4Y8PN8yZmTIYKXzUh6tY3zoTGLim6 AAJwAUVor9iC2gUarri8JLIHjckuxRfwojEE9f6JSx9e9XnU3jCXOE3RSrXWx5MwuopxYljqhN1GM TjjUcrl/vh6OqZajCUEJ3bmb2stTd0KObQ0QOWSmnrGoEJ2Tn9aK+R0JbEHhEZn9B5wCatyAFAYav iSjJ1gl0KYi8hO7C9khPRtGztPinqEnsDbVxoaaYzw2FlY7JWFQCt4vWiJQJ9DR7Cr2O79VvY1rfx BypRgTDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr1FG-00Eznv-O6; Wed, 09 Jun 2021 16:39:59 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr06U-00EaZf-1g for linux-mtd@lists.infradead.org; Wed, 09 Jun 2021 15:26:51 +0000 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lr06P-0000IX-Mu for linux-mtd@lists.infradead.org; Wed, 09 Jun 2021 15:26:45 +0000 Received: by mail-wm1-f72.google.com with SMTP id f186-20020a1c1fc30000b02901aaa08ad8f4so2654287wmf.8 for ; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uc80ffGUW4bvL26aSzQf5lcnkR5pCyi0tKOquETfeS4=; b=KhiovZ+wZqR95xGyxXRxkya30ybaj270vtwMuRQmHJSCbfaB7MPEXkFVAeHbJTn7Qe cOYCx0fTiXH/iZWpQEhKtAM2bj/FtRRxW+/nQSmpGdHU94VKOcjcbTPHyVPvSy0BQ707 J29ceI4wYNZiF8RrnIqNQZVrlNAiro1RXCl17frdMgWt8zpHESb9IItffBCYeYWzMQP0 /e7VIqRfm37wHolPUiNbqEkv9kiSXZ7tjIDDC5DUXR8tnXa97J9GhwylE0+ndWw/Attf UeLAcDku2o1lI7sb79loU+hpNXmzd9guEQTFT/StmSy7CuhgDsyrh1KzW13S0feQYz1B CIjA== X-Gm-Message-State: AOAM530+X6EV1diKSc76Ekflf5oUOd7lr/rhxSiL96gz7n1vmUWeg8Dg IVT++U0mS/sCuE6D0FsoovYC0QXnuriovzAYj5fKjiivIUdNuj5NNvCMGVjunYbR0YS3148nelb jIkdE9GygrkIfbIu0AxrMmG1CYs0M2chZnGReUocVgk8= X-Received: by 2002:adf:ed8d:: with SMTP id c13mr424023wro.164.1623252405365; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhA14PyEmBvm9o5LBw9p40ein5C/0++XCyNMvnaDvIOg27HB9rKWvzvpDI5U68qhBmz6kV4A== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr423998wro.164.1623252405214; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id k42sm7937283wms.0.2021.06.09.08.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 08:26:44 -0700 (PDT) Subject: Re: [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-10-miquel.raynal@bootlin.com> <20210609153410.53eadf8e@xps13> <77db74d3-c44a-6aa3-1b61-f6bed565fa04@canonical.com> <20210609161128.16cdf5ec@xps13> From: Krzysztof Kozlowski Message-ID: <32c7adf2-6f4e-ef2d-a137-a9674f9e6baa@canonical.com> Date: Wed, 9 Jun 2021 17:26:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609161128.16cdf5ec@xps13> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_082650_153380_F8DCC953 X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 09/06/2021 16:11, Miquel Raynal wrote: > Hi Krzysztof, Rob, > > Krzysztof Kozlowski wrote on Wed, 9 > Jun 2021 15:54:19 +0200: > >> On 09/06/2021 15:34, Miquel Raynal wrote: >>> Hi Krzysztof, >>> >>> Krzysztof Kozlowski wrote on Wed, 9 >>> Jun 2021 14:12:40 +0200: >>> >>>> On 09/06/2021 10:01, Miquel Raynal wrote: >>>>> Convert this binding file to yaml schema. >>>>> >>>>> Signed-off-by: Miquel Raynal >>>>> --- >>>>> .../memory-controllers/arm,pl353-smc.yaml | 133 ++++++++++++++++++ >>>>> .../bindings/memory-controllers/pl353-smc.txt | 45 ------ >>>>> 2 files changed, 133 insertions(+), 45 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> new file mode 100644 >>>>> index 000000000000..1de6f87d4986 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> @@ -0,0 +1,133 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/memory-controllers/arm,pl353-smc.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: ARM PL353 Static Memory Controller (SMC) device-tree bindings >>>>> + >>>>> +maintainers: >>>>> + - Miquel Raynal >>>>> + - Naga Sureshkumar Relli >>>>> + >>>>> +description: >>>>> + The PL353 Static Memory Controller is a bus where you can connect two kinds >>>>> + of memory interfaces, which are NAND and memory mapped interfaces (such as >>>>> + SRAM or NOR). >>>>> + >>>>> +# We need a select here so we don't match all nodes with 'arm,primecell' >>>>> +select: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - arm,pl353-smc-r2p1 >>>> >>>> That's a const... but also I don't get the need for select. >>> >>> I think this is needed to ensure this binding is not enforced against >>> arm,primecell compatible nodes which are not featuring the >>> arm,pl353-smc-r2p1 compatible. >> >> Which seems to be result of unusual compatible match, so once you >> convert to regular match, this select is not needed. > > I don't think so, I received a hint from Rob some time ago, he told > me to add this additional select line as in all other arm,primecell > binding. > > Rob, any additional info regarding this? Hmm, I think you' are right. Since arm,primecell is used in many other compatibles (including ones without schema yet), the select is needed. In such case the select can be only: select: properties: compatible: contains: const: arm,pl353-smc-r2p1 Best regards, Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 413D8C48BCD for ; Wed, 9 Jun 2021 16:57:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 041FF61376 for ; Wed, 9 Jun 2021 16:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 041FF61376 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lMQi8Qefp215WceW6RjEU8/HSm1lDZezUp4UXlLrPPU=; b=fUIvSph4LZ82h8YSgkQ/OyqpX+ bogWOOfqfO9FtYtPpdVsyJ4xaImHi6yEbR3EDHwKnXZDhZVa9mug/ZhnrrRnKAA4TvQ07/Hwrt8UQ quTBN5cQk2YDtuFJrAKNdan2uju65SdZ1KDDsmOubk6oa5IyQedlI742zJgGuw5bRz3hwemy3HEEs tzPy8XXRXK9tDl3Hmbc8AKjyIGSnaZz22jVOOjkZqgV2b40LXAn+/+oEoKrnqvQVKF0c1U0/cfjOj 8DYA1y8ICqEwcn+UnfP1okRNUG0s5FazETcznjdryXB2BO6zryrOGpkCOiFJY3m7AnV/QJw5lABYp kTsbgkGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr1U3-00F5gI-Qg; Wed, 09 Jun 2021 16:55:17 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr0Cv-00EcNe-3P for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 15:33:30 +0000 Received: from mail-lf1-f72.google.com ([209.85.167.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lr0Ct-0000ow-H5 for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 15:33:27 +0000 Received: by mail-lf1-f72.google.com with SMTP id k37-20020a0565123da5b02902f6e4babbebso7342351lfv.18 for ; Wed, 09 Jun 2021 08:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uc80ffGUW4bvL26aSzQf5lcnkR5pCyi0tKOquETfeS4=; b=OglNgppxlVLy8N3YJzEsAjDejrTQpc10u8Qn9ya6NdwwIz87p2aa57yPuOMW0UXd/X QynfgWIvQQk2/+v8DdoipBbtCU2Wsd3TW5oHhpMA1T2LPUi0A9D9puohlCXSxoIkYQ20 RpFU0jN1tNsZvq5a6RuwsiqqU43gzacAoe3QM2Lb45iwvLGOpS92jR/ntWG39umE5yXs xgAA+zjTP/RIR+0uW2Js70B3Iufeav9IYlDiNpA9Thrh5hD3prAjtBRAcx7F7ICoUQBK OAhdFwdEke60w03SYBf0hmQdhQcG2bPqKOzWucQtmIINpdzcGr7T9Fgl2GNbVXn9FC02 GwhQ== X-Gm-Message-State: AOAM5334mioZNmo1WBInGelibJiaIjriSULO2X6SpmubpZAvaCqUZe3g rKxHPRKQplOd9vB2pe0PGxbCTbImF0Bfqh+XoxbzquZ6Ae71yMSB9RlRhXLjczL+OJRSJpt1bha 8k/Vy8Pyg+wrIw1K6Pjhk3zvnl7hoH8AGbtf3on6qYczN7kLOzePF X-Received: by 2002:adf:ed8d:: with SMTP id c13mr424015wro.164.1623252405364; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhA14PyEmBvm9o5LBw9p40ein5C/0++XCyNMvnaDvIOg27HB9rKWvzvpDI5U68qhBmz6kV4A== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr423998wro.164.1623252405214; Wed, 09 Jun 2021 08:26:45 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id k42sm7937283wms.0.2021.06.09.08.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 08:26:44 -0700 (PDT) Subject: Re: [PATCH v22 09/18] dt-binding: memory: pl353-smc: Convert to yaml To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-10-miquel.raynal@bootlin.com> <20210609153410.53eadf8e@xps13> <77db74d3-c44a-6aa3-1b61-f6bed565fa04@canonical.com> <20210609161128.16cdf5ec@xps13> From: Krzysztof Kozlowski Message-ID: <32c7adf2-6f4e-ef2d-a137-a9674f9e6baa@canonical.com> Date: Wed, 9 Jun 2021 17:26:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609161128.16cdf5ec@xps13> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_083329_187337_FFCC31E4 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2021 16:11, Miquel Raynal wrote: > Hi Krzysztof, Rob, > > Krzysztof Kozlowski wrote on Wed, 9 > Jun 2021 15:54:19 +0200: > >> On 09/06/2021 15:34, Miquel Raynal wrote: >>> Hi Krzysztof, >>> >>> Krzysztof Kozlowski wrote on Wed, 9 >>> Jun 2021 14:12:40 +0200: >>> >>>> On 09/06/2021 10:01, Miquel Raynal wrote: >>>>> Convert this binding file to yaml schema. >>>>> >>>>> Signed-off-by: Miquel Raynal >>>>> --- >>>>> .../memory-controllers/arm,pl353-smc.yaml | 133 ++++++++++++++++++ >>>>> .../bindings/memory-controllers/pl353-smc.txt | 45 ------ >>>>> 2 files changed, 133 insertions(+), 45 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> new file mode 100644 >>>>> index 000000000000..1de6f87d4986 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml >>>>> @@ -0,0 +1,133 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/memory-controllers/arm,pl353-smc.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: ARM PL353 Static Memory Controller (SMC) device-tree bindings >>>>> + >>>>> +maintainers: >>>>> + - Miquel Raynal >>>>> + - Naga Sureshkumar Relli >>>>> + >>>>> +description: >>>>> + The PL353 Static Memory Controller is a bus where you can connect two kinds >>>>> + of memory interfaces, which are NAND and memory mapped interfaces (such as >>>>> + SRAM or NOR). >>>>> + >>>>> +# We need a select here so we don't match all nodes with 'arm,primecell' >>>>> +select: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - arm,pl353-smc-r2p1 >>>> >>>> That's a const... but also I don't get the need for select. >>> >>> I think this is needed to ensure this binding is not enforced against >>> arm,primecell compatible nodes which are not featuring the >>> arm,pl353-smc-r2p1 compatible. >> >> Which seems to be result of unusual compatible match, so once you >> convert to regular match, this select is not needed. > > I don't think so, I received a hint from Rob some time ago, he told > me to add this additional select line as in all other arm,primecell > binding. > > Rob, any additional info regarding this? Hmm, I think you' are right. Since arm,primecell is used in many other compatibles (including ones without schema yet), the select is needed. In such case the select can be only: select: properties: compatible: contains: const: arm,pl353-smc-r2p1 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel