From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>,
"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"wucy11@chinatelecom.cn" <wucy11@chinatelecom.cn>
Subject: Re: [dm-devel] [PATCH 1/2] libmultipath: fix use-after-free in uev_add_path
Date: Tue, 9 Feb 2021 20:57:38 +0000 [thread overview]
Message-ID: <32e12b10f99011fc982e38bf95da9a99ef00a02b.camel@suse.com> (raw)
In-Reply-To: <1612847967-8813-2-git-send-email-bmarzins@redhat.com>
On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote:
> if ev_remove_path() returns success the path has very likely been
> deleted. However, if pathinfo() returned something besides
> PATHINFO_OK,
> but ev_remove_path() succeeded, uev_add_path() was still accessing
> the
> the path afterwards, which would likely cause a use-after-free error.
> Insted, uev_add_path() should only continue to access the path if
> ev_remove_path() didn't succeed.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix Imendörffer
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-09 20:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 5:19 [dm-devel] [PATCH 0/2] Handle remapped LUNs better Benjamin Marzinski
2021-02-09 5:19 ` [dm-devel] [PATCH 1/2] libmultipath: fix use-after-free in uev_add_path Benjamin Marzinski
2021-02-09 20:57 ` Martin Wilck [this message]
2021-02-09 5:19 ` [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid Benjamin Marzinski
2021-02-09 22:19 ` Martin Wilck
2021-02-10 18:09 ` Benjamin Block
2021-02-10 19:57 ` Martin Wilck
2021-02-11 11:25 ` Benjamin Block
2021-02-11 4:48 ` Benjamin Marzinski
2021-02-11 12:14 ` Martin Wilck
2021-02-18 3:22 ` Chongyun Wu
2021-02-19 10:46 ` Martin Wilck
2021-02-27 6:02 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32e12b10f99011fc982e38bf95da9a99ef00a02b.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=wucy11@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.