From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org,
rickyiu@google.com, odin@uged.al
Cc: sachinp@linux.vnet.ibm.com, naresh.kamboju@linaro.org
Subject: Re: [PATCH v2 2/3] sched/pelt: Don't sync hardly runnable_sum with runnable_avg
Date: Tue, 4 Jan 2022 12:47:14 +0100 [thread overview]
Message-ID: <32e4f1d7-26b1-802a-665f-f89de61db669@arm.com> (raw)
In-Reply-To: <20211222093802.22357-3-vincent.guittot@linaro.org>
On 22/12/2021 10:38, Vincent Guittot wrote:
[...]
> @@ -3704,7 +3709,10 @@ update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq)
>
> r = removed_runnable;
> sub_positive(&sa->runnable_avg, r);
> - sa->runnable_sum = sa->runnable_avg * divider;
> + sub_positive(&sa->runnable_sum, r * divider);
> + /* See update_tg_cfs_util() */
> + sa->runnable_sum = max_t(u32, sa->runnable_sum,
> + sa->runnable_avg * MIN_DIVIDER);
Maybe add a:
Fixes: 1c35b07e6d39 ("sched/fair: Ensure _sum and _avg values stay
consistent")
[...]
> @@ -3805,7 +3807,10 @@ static void detach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *s
> cfs_rq->avg.util_avg * MIN_DIVIDER);
>
> sub_positive(&cfs_rq->avg.runnable_avg, se->avg.runnable_avg);
> - cfs_rq->avg.runnable_sum = cfs_rq->avg.runnable_avg * divider;
> + sub_positive(&cfs_rq->avg.runnable_sum, se->avg.runnable_sum);
> + /* See update_tg_cfs_util() */
> + cfs_rq->avg.runnable_sum = max_t(u32, cfs_rq->avg.runnable_sum,
> + cfs_rq->avg.runnable_avg * MIN_DIVIDER);
Maybe add a:
Fixes: fcf6631f3736 ("sched/pelt: Ensure that *_sum is always synced
with *_avg")
[...]
next prev parent reply other threads:[~2022-01-04 11:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 9:37 [PATCH v2 0/3] sched/pelt: Don't sync hardly *_sum with *_avg Vincent Guittot
2021-12-22 9:38 ` [PATCH v2 1/3] sched/pelt: Don't sync hardly util_sum with uti_avg Vincent Guittot
2022-01-04 11:47 ` Dietmar Eggemann
2022-01-04 13:42 ` Vincent Guittot
2022-01-05 13:15 ` Dietmar Eggemann
2022-01-05 13:57 ` Vincent Guittot
2022-01-07 11:43 ` Dietmar Eggemann
2022-01-07 15:21 ` Vincent Guittot
2022-01-11 7:54 ` Vincent Guittot
2022-01-11 12:37 ` Dietmar Eggemann
2022-01-04 13:48 ` Vincent Guittot
2021-12-22 9:38 ` [PATCH v2 2/3] sched/pelt: Don't sync hardly runnable_sum with runnable_avg Vincent Guittot
2022-01-04 11:47 ` Dietmar Eggemann [this message]
2021-12-22 9:38 ` [PATCH v2 3/3] sched/pelt: Don't sync hardly load_sum with load_avg Vincent Guittot
2022-01-04 11:47 ` Dietmar Eggemann
2022-01-04 11:46 ` [PATCH v2 0/3] sched/pelt: Don't sync hardly *_sum with *_avg Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32e4f1d7-26b1-802a-665f-f89de61db669@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=odin@uged.al \
--cc=peterz@infradead.org \
--cc=rickyiu@google.com \
--cc=rostedt@goodmis.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.