From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DEBC433F5 for ; Mon, 7 Mar 2022 10:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235391AbiCGKuj (ORCPT ); Mon, 7 Mar 2022 05:50:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241665AbiCGKr6 (ORCPT ); Mon, 7 Mar 2022 05:47:58 -0500 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54D1926AFA; Mon, 7 Mar 2022 02:07:44 -0800 (PST) Received: by mail-ej1-f41.google.com with SMTP id kt27so30814400ejb.0; Mon, 07 Mar 2022 02:07:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G+EB4AFFggnOrILvZ54WrATwjsSqh5U/oFtHwdFDjNI=; b=K9gAwwYl408q54rxkD1td/0UhPqIUuKqcnkmti32Rr8Zkzr9gJcXhh6w0S/Kdx34AD Jn62Y3lq+i/zPAeP4/6hEYfhMQf3Y6vvRcewF31grKVvsUbbQhYurVxAGg9eZqgAZ4jD Gv32MmlMsWN7pG/ktSjsXEFiis3m/Qs7foAKWxl3r5L4hg0q1sGrHdRxX1B9WX9oZ06O ChL8PRujG2+5Lzfiefi2Wo/nHwh5F9vPjjwh0RGBM5RgYdko0tln6tJlu/9b+Lurm5bk bCrgTFyOSjb3ojVrzcpCWVMzyNnvBA9EnP2cmvcXnVjNrTxi5d0pf/ewtDYkAUGE0vRF 7EbQ== X-Gm-Message-State: AOAM531be3so1qG4lzYrukpUBw/6Mk0MirEoEoTuLDXRwQFNOT+MKyYg WgdJ5fM7UBIxSdeTHpXg5lKA2qE+/w4= X-Google-Smtp-Source: ABdhPJxHr9JJBLHk0ehHjtgsScZD3zqslWKk6tyAugnkbdNvtf7SfIi6l8BrB33uqcUBr3UUUQh4Cw== X-Received: by 2002:a17:906:314b:b0:6d6:da31:e545 with SMTP id e11-20020a170906314b00b006d6da31e545mr8769492eje.125.1646647626072; Mon, 07 Mar 2022 02:07:06 -0800 (PST) Received: from [192.168.0.141] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id lw3-20020a170906bcc300b006db3e2aa7c9sm254733ejb.171.2022.03.07.02.07.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 02:07:05 -0800 (PST) Message-ID: <32e72657-a43d-0ae1-1bf2-d15b7426765f@kernel.org> Date: Mon, 7 Mar 2022 11:07:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 4/4] usb: host: add xhci-exynos module Content-Language: en-US To: Daehwan Jung , Mathias Nyman , Greg Kroah-Hartman , Randy Dunlap Cc: "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , "chihhao . chen" , sc.suh@samsung.com, cpgs@samsung.com, cpgsproxy5@samsung.com References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com> <1027007693.21646375582736.JavaMail.epsvc@epcpadp4> From: Krzysztof Kozlowski In-Reply-To: <1027007693.21646375582736.JavaMail.epsvc@epcpadp4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2022 07:23, Daehwan Jung wrote: > Signed-off-by: Daehwan Jung +Cc Randy, I guess here is the rest of the patches. > --- > drivers/usb/host/xhci-exynos.c | 2025 ++++++++++++++++++++++++++++++++ > drivers/usb/host/xhci-exynos.h | 150 +++ > 2 files changed, 2175 insertions(+) > create mode 100644 drivers/usb/host/xhci-exynos.c > create mode 100644 drivers/usb/host/xhci-exynos.h > > diff --git a/drivers/usb/host/xhci-exynos.c b/drivers/usb/host/xhci-exynos.c > new file mode 100644 > index 000000000000..3913c48d4b20 > --- /dev/null > +++ b/drivers/usb/host/xhci-exynos.c > @@ -0,0 +1,2025 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * xhci-exynos.c - xHCI host controller driver platform Bus Glue for Exynos. > + * > + * Copyright (C) 2022 Samsung Electronics Incorporated - http://www.samsung.com > + * Author: Daehwan Jung > + * > + * A lot of code borrowed from the Linux xHCI driver. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#ifdef CONFIG_SND_EXYNOS_USB_AUDIO This does not exist. Please do not add dead code to Linux kernel. > +#include "../../../sound/usb/exynos_usb_audio.h" > +#include > +#include "xhci-trace.h" > +#endif > + > +#include "../core/hub.h" > +#include "../core/phy.h" > +#include "xhci.h" > +#include "xhci-plat.h" > +#include "xhci-mvebu.h" > +#include "xhci-rcar.h" > +#include "../dwc3/dwc3-exynos.h" > +#include "../dwc3/exynos-otg.h" No, how XHCI is related to dwc3? What if different block provides XHCI, not DWC3? > +#include "xhci-exynos.h" > +#include This does not exist and does not even compile. Please do not send code which does not compile... Also, just in case - do not send code which compiles but does not work. :) Best regards, Krzysztof