[kvm-unit-tests PATCH 0/3] s390x: SPDX and header comment fixes

[kvm-unit-tests PATCH 0/3] s390x: SPDX and header comment fixes

[Janosch Frank]

Since the snippet support was included right before my vacation I
forgot to add proper SPDX statements and header comments to a few
files.

And while I'm at it I'll also fix my mail address in the author lists.

Janosch Frank (3):
  s390x: Add SPDX and header comments for s390x/* and lib/s390x/*
  s390x: Add SPDX and header comments for the snippets folder
  s390x: Fix my mail address in the headers

 lib/s390x/asm/mem.h             |  2 +-
 lib/s390x/mmu.h                 |  2 +-
 lib/s390x/stack.c               |  2 +-
 lib/s390x/uv.c                  |  9 +++++++++
 s390x/gs.c                      |  2 +-
 s390x/iep.c                     |  2 +-
 s390x/mvpg-sie.c                |  9 +++++++++
 s390x/sie.c                     | 10 ++++++++++
 s390x/snippets/c/cstart.S       |  9 +++++++++
 s390x/snippets/c/mvpg-snippet.c |  9 +++++++++
 s390x/vector.c                  |  2 +-
 x86/sieve.c                     |  5 +++++
 12 files changed, 57 insertions(+), 6 deletions(-)

-- 
2.30.2

[kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Janosch Frank]

Seems like I missed adding them.

The s390x/sieve.c one is a bit of a head scratcher since it came with
the first commit but I assume it's lpgl2-only since that's what the
COPYRIGHT file said then.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 lib/s390x/uv.c   |  9 +++++++++
 s390x/mvpg-sie.c |  9 +++++++++
 s390x/sie.c      | 10 ++++++++++
 x86/sieve.c      |  5 +++++
 4 files changed, 33 insertions(+)

diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
index 0d8c141c..fd9de944 100644
--- a/lib/s390x/uv.c
+++ b/lib/s390x/uv.c
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Ultravisor related functionality
+ *
+ * Copyright 2020 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <bitops.h>
 #include <alloc.h>
diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
index 9bcd15a2..5e70f591 100644
--- a/s390x/mvpg-sie.c
+++ b/s390x/mvpg-sie.c
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Tests mvpg SIE partial execution intercepts.
+ *
+ * Copyright 2021 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <asm/asm-offsets.h>
 #include <asm-generic/barrier.h>
diff --git a/s390x/sie.c b/s390x/sie.c
index cfc746f3..134d3c4f 100644
--- a/s390x/sie.c
+++ b/s390x/sie.c
@@ -1,3 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Tests SIE diagnose intercepts.
+ * Mainly used as a template for SIE tests.
+ *
+ * Copyright 2021 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <asm/asm-offsets.h>
 #include <asm/arch_def.h>
diff --git a/x86/sieve.c b/x86/sieve.c
index 8150f2d9..b89d5f80 100644
--- a/x86/sieve.c
+++ b/x86/sieve.c
@@ -1,3 +1,8 @@
+/* SPDX-License-Identifier: LGPL-2.0-only */
+/*
+ * Implementation of the sieve of Eratosthenes
+ * Calculation and memory intensive workload for general stress testing.
+ */
 #include "alloc.h"
 #include "libcflat.h"
 
-- 
2.30.2

[kvm-unit-tests PATCH 2/3] s390x: Add SPDX and header comments for the snippets folder

[Janosch Frank]

Seems like I missed adding them.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 s390x/snippets/c/cstart.S       | 9 +++++++++
 s390x/snippets/c/mvpg-snippet.c | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/s390x/snippets/c/cstart.S b/s390x/snippets/c/cstart.S
index 242568d6..a1754808 100644
--- a/s390x/snippets/c/cstart.S
+++ b/s390x/snippets/c/cstart.S
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Start assembly for snippets
+ *
+ * Copyright (c) 2021 IBM Corp.
+ *
+ * Authors:
+ *  Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <asm/sigp.h>
 
 .section .init
diff --git a/s390x/snippets/c/mvpg-snippet.c b/s390x/snippets/c/mvpg-snippet.c
index c1eb5d77..e55caab4 100644
--- a/s390x/snippets/c/mvpg-snippet.c
+++ b/s390x/snippets/c/mvpg-snippet.c
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Snippet used by the mvpg-sie.c test to check SIE PEI intercepts.
+ *
+ * Copyright (c) 2021 IBM Corp
+ *
+ * Authors:
+ *  Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 
 static inline void force_exit(void)
-- 
2.30.2

[kvm-unit-tests PATCH 3/3] s390x: Fix my mail address in the headers

[Janosch Frank]

I used the wrong one once and then copied it over...

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 lib/s390x/asm/mem.h | 2 +-
 lib/s390x/mmu.h     | 2 +-
 lib/s390x/stack.c   | 2 +-
 s390x/gs.c          | 2 +-
 s390x/iep.c         | 2 +-
 s390x/vector.c      | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
index 1963cef7..40b22b63 100644
--- a/lib/s390x/asm/mem.h
+++ b/lib/s390x/asm/mem.h
@@ -3,7 +3,7 @@
  * Physical memory management related functions and definitions.
  *
  * Copyright IBM Corp. 2018
- * Author(s): Janosch Frank <frankja@de.ibm.com>
+ * Author(s): Janosch Frank <frankja@linux.ibm.com>
  */
 #ifndef _ASMS390X_MEM_H_
 #define _ASMS390X_MEM_H_
diff --git a/lib/s390x/mmu.h b/lib/s390x/mmu.h
index ab35d782..15f88e4f 100644
--- a/lib/s390x/mmu.h
+++ b/lib/s390x/mmu.h
@@ -5,7 +5,7 @@
  * Copyright (c) 2018 IBM Corp
  *
  * Authors:
- *	Janosch Frank <frankja@de.ibm.com>
+ *	Janosch Frank <frankja@linux.ibm.com>
  */
 #ifndef _S390X_MMU_H_
 #define _S390X_MMU_H_
diff --git a/lib/s390x/stack.c b/lib/s390x/stack.c
index 4cf80dae..e714e07c 100644
--- a/lib/s390x/stack.c
+++ b/lib/s390x/stack.c
@@ -8,7 +8,7 @@
  * Authors:
  *  Thomas Huth <thuth@redhat.com>
  *  David Hildenbrand <david@redhat.com>
- *  Janosch Frank <frankja@de.ibm.com>
+ *  Janosch Frank <frankja@linux.ibm.com>
  */
 #include <libcflat.h>
 #include <stack.h>
diff --git a/s390x/gs.c b/s390x/gs.c
index a017a97d..7567bb78 100644
--- a/s390x/gs.c
+++ b/s390x/gs.c
@@ -6,7 +6,7 @@
  *
  * Authors:
  *    Martin Schwidefsky <schwidefsky@de.ibm.com>
- *    Janosch Frank <frankja@de.ibm.com>
+ *    Janosch Frank <frankja@linux.ibm.com>
  */
 #include <libcflat.h>
 #include <asm/page.h>
diff --git a/s390x/iep.c b/s390x/iep.c
index 906c77b3..8d5e044b 100644
--- a/s390x/iep.c
+++ b/s390x/iep.c
@@ -5,7 +5,7 @@
  * Copyright (c) 2018 IBM Corp
  *
  * Authors:
- *	Janosch Frank <frankja@de.ibm.com>
+ *	Janosch Frank <frankja@linux.ibm.com>
  */
 #include <libcflat.h>
 #include <vmalloc.h>
diff --git a/s390x/vector.c b/s390x/vector.c
index fdb0eee2..c8c14e33 100644
--- a/s390x/vector.c
+++ b/s390x/vector.c
@@ -5,7 +5,7 @@
  * Copyright 2018 IBM Corp.
  *
  * Authors:
- *    Janosch Frank <frankja@de.ibm.com>
+ *    Janosch Frank <frankja@linux.ibm.com>
  */
 #include <libcflat.h>
 #include <asm/page.h>
-- 
2.30.2

Re: [kvm-unit-tests PATCH 3/3] s390x: Fix my mail address in the headers

[Claudio Imbrenda]

On Wed, 28 Jul 2021 10:13:28 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> I used the wrong one once and then copied it over...
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  lib/s390x/asm/mem.h | 2 +-
>  lib/s390x/mmu.h     | 2 +-
>  lib/s390x/stack.c   | 2 +-
>  s390x/gs.c          | 2 +-
>  s390x/iep.c         | 2 +-
>  s390x/vector.c      | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
> index 1963cef7..40b22b63 100644
> --- a/lib/s390x/asm/mem.h
> +++ b/lib/s390x/asm/mem.h
> @@ -3,7 +3,7 @@
>   * Physical memory management related functions and definitions.
>   *
>   * Copyright IBM Corp. 2018
> - * Author(s): Janosch Frank <frankja@de.ibm.com>
> + * Author(s): Janosch Frank <frankja@linux.ibm.com>
>   */
>  #ifndef _ASMS390X_MEM_H_
>  #define _ASMS390X_MEM_H_
> diff --git a/lib/s390x/mmu.h b/lib/s390x/mmu.h
> index ab35d782..15f88e4f 100644
> --- a/lib/s390x/mmu.h
> +++ b/lib/s390x/mmu.h
> @@ -5,7 +5,7 @@
>   * Copyright (c) 2018 IBM Corp
>   *
>   * Authors:
> - *	Janosch Frank <frankja@de.ibm.com>
> + *	Janosch Frank <frankja@linux.ibm.com>
>   */
>  #ifndef _S390X_MMU_H_
>  #define _S390X_MMU_H_
> diff --git a/lib/s390x/stack.c b/lib/s390x/stack.c
> index 4cf80dae..e714e07c 100644
> --- a/lib/s390x/stack.c
> +++ b/lib/s390x/stack.c
> @@ -8,7 +8,7 @@
>   * Authors:
>   *  Thomas Huth <thuth@redhat.com>
>   *  David Hildenbrand <david@redhat.com>
> - *  Janosch Frank <frankja@de.ibm.com>
> + *  Janosch Frank <frankja@linux.ibm.com>
>   */
>  #include <libcflat.h>
>  #include <stack.h>
> diff --git a/s390x/gs.c b/s390x/gs.c
> index a017a97d..7567bb78 100644
> --- a/s390x/gs.c
> +++ b/s390x/gs.c
> @@ -6,7 +6,7 @@
>   *
>   * Authors:
>   *    Martin Schwidefsky <schwidefsky@de.ibm.com>
> - *    Janosch Frank <frankja@de.ibm.com>
> + *    Janosch Frank <frankja@linux.ibm.com>
>   */
>  #include <libcflat.h>
>  #include <asm/page.h>
> diff --git a/s390x/iep.c b/s390x/iep.c
> index 906c77b3..8d5e044b 100644
> --- a/s390x/iep.c
> +++ b/s390x/iep.c
> @@ -5,7 +5,7 @@
>   * Copyright (c) 2018 IBM Corp
>   *
>   * Authors:
> - *	Janosch Frank <frankja@de.ibm.com>
> + *	Janosch Frank <frankja@linux.ibm.com>
>   */
>  #include <libcflat.h>
>  #include <vmalloc.h>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index fdb0eee2..c8c14e33 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -5,7 +5,7 @@
>   * Copyright 2018 IBM Corp.
>   *
>   * Authors:
> - *    Janosch Frank <frankja@de.ibm.com>
> + *    Janosch Frank <frankja@linux.ibm.com>
>   */
>  #include <libcflat.h>
>  #include <asm/page.h>

Re: [kvm-unit-tests PATCH 2/3] s390x: Add SPDX and header comments for the snippets folder

[Claudio Imbrenda]

On Wed, 28 Jul 2021 10:13:27 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Seems like I missed adding them.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  s390x/snippets/c/cstart.S       | 9 +++++++++
>  s390x/snippets/c/mvpg-snippet.c | 9 +++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/s390x/snippets/c/cstart.S b/s390x/snippets/c/cstart.S
> index 242568d6..a1754808 100644
> --- a/s390x/snippets/c/cstart.S
> +++ b/s390x/snippets/c/cstart.S
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Start assembly for snippets
> + *
> + * Copyright (c) 2021 IBM Corp.
> + *
> + * Authors:
> + *  Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <asm/sigp.h>
>  
>  .section .init
> diff --git a/s390x/snippets/c/mvpg-snippet.c
> b/s390x/snippets/c/mvpg-snippet.c index c1eb5d77..e55caab4 100644
> --- a/s390x/snippets/c/mvpg-snippet.c
> +++ b/s390x/snippets/c/mvpg-snippet.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Snippet used by the mvpg-sie.c test to check SIE PEI intercepts.
> + *
> + * Copyright (c) 2021 IBM Corp
> + *
> + * Authors:
> + *  Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  
>  static inline void force_exit(void)

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Claudio Imbrenda]

On Wed, 28 Jul 2021 10:13:26 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Seems like I missed adding them.
> 
> The s390x/sieve.c one is a bit of a head scratcher since it came with
> the first commit but I assume it's lpgl2-only since that's what the
> COPYRIGHT file said then.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>  lib/s390x/uv.c   |  9 +++++++++
>  s390x/mvpg-sie.c |  9 +++++++++
>  s390x/sie.c      | 10 ++++++++++
>  x86/sieve.c      |  5 +++++
>  4 files changed, 33 insertions(+)
> 
> diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
> index 0d8c141c..fd9de944 100644
> --- a/lib/s390x/uv.c
> +++ b/lib/s390x/uv.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Ultravisor related functionality
> + *
> + * Copyright 2020 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <bitops.h>
>  #include <alloc.h>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index 9bcd15a2..5e70f591 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests mvpg SIE partial execution intercepts.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm-generic/barrier.h>
> diff --git a/s390x/sie.c b/s390x/sie.c
> index cfc746f3..134d3c4f 100644
> --- a/s390x/sie.c
> +++ b/s390x/sie.c
> @@ -1,3 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests SIE diagnose intercepts.
> + * Mainly used as a template for SIE tests.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/arch_def.h>
> diff --git a/x86/sieve.c b/x86/sieve.c
> index 8150f2d9..b89d5f80 100644
> --- a/x86/sieve.c
> +++ b/x86/sieve.c
> @@ -1,3 +1,8 @@
> +/* SPDX-License-Identifier: LGPL-2.0-only */

do you really need to fix something in the x86 directory? (even though
it is also used on other archs)

maybe you can split out this as a separate patch, so s390x stuff is
more self contained, and others can then discuss the sieve.c patch
separately if needed?

> +/*
> + * Implementation of the sieve of Eratosthenes
> + * Calculation and memory intensive workload for general stress
> testing.
> + */
>  #include "alloc.h"
>  #include "libcflat.h"
>  

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Thomas Huth]

On 28/07/2021 12.13, Janosch Frank wrote:
> Seems like I missed adding them.
> 
> The s390x/sieve.c one is a bit of a head scratcher since it came with
> the first commit but I assume it's lpgl2-only since that's what the
> COPYRIGHT file said then.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>   lib/s390x/uv.c   |  9 +++++++++
>   s390x/mvpg-sie.c |  9 +++++++++
>   s390x/sie.c      | 10 ++++++++++
>   x86/sieve.c      |  5 +++++
>   4 files changed, 33 insertions(+)
> 
> diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
> index 0d8c141c..fd9de944 100644
> --- a/lib/s390x/uv.c
> +++ b/lib/s390x/uv.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Ultravisor related functionality
> + *
> + * Copyright 2020 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>   #include <libcflat.h>
>   #include <bitops.h>
>   #include <alloc.h>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index 9bcd15a2..5e70f591 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests mvpg SIE partial execution intercepts.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>   #include <libcflat.h>
>   #include <asm/asm-offsets.h>
>   #include <asm-generic/barrier.h>
> diff --git a/s390x/sie.c b/s390x/sie.c
> index cfc746f3..134d3c4f 100644
> --- a/s390x/sie.c
> +++ b/s390x/sie.c
> @@ -1,3 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests SIE diagnose intercepts.
> + * Mainly used as a template for SIE tests.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>   #include <libcflat.h>
>   #include <asm/asm-offsets.h>
>   #include <asm/arch_def.h>
> diff --git a/x86/sieve.c b/x86/sieve.c
> index 8150f2d9..b89d5f80 100644
> --- a/x86/sieve.c
> +++ b/x86/sieve.c
> @@ -1,3 +1,8 @@
> +/* SPDX-License-Identifier: LGPL-2.0-only */
> +/*
> + * Implementation of the sieve of Eratosthenes
> + * Calculation and memory intensive workload for general stress testing.
> + */
>   #include "alloc.h"
>   #include "libcflat.h"
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [kvm-unit-tests PATCH 2/3] s390x: Add SPDX and header comments for the snippets folder

[Thomas Huth]

On 28/07/2021 12.13, Janosch Frank wrote:
> Seems like I missed adding them.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>   s390x/snippets/c/cstart.S       | 9 +++++++++
>   s390x/snippets/c/mvpg-snippet.c | 9 +++++++++
>   2 files changed, 18 insertions(+)
> 
> diff --git a/s390x/snippets/c/cstart.S b/s390x/snippets/c/cstart.S
> index 242568d6..a1754808 100644
> --- a/s390x/snippets/c/cstart.S
> +++ b/s390x/snippets/c/cstart.S
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Start assembly for snippets
> + *
> + * Copyright (c) 2021 IBM Corp.
> + *
> + * Authors:
> + *  Janosch Frank <frankja@linux.ibm.com>
> + */
>   #include <asm/sigp.h>
>   
>   .section .init
> diff --git a/s390x/snippets/c/mvpg-snippet.c b/s390x/snippets/c/mvpg-snippet.c
> index c1eb5d77..e55caab4 100644
> --- a/s390x/snippets/c/mvpg-snippet.c
> +++ b/s390x/snippets/c/mvpg-snippet.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Snippet used by the mvpg-sie.c test to check SIE PEI intercepts.
> + *
> + * Copyright (c) 2021 IBM Corp
> + *
> + * Authors:
> + *  Janosch Frank <frankja@linux.ibm.com>
> + */
>   #include <libcflat.h>
>   
>   static inline void force_exit(void)
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [kvm-unit-tests PATCH 3/3] s390x: Fix my mail address in the headers

[Thomas Huth]

On 28/07/2021 12.13, Janosch Frank wrote:
> I used the wrong one once and then copied it over...
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>   lib/s390x/asm/mem.h | 2 +-
>   lib/s390x/mmu.h     | 2 +-
>   lib/s390x/stack.c   | 2 +-
>   s390x/gs.c          | 2 +-
>   s390x/iep.c         | 2 +-
>   s390x/vector.c      | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
> index 1963cef7..40b22b63 100644
> --- a/lib/s390x/asm/mem.h
> +++ b/lib/s390x/asm/mem.h
> @@ -3,7 +3,7 @@
>    * Physical memory management related functions and definitions.
>    *
>    * Copyright IBM Corp. 2018
> - * Author(s): Janosch Frank <frankja@de.ibm.com>
> + * Author(s): Janosch Frank <frankja@linux.ibm.com>
>    */
>   #ifndef _ASMS390X_MEM_H_
>   #define _ASMS390X_MEM_H_
> diff --git a/lib/s390x/mmu.h b/lib/s390x/mmu.h
> index ab35d782..15f88e4f 100644
> --- a/lib/s390x/mmu.h
> +++ b/lib/s390x/mmu.h
> @@ -5,7 +5,7 @@
>    * Copyright (c) 2018 IBM Corp
>    *
>    * Authors:
> - *	Janosch Frank <frankja@de.ibm.com>
> + *	Janosch Frank <frankja@linux.ibm.com>
>    */
>   #ifndef _S390X_MMU_H_
>   #define _S390X_MMU_H_
> diff --git a/lib/s390x/stack.c b/lib/s390x/stack.c
> index 4cf80dae..e714e07c 100644
> --- a/lib/s390x/stack.c
> +++ b/lib/s390x/stack.c
> @@ -8,7 +8,7 @@
>    * Authors:
>    *  Thomas Huth <thuth@redhat.com>
>    *  David Hildenbrand <david@redhat.com>
> - *  Janosch Frank <frankja@de.ibm.com>
> + *  Janosch Frank <frankja@linux.ibm.com>
>    */
>   #include <libcflat.h>
>   #include <stack.h>
> diff --git a/s390x/gs.c b/s390x/gs.c
> index a017a97d..7567bb78 100644
> --- a/s390x/gs.c
> +++ b/s390x/gs.c
> @@ -6,7 +6,7 @@
>    *
>    * Authors:
>    *    Martin Schwidefsky <schwidefsky@de.ibm.com>
> - *    Janosch Frank <frankja@de.ibm.com>
> + *    Janosch Frank <frankja@linux.ibm.com>
>    */
>   #include <libcflat.h>
>   #include <asm/page.h>
> diff --git a/s390x/iep.c b/s390x/iep.c
> index 906c77b3..8d5e044b 100644
> --- a/s390x/iep.c
> +++ b/s390x/iep.c
> @@ -5,7 +5,7 @@
>    * Copyright (c) 2018 IBM Corp
>    *
>    * Authors:
> - *	Janosch Frank <frankja@de.ibm.com>
> + *	Janosch Frank <frankja@linux.ibm.com>
>    */
>   #include <libcflat.h>
>   #include <vmalloc.h>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index fdb0eee2..c8c14e33 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -5,7 +5,7 @@
>    * Copyright 2018 IBM Corp.
>    *
>    * Authors:
> - *    Janosch Frank <frankja@de.ibm.com>
> + *    Janosch Frank <frankja@linux.ibm.com>
>    */
>   #include <libcflat.h>
>   #include <asm/page.h>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Thomas Huth]

On 28/07/2021 12.32, Claudio Imbrenda wrote:
> On Wed, 28 Jul 2021 10:13:26 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> Seems like I missed adding them.
>>
>> The s390x/sieve.c one is a bit of a head scratcher since it came with
>> the first commit but I assume it's lpgl2-only since that's what the
>> COPYRIGHT file said then.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>>   lib/s390x/uv.c   |  9 +++++++++
>>   s390x/mvpg-sie.c |  9 +++++++++
>>   s390x/sie.c      | 10 ++++++++++
>>   x86/sieve.c      |  5 +++++
>>   4 files changed, 33 insertions(+)
[...]
>> diff --git a/x86/sieve.c b/x86/sieve.c
>> index 8150f2d9..b89d5f80 100644
>> --- a/x86/sieve.c
>> +++ b/x86/sieve.c
>> @@ -1,3 +1,8 @@
>> +/* SPDX-License-Identifier: LGPL-2.0-only */
> 
> do you really need to fix something in the x86 directory? (even though
> it is also used on other archs)

I just realized that s390x/sieve.c is just a symlink, not a copy of the file :-)

> maybe you can split out this as a separate patch, so s390x stuff is
> more self contained, and others can then discuss the sieve.c patch
> separately if needed?

That might make sense, indeed.

  Thomas

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Janosch Frank]

On 7/28/21 12:36 PM, Thomas Huth wrote:
> On 28/07/2021 12.32, Claudio Imbrenda wrote:
>> On Wed, 28 Jul 2021 10:13:26 +0000
>> Janosch Frank <frankja@linux.ibm.com> wrote:
>>
>>> Seems like I missed adding them.
>>>
>>> The s390x/sieve.c one is a bit of a head scratcher since it came with
>>> the first commit but I assume it's lpgl2-only since that's what the
>>> COPYRIGHT file said then.
>>>
>>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>>> ---
>>>   lib/s390x/uv.c   |  9 +++++++++
>>>   s390x/mvpg-sie.c |  9 +++++++++
>>>   s390x/sie.c      | 10 ++++++++++
>>>   x86/sieve.c      |  5 +++++
>>>   4 files changed, 33 insertions(+)
> [...]
>>> diff --git a/x86/sieve.c b/x86/sieve.c
>>> index 8150f2d9..b89d5f80 100644
>>> --- a/x86/sieve.c
>>> +++ b/x86/sieve.c
>>> @@ -1,3 +1,8 @@
>>> +/* SPDX-License-Identifier: LGPL-2.0-only */
>>
>> do you really need to fix something in the x86 directory? (even though
>> it is also used on other archs)
> 
> I just realized that s390x/sieve.c is just a symlink, not a copy of the file :-)

You're not the only one...

> 
>> maybe you can split out this as a separate patch, so s390x stuff is
>> more self contained, and others can then discuss the sieve.c patch
>> separately if needed?
> 
> That might make sense, indeed.

Yup will do

> 
>   Thomas
> 

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Janosch Frank]

On 7/28/21 1:36 PM, Janosch Frank wrote:
> On 7/28/21 12:36 PM, Thomas Huth wrote:
>> On 28/07/2021 12.32, Claudio Imbrenda wrote:
>>> On Wed, 28 Jul 2021 10:13:26 +0000
>>> Janosch Frank <frankja@linux.ibm.com> wrote:
>>>
>>>> Seems like I missed adding them.
>>>>
>>>> The s390x/sieve.c one is a bit of a head scratcher since it came with
>>>> the first commit but I assume it's lpgl2-only since that's what the
>>>> COPYRIGHT file said then.
>>>>
>>>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>>>> ---
>>>>   lib/s390x/uv.c   |  9 +++++++++
>>>>   s390x/mvpg-sie.c |  9 +++++++++
>>>>   s390x/sie.c      | 10 ++++++++++
>>>>   x86/sieve.c      |  5 +++++
>>>>   4 files changed, 33 insertions(+)
>> [...]
>>>> diff --git a/x86/sieve.c b/x86/sieve.c
>>>> index 8150f2d9..b89d5f80 100644
>>>> --- a/x86/sieve.c
>>>> +++ b/x86/sieve.c
>>>> @@ -1,3 +1,8 @@
>>>> +/* SPDX-License-Identifier: LGPL-2.0-only */
>>>
>>> do you really need to fix something in the x86 directory? (even though
>>> it is also used on other archs)
>>
>> I just realized that s390x/sieve.c is just a symlink, not a copy of the file :-)
> 
> You're not the only one...
> 
>>
>>> maybe you can split out this as a separate patch, so s390x stuff is
>>> more self contained, and others can then discuss the sieve.c patch
>>> separately if needed?
>>
>> That might make sense, indeed.
> 
> Yup will do

On second thought I'm just gonna drop that hunk since x86 doesn't really
have SPDX or header comments for most of their files anyway.

> 
>>
>>   Thomas
>>
> 

Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Thomas Huth]

On 28/07/2021 13.41, Janosch Frank wrote:
> On 7/28/21 1:36 PM, Janosch Frank wrote:
>> On 7/28/21 12:36 PM, Thomas Huth wrote:
>>> On 28/07/2021 12.32, Claudio Imbrenda wrote:
>>>> On Wed, 28 Jul 2021 10:13:26 +0000
>>>> Janosch Frank <frankja@linux.ibm.com> wrote:
>>>>
>>>>> Seems like I missed adding them.
>>>>>
>>>>> The s390x/sieve.c one is a bit of a head scratcher since it came with
>>>>> the first commit but I assume it's lpgl2-only since that's what the
>>>>> COPYRIGHT file said then.
>>>>>
>>>>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>>>>> ---
>>>>>    lib/s390x/uv.c   |  9 +++++++++
>>>>>    s390x/mvpg-sie.c |  9 +++++++++
>>>>>    s390x/sie.c      | 10 ++++++++++
>>>>>    x86/sieve.c      |  5 +++++
>>>>>    4 files changed, 33 insertions(+)
>>> [...]
>>>>> diff --git a/x86/sieve.c b/x86/sieve.c
>>>>> index 8150f2d9..b89d5f80 100644
>>>>> --- a/x86/sieve.c
>>>>> +++ b/x86/sieve.c
>>>>> @@ -1,3 +1,8 @@
>>>>> +/* SPDX-License-Identifier: LGPL-2.0-only */
>>>>
>>>> do you really need to fix something in the x86 directory? (even though
>>>> it is also used on other archs)
>>>
>>> I just realized that s390x/sieve.c is just a symlink, not a copy of the file :-)
>>
>> You're not the only one...
>>
>>>
>>>> maybe you can split out this as a separate patch, so s390x stuff is
>>>> more self contained, and others can then discuss the sieve.c patch
>>>> separately if needed?
>>>
>>> That might make sense, indeed.
>>
>> Yup will do
> 
> On second thought I'm just gonna drop that hunk since x86 doesn't really
> have SPDX or header comments for most of their files anyway.

That's fine, too. We can still add them there later.

  Thomas

[kvm-unit-tests PATCH v2] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Janosch Frank]

Seems like I missed adding them.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---

Dropped the sieve.c change.

---
 lib/s390x/uv.c   |  9 +++++++++
 s390x/mvpg-sie.c |  9 +++++++++
 s390x/sie.c      | 10 ++++++++++
 3 files changed, 28 insertions(+)

diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
index 0d8c141c..fd9de944 100644
--- a/lib/s390x/uv.c
+++ b/lib/s390x/uv.c
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Ultravisor related functionality
+ *
+ * Copyright 2020 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <bitops.h>
 #include <alloc.h>
diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
index 9bcd15a2..5e70f591 100644
--- a/s390x/mvpg-sie.c
+++ b/s390x/mvpg-sie.c
@@ -1,3 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Tests mvpg SIE partial execution intercepts.
+ *
+ * Copyright 2021 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <asm/asm-offsets.h>
 #include <asm-generic/barrier.h>
diff --git a/s390x/sie.c b/s390x/sie.c
index cfc746f3..134d3c4f 100644
--- a/s390x/sie.c
+++ b/s390x/sie.c
@@ -1,3 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Tests SIE diagnose intercepts.
+ * Mainly used as a template for SIE tests.
+ *
+ * Copyright 2021 IBM Corp.
+ *
+ * Authors:
+ *    Janosch Frank <frankja@linux.ibm.com>
+ */
 #include <libcflat.h>
 #include <asm/asm-offsets.h>
 #include <asm/arch_def.h>
-- 
2.30.2

Re: [kvm-unit-tests PATCH v2] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Claudio Imbrenda]

On Wed, 28 Jul 2021 12:56:43 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Seems like I missed adding them.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
> 
> Dropped the sieve.c change.
> 
> ---
>  lib/s390x/uv.c   |  9 +++++++++
>  s390x/mvpg-sie.c |  9 +++++++++
>  s390x/sie.c      | 10 ++++++++++
>  3 files changed, 28 insertions(+)
> 
> diff --git a/lib/s390x/uv.c b/lib/s390x/uv.c
> index 0d8c141c..fd9de944 100644
> --- a/lib/s390x/uv.c
> +++ b/lib/s390x/uv.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Ultravisor related functionality
> + *
> + * Copyright 2020 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <bitops.h>
>  #include <alloc.h>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index 9bcd15a2..5e70f591 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -1,3 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests mvpg SIE partial execution intercepts.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm-generic/barrier.h>
> diff --git a/s390x/sie.c b/s390x/sie.c
> index cfc746f3..134d3c4f 100644
> --- a/s390x/sie.c
> +++ b/s390x/sie.c
> @@ -1,3 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Tests SIE diagnose intercepts.
> + * Mainly used as a template for SIE tests.
> + *
> + * Copyright 2021 IBM Corp.
> + *
> + * Authors:
> + *    Janosch Frank <frankja@linux.ibm.com>
> + */
>  #include <libcflat.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/arch_def.h>

Re: [kvm-unit-tests PATCH v2] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Thomas Huth]

On 28/07/2021 14.56, Janosch Frank wrote:
> Seems like I missed adding them.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> 
> Dropped the sieve.c change.
> 
> ---
>   lib/s390x/uv.c   |  9 +++++++++
>   s390x/mvpg-sie.c |  9 +++++++++
>   s390x/sie.c      | 10 ++++++++++
>   3 files changed, 28 insertions(+)

Reviewed-by: Thomas Huth <thuth@redhat.com>