From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754400AbeCWLlm (ORCPT ); Fri, 23 Mar 2018 07:41:42 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:43414 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbeCWKD6 (ORCPT ); Fri, 23 Mar 2018 06:03:58 -0400 Subject: Re: [PATCH 03/19] powerpc: Mark variables as unused To: Mathieu Malaterre , Michael Ellerman Cc: linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org References: <20180322202007.23088-1-malat@debian.org> <20180322202007.23088-4-malat@debian.org> From: christophe leroy Message-ID: <32ecbb82-cecc-732c-cc57-cf7e36dc1965@c-s.fr> Date: Fri, 23 Mar 2018 11:03:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322202007.23088-4-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : > Add gcc attribute unused for two variables. Fix warnings treated as errors > with W=1: > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not used [-Werror=unused-but-set-variable] > > Signed-off-by: Mathieu Malaterre > --- > arch/powerpc/kernel/prom_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c > index acf4b2e0530c..6a3ac4522144 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -603,7 +603,7 @@ static void __init early_cmdline_parse(void) > const char *opt; > > char *p; > - int l = 0; > + int l __maybe_unused = 0; > > prom_cmd_line[0] = 0; > p = prom_cmd_line; > @@ -1385,7 +1385,7 @@ static void __init reserve_mem(u64 base, u64 size) > static void __init prom_init_mem(void) > { > phandle node; > - char *path, type[64]; > + char *path __maybe_unused, type[64]; path is only used if DEBUG_PROM is defined, so it should be enclosed into #ifdef DEBUG_PROM Christophe > unsigned int plen; > cell_t *p, *endp; > __be32 val; > --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus From mboxrd@z Thu Jan 1 00:00:00 1970 From: christophe leroy Date: Fri, 23 Mar 2018 10:03:50 +0000 Subject: Re: [PATCH 03/19] powerpc: Mark variables as unused Message-Id: <32ecbb82-cecc-732c-cc57-cf7e36dc1965@c-s.fr> List-Id: References: <20180322202007.23088-1-malat@debian.org> <20180322202007.23088-4-malat@debian.org> In-Reply-To: <20180322202007.23088-4-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Mathieu Malaterre , Michael Ellerman Cc: linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : > Add gcc attribute unused for two variables. Fix warnings treated as errors > with W=1: > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not used [-Werror=unused-but-set-variable] > > Signed-off-by: Mathieu Malaterre > --- > arch/powerpc/kernel/prom_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c > index acf4b2e0530c..6a3ac4522144 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -603,7 +603,7 @@ static void __init early_cmdline_parse(void) > const char *opt; > > char *p; > - int l = 0; > + int l __maybe_unused = 0; > > prom_cmd_line[0] = 0; > p = prom_cmd_line; > @@ -1385,7 +1385,7 @@ static void __init reserve_mem(u64 base, u64 size) > static void __init prom_init_mem(void) > { > phandle node; > - char *path, type[64]; > + char *path __maybe_unused, type[64]; path is only used if DEBUG_PROM is defined, so it should be enclosed into #ifdef DEBUG_PROM Christophe > unsigned int plen; > cell_t *p, *endp; > __be32 val; > --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus