From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54C2C2B9F4 for ; Thu, 17 Jun 2021 20:51:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8842D613CE for ; Thu, 17 Jun 2021 20:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232484AbhFQUxg (ORCPT ); Thu, 17 Jun 2021 16:53:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbhFQUxf (ORCPT ); Thu, 17 Jun 2021 16:53:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DBBDD610A1; Thu, 17 Jun 2021 20:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623963087; bh=0KQKeh6bgDXKLLGwLRbNVUBv4sRzxd+Azd43XYpTEYM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IaZG7YAL+8RHGZTi0zuz/Zmlj3ZP7YPWLhB5WK9WQBV9LW0iC+Dx3ciTxt/GMjqET iOvOakqmrtE3K+f5M9V/yp2TQJ2TzcksLWz6Kr6rovbEFSeaQUmMvrBVdw7feYyCcY VCZSSQ5SBcSJGvRfOUOZolrSCllyUKTPRno2SMM7zJGM1WDh0h1yYpbpQcsLut3FOu cp5ewr9cvYdV4PtQ22wWvTGmPgjNj9rG5EK04Za8zi97zGGu+uiJP9wH8ljxSb6OtU /RS9GDyZ7z/loLPdLbN7/6Ve2ebKbXu51paKHQDjz6Xfs7OHYlKi4lupESpw9WMuwb 07gUt04PDRpMg== Subject: Re: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c To: Joerg Roedel , Nick Desaulniers Cc: Joerg Roedel , Will Deacon , David Woodhouse , iommu@lists.linux-foundation.org, LKML , clang-built-linux , Lu Baolu , kernel test robot References: <20210617145339.2692-1-joro@8bytes.org> From: Nathan Chancellor Message-ID: <32f14288-315a-b75d-913b-2fc6a16cd748@kernel.org> Date: Thu, 17 Jun 2021 13:51:24 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/2021 1:30 PM, Joerg Roedel wrote: > On Thu, Jun 17, 2021 at 10:16:50AM -0700, Nick Desaulniers wrote: >> On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel wrote: >>> >>> From: Joerg Roedel >>> >>> Fix this warning when compiled with clang and W=1: >>> >>> drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK' >>> drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead >> >> I think these warnings are actually produced by kernel-doc? (not clang) > > Will kernel-doc check automatically when COMPILER=clang is set and W=1? > Because I did not explicitly enable any kernel-doc checks. > > Regards, > > Joerg > kernel-doc is run automatically with W=1, regardless of gcc versus clang. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4772EC2B9F4 for ; Thu, 17 Jun 2021 21:27:16 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5A82611BE for ; Thu, 17 Jun 2021 21:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5A82611BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B1C8E605CC; Thu, 17 Jun 2021 21:27:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XMvn5dy_w2rD; Thu, 17 Jun 2021 21:27:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 97EFE605BB; Thu, 17 Jun 2021 21:27:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 68C3EC000D; Thu, 17 Jun 2021 21:27:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 29963C000B for ; Thu, 17 Jun 2021 20:51:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 036354002B for ; Thu, 17 Jun 2021 20:51:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cF9E87XA1tMm for ; Thu, 17 Jun 2021 20:51:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id 20401405FA for ; Thu, 17 Jun 2021 20:51:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DBBDD610A1; Thu, 17 Jun 2021 20:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623963087; bh=0KQKeh6bgDXKLLGwLRbNVUBv4sRzxd+Azd43XYpTEYM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IaZG7YAL+8RHGZTi0zuz/Zmlj3ZP7YPWLhB5WK9WQBV9LW0iC+Dx3ciTxt/GMjqET iOvOakqmrtE3K+f5M9V/yp2TQJ2TzcksLWz6Kr6rovbEFSeaQUmMvrBVdw7feYyCcY VCZSSQ5SBcSJGvRfOUOZolrSCllyUKTPRno2SMM7zJGM1WDh0h1yYpbpQcsLut3FOu cp5ewr9cvYdV4PtQ22wWvTGmPgjNj9rG5EK04Za8zi97zGGu+uiJP9wH8ljxSb6OtU /RS9GDyZ7z/loLPdLbN7/6Ve2ebKbXu51paKHQDjz6Xfs7OHYlKi4lupESpw9WMuwb 07gUt04PDRpMg== Subject: Re: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c To: Joerg Roedel , Nick Desaulniers References: <20210617145339.2692-1-joro@8bytes.org> From: Nathan Chancellor Message-ID: <32f14288-315a-b75d-913b-2fc6a16cd748@kernel.org> Date: Thu, 17 Jun 2021 13:51:24 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Thu, 17 Jun 2021 21:27:12 +0000 Cc: kernel test robot , Will Deacon , LKML , clang-built-linux , iommu@lists.linux-foundation.org, David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 6/17/2021 1:30 PM, Joerg Roedel wrote: > On Thu, Jun 17, 2021 at 10:16:50AM -0700, Nick Desaulniers wrote: >> On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel wrote: >>> >>> From: Joerg Roedel >>> >>> Fix this warning when compiled with clang and W=1: >>> >>> drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK' >>> drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead >> >> I think these warnings are actually produced by kernel-doc? (not clang) > > Will kernel-doc check automatically when COMPILER=clang is set and W=1? > Because I did not explicitly enable any kernel-doc checks. > > Regards, > > Joerg > kernel-doc is run automatically with W=1, regardless of gcc versus clang. Cheers, Nathan _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu