All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: Don Brace <don.brace@microsemi.com>,
	jejb@linux.vnet.ibm.com, Viswas.G@microsemi.com,
	Mahesh.Rajashekhara@microsemi.com, hch@infradead.org,
	scott.teel@microsemi.com, Kevin.Barnett@microsemi.com,
	Justin.Lindley@microsemi.com, scott.benesh@microsemi.com,
	elliott@hpe.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 04/17] smartpqi: enhance drive offline informational message
Date: Wed, 31 Aug 2016 15:00:38 +0200	[thread overview]
Message-ID: <32f5d95c-daf2-a501-0b6f-2f7d9efbc48f@redhat.com> (raw)
In-Reply-To: <147222987005.31214.15421477679512221805.stgit@brunhilda>

On 26.8.2016 18:44, Don Brace wrote:
> From: Kevin Barnett <kevin.barnett@microsemi.com>
>
> Made a couple of error messages more verbose.
>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
> Signed-off-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

> ---
>  drivers/scsi/smartpqi/smartpqi_init.c |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 9922e31..198a7c2 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -2298,11 +2298,16 @@ static inline void pqi_aio_path_disabled(struct pqi_io_request *io_request)
>  static inline void pqi_take_device_offline(struct scsi_device *sdev)
>  {
>  	struct pqi_ctrl_info *ctrl_info;
> +	struct pqi_scsi_dev *device;
>  
>  	if (scsi_device_online(sdev)) {
>  		scsi_device_set_state(sdev, SDEV_OFFLINE);
>  		ctrl_info = shost_to_hba(sdev->host);
>  		schedule_delayed_work(&ctrl_info->rescan_work, 0);
> +		device = sdev->hostdata;
> +		dev_err(&ctrl_info->pci_dev->dev, "offlined scsi %d:%d:%d:%d\n",
> +			ctrl_info->scsi_host->host_no, device->bus,
> +			device->target, device->lun);
>  	}
>  }
>  
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



  parent reply	other threads:[~2016-08-31 13:00 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 16:44 [PATCH 00/17] smartpqi updates Don Brace
2016-08-26 16:44 ` [PATCH 01/17] smartpqi: change aio sg processing Don Brace
2016-08-29  8:54   ` Johannes Thumshirn
2016-08-29 21:44     ` Don Brace
2016-08-30  7:23       ` Johannes Thumshirn
2016-08-31 12:51   ` Tomas Henzl
2016-08-26 16:44 ` [PATCH 02/17] smartpqi: change tmf macro names Don Brace
2016-08-29  8:55   ` Johannes Thumshirn
2016-08-31 12:52   ` Tomas Henzl
2016-08-26 16:44 ` [PATCH 03/17] smartpqi: simplify spanning Don Brace
2016-08-29  8:57   ` Johannes Thumshirn
2016-08-31 12:59   ` Tomas Henzl
2016-08-31 13:10     ` Johannes Thumshirn
2016-08-31 13:30       ` Tomas Henzl
2016-08-26 16:44 ` [PATCH 04/17] smartpqi: enhance drive offline informational message Don Brace
2016-08-29  8:59   ` Johannes Thumshirn
2016-08-31 13:00   ` Tomas Henzl [this message]
2016-08-26 16:44 ` [PATCH 05/17] smartpqi: enhance reset logic Don Brace
2016-08-29  9:05   ` Johannes Thumshirn
2016-08-31 13:19   ` Tomas Henzl
2016-08-26 16:44 ` [PATCH 06/17] smartpqi: change commonly used function to inline Don Brace
2016-08-29  9:06   ` Johannes Thumshirn
2016-08-29 20:32     ` Don Brace
2016-08-26 16:44 ` [PATCH 07/17] smartpqi: add kdump support Don Brace
2016-08-29  9:11   ` Johannes Thumshirn
2016-08-31 13:41   ` Tomas Henzl
2016-08-26 16:44 ` [PATCH 08/17] smartpqi: correct controller offline issue Don Brace
2016-08-29  9:19   ` Johannes Thumshirn
2016-08-31 14:15   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 09/17] smartpqi: correct event acknowledgment timeout issue Don Brace
2016-08-29  9:28   ` Johannes Thumshirn
2016-08-31 14:43   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 10/17] smartpqi: minor function reformating Don Brace
2016-08-31 14:44   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 11/17] smartpqi: minor tweaks to update time support Don Brace
2016-08-29  9:33   ` Johannes Thumshirn
2016-08-29 20:29     ` Don Brace
2016-08-30  7:17       ` Johannes Thumshirn
2016-08-30 15:26         ` Don Brace
2016-08-31  7:33           ` Johannes Thumshirn
2016-08-26 16:45 ` [PATCH 12/17] smartpqi: scsi queuecommand cleanup Don Brace
2016-08-29  9:35   ` Johannes Thumshirn
2016-08-31 14:46   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 13/17] smartpqi: remove timeout for cache flush operations Don Brace
2016-08-29  9:39   ` Johannes Thumshirn
2016-08-29 21:36     ` Don Brace
2016-08-30  7:13       ` Johannes Thumshirn
2016-08-31 14:47   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 14/17] smartpqi: update Kconfig Don Brace
2016-08-29  9:40   ` Johannes Thumshirn
2016-08-31 14:48   ` Tomas Henzl
2016-08-26 16:45 ` [PATCH 15/17] smartpqi: update maintainers Don Brace
2016-08-29  9:42   ` Johannes Thumshirn
2016-08-29 20:57     ` Don Brace
2016-08-30  7:14       ` Johannes Thumshirn
2016-08-26 16:45 ` [PATCH 16/17] smartpqi: add smartpqi.txt Don Brace
2016-08-29  9:45   ` Johannes Thumshirn
2016-08-26 16:45 ` [PATCH 17/17] smartqi: bump driver version Don Brace
2016-08-29  9:46   ` Johannes Thumshirn
2016-08-31 14:49   ` Tomas Henzl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32f5d95c-daf2-a501-0b6f-2f7d9efbc48f@redhat.com \
    --to=thenzl@redhat.com \
    --cc=Justin.Lindley@microsemi.com \
    --cc=Kevin.Barnett@microsemi.com \
    --cc=Mahesh.Rajashekhara@microsemi.com \
    --cc=Viswas.G@microsemi.com \
    --cc=don.brace@microsemi.com \
    --cc=elliott@hpe.com \
    --cc=hch@infradead.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scott.benesh@microsemi.com \
    --cc=scott.teel@microsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.