From: John Hubbard <jhubbard@nvidia.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
David Hildenbrand <david@redhat.com>
Cc: Peter Xu <peterx@redhat.com>, Shuah Khan <shuah@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>, <linux-mm@kvack.org>,
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 11/12] selftests/mm: fix missing UFFDIO_CONTINUE_MODE_WP and similar build failures
Date: Fri, 2 Jun 2023 15:24:41 -0700 [thread overview]
Message-ID: <3300328e-f977-beb5-f373-d0141ef49cf2@nvidia.com> (raw)
In-Reply-To: <bf910fa5-0c96-3707-cce4-5bcc656b6274@collabora.com>
On 6/2/23 09:25, Muhammad Usama Anjum wrote:
> On 6/2/23 6:33 AM, John Hubbard wrote:
>> UFFDIO_CONTINUE_MODE_WP, UFFD_FEATURE_WP_UNPOPULATED, USERFAULTFD_IOC,
>> and USERFAULTFD_IOC_NEW are needed lately, but they are not in my host
>> (Arch Linux) distro's userfaultfd.h yet. So put them in here.
> Selftests are never supposed to build with native header files. Build the
Ah yes, I remember that now. Of course, the problem is that few people
know or remember that, and it's undocumented as well.
> headers in kernel source first. Then building the selftests picks up these
> newly built headers by itself. The method to build header files has changed
> to `make headers`. The following command builds the mm selftests
> successfully every time for me.
>
> make headers && make -C tools/testing/selftests/mm
>
> Please let me know if this doesn't work for you. I'll try to reproduce and fix.
>
Yes thanks. That's a pointer to a full solution, which needs to:
a) automatically invoke "make headers", at least for selftests/mm for
now, and
b) Add something to perhaps Documentation/dev-tools/kselftest.rst to
document this requirement.
I'll work on that.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2023-06-02 22:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 1:33 [PATCH 00/12] A minor flurry of selftest/mm fixes John Hubbard
2023-06-02 1:33 ` [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning John Hubbard
2023-06-02 9:58 ` David Hildenbrand
2023-06-02 15:25 ` Peter Xu
2023-06-02 1:33 ` [PATCH 02/12] selftests/mm: fix unused variable warning in hugetlb-madvise.c John Hubbard
2023-06-02 10:01 ` David Hildenbrand
2023-06-02 18:38 ` John Hubbard
2023-06-02 1:33 ` [PATCH 03/12] selftests/mm: fix unused variable warning in migration.c John Hubbard
2023-06-02 10:02 ` David Hildenbrand
2023-06-02 18:39 ` John Hubbard
2023-06-02 1:33 ` [PATCH 04/12] selftests/mm: fix a char* assignment in mlock2-tests.c John Hubbard
2023-06-02 10:04 ` David Hildenbrand
2023-06-02 15:24 ` Peter Xu
2023-06-02 18:52 ` John Hubbard
2023-06-05 15:38 ` Peter Xu
2023-06-05 18:45 ` John Hubbard
2023-06-02 1:33 ` [PATCH 05/12] selftests/mm: fix invocation of tests that are run via shell scripts John Hubbard
2023-06-02 10:05 ` David Hildenbrand
2023-06-02 20:38 ` John Hubbard
2023-06-02 15:34 ` Peter Xu
2023-06-02 19:19 ` John Hubbard
2023-06-02 21:36 ` Peter Xu
2023-06-02 21:46 ` John Hubbard
2023-06-02 1:33 ` [PATCH 06/12] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch John Hubbard
2023-06-02 10:06 ` David Hildenbrand
2023-06-02 1:33 ` [PATCH 07/12] selftests/mm: set -Wno-format-security to avoid uffd build warnings John Hubbard
2023-06-02 10:15 ` David Hildenbrand
2023-06-02 21:22 ` John Hubbard
2023-06-02 1:33 ` [PATCH 08/12] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h John Hubbard
2023-06-02 10:16 ` David Hildenbrand
2023-06-02 1:33 ` [PATCH 09/12] selftests/mm: move psize(), pshift() into vm_utils.c John Hubbard
2023-06-02 10:19 ` David Hildenbrand
2023-06-02 21:58 ` John Hubbard
2023-06-02 1:33 ` [PATCH 10/12] selftests/mm: move uffd* routines from vm_util.c to uffd-common.c John Hubbard
2023-06-02 15:59 ` Peter Xu
2023-06-02 22:11 ` John Hubbard
2023-06-02 22:38 ` Peter Xu
2023-06-02 22:52 ` John Hubbard
2023-06-03 0:43 ` John Hubbard
2023-06-03 1:18 ` Peter Xu
2023-06-03 1:39 ` John Hubbard
2023-06-02 1:33 ` [PATCH 11/12] selftests/mm: fix missing UFFDIO_CONTINUE_MODE_WP and similar build failures John Hubbard
2023-06-02 10:23 ` David Hildenbrand
2023-06-02 22:20 ` John Hubbard
2023-06-03 8:27 ` David Hildenbrand
2023-06-03 23:48 ` John Hubbard
2023-06-02 16:25 ` Muhammad Usama Anjum
2023-06-02 22:24 ` John Hubbard [this message]
2023-06-02 1:33 ` [PATCH 12/12] selftests/mm: fix uffd-unit-tests.c build failure due to missing MADV_COLLAPSE John Hubbard
2023-06-02 10:23 ` David Hildenbrand
2023-06-02 16:34 ` Muhammad Usama Anjum
2023-06-02 22:26 ` John Hubbard
2023-06-02 9:32 ` [PATCH 00/12] A minor flurry of selftest/mm fixes David Hildenbrand
2023-06-02 17:51 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3300328e-f977-beb5-f373-d0141ef49cf2@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathan@kernel.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.