From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEFPR-0002rJ-90 for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:50:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEFPL-0007Ee-Ft for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:50:13 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:41321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEFPK-00078t-SJ for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:50:07 -0500 From: "Gonglei (Arei)" Date: Fri, 14 Feb 2014 09:49:55 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020815C2720@SZXEMA503-MBS.china.huawei.com> References: <1392320685-20609-1-git-send-email-dgilbert@redhat.com> <33183CC9F5247A488A2544077AF19020815C26F8@SZXEMA503-MBS.china.huawei.com> <20140214093514.GB2316@work-vm> In-Reply-To: <20140214093514.GB2316@work-vm> Content-Language: zh-CN Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: "owasserm@redhat.com" , "qemu-devel@nongnu.org" , "quintela@redhat.com" DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IERyLiBEYXZpZCBBbGFuIEdp bGJlcnQgW21haWx0bzpkZ2lsYmVydEByZWRoYXQuY29tXQ0KPiBTZW50OiBGcmlkYXksIEZlYnJ1 YXJ5IDE0LCAyMDE0IDU6MzUgUE0NCj4gVG86IEdvbmdsZWkgKEFyZWkpDQo+IENjOiBxZW11LWRl dmVsQG5vbmdudS5vcmc7IG93YXNzZXJtQHJlZGhhdC5jb207IHF1aW50ZWxhQHJlZGhhdC5jb20N Cj4gU3ViamVjdDogUmU6IFtRZW11LWRldmVsXSBbUEFUQ0hdIEZpeCB0d28gWEJaUkxFIGNvcnJ1 cHRpb24gaXNzdWVzDQo+IA0KPiAqIEdvbmdsZWkgKEFyZWkpIChhcmVpLmdvbmdsZWlAaHVhd2Vp LmNvbSkgd3JvdGU6DQo+ID4NCj4gPiBCZXN0IHJlZ2FyZHMsDQo+ID4gLUdvbmdsZWkNCj4gPg0K PiA+DQo+IA0KPiA8c25pcD4NCj4gDQo+ID4gPiAgICAgICAgICAgICAgfSBlbHNlIGlmICghcmFt X2J1bGtfc3RhZ2UgJiYgbWlncmF0ZV91c2VfeGJ6cmxlKCkpIHsNCj4gPiA+IC0gICAgICAgICAg ICAgICAgY3VycmVudF9hZGRyID0gYmxvY2stPm9mZnNldCArIG9mZnNldDsNCj4gPiA+ICAgICAg ICAgICAgICAgICAgYnl0ZXNfc2VudCA9IHNhdmVfeGJ6cmxlX3BhZ2UoZiwgcCwgY3VycmVudF9h ZGRyLA0KPiBibG9jaywNCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgb2Zmc2V0LCBjb250LA0KPiA+ID4gbGFzdF9zdGFnZSk7DQo+ID4gPiAgICAg ICAgICAgICAgICAgIGlmICghbGFzdF9zdGFnZSkgew0KPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgLyogV2UgbXVzdCBzZW5kIGV4YWN0bHkgd2hhdCdzIGluIHRoZSB4YnpybGUNCj4gY2FjaGUN Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAqIGV2ZW4gaWYgdGhlIHBhZ2Ugd2Fzbid0IHhi enJsZSBjb21wcmVzc2VkLCBzbw0KPiA+ID4gdGhhdA0KPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICogaXQncyByaWdodCBuZXh0IHRpbWUuDQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg Ki8NCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgIHAgPSBnZXRfY2FjaGVkX2RhdGEoWEJaUkxF LmNhY2hlLA0KPiBjdXJyZW50X2FkZHIpOw0KPiA+ID4gKw0KPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgLyogQ2FuJ3Qgc2VuZCB0aGlzIGNhY2hlZCBkYXRhIGFzeW5jLCBzaW5jZSB0aGUNCj4g Y2FjaGUNCj4gPiA+IHBhZ2UNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAqIG1pZ2h0IGdl dCB1cGRhdGVkIGJlZm9yZSBpdCBnZXRzIHRvIHRoZSB3aXJlDQo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgKi8NCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgIHNlbmRfYXN5bmMgPSBmYWxz ZTsNCj4gPiA+ICAgICAgICAgICAgICAgICAgfQ0KPiA+ID4gICAgICAgICAgICAgIH0NCj4gPiA+ DQo+ID4gPiAgICAgICAgICAgICAgLyogWEJaUkxFIG92ZXJmbG93IG9yIG5vcm1hbCBwYWdlICov DQo+ID4gPiAgICAgICAgICAgICAgaWYgKGJ5dGVzX3NlbnQgPT0gLTEpIHsNCj4gPiA+ICAgICAg ICAgICAgICAgICAgYnl0ZXNfc2VudCA9IHNhdmVfYmxvY2tfaGRyKGYsIGJsb2NrLCBvZmZzZXQs IGNvbnQsDQo+ID4gPiBSQU1fU0FWRV9GTEFHX1BBR0UpOw0KPiA+ID4gLSAgICAgICAgICAgICAg ICBxZW11X3B1dF9idWZmZXJfYXN5bmMoZiwgcCwgVEFSR0VUX1BBR0VfU0laRSk7DQo+ID4gPiAr ICAgICAgICAgICAgICAgIGlmIChzZW5kX2FzeW5jKSB7DQo+ID4gPiArICAgICAgICAgICAgICAg ICAgICBxZW11X3B1dF9idWZmZXJfYXN5bmMoZiwgcCwNCj4gVEFSR0VUX1BBR0VfU0laRSk7DQo+ ID4gPiArICAgICAgICAgICAgICAgIH0gZWxzZSB7DQo+ID4gPiArICAgICAgICAgICAgICAgICAg ICBxZW11X3B1dF9idWZmZXIoZiwgcCwgVEFSR0VUX1BBR0VfU0laRSk7DQo+ID4gPiArICAgICAg ICAgICAgICAgIH0NCj4gPiA+ICAgICAgICAgICAgICAgICAgYnl0ZXNfc2VudCArPSBUQVJHRVRf UEFHRV9TSVpFOw0KPiA+ID4gICAgICAgICAgICAgICAgICBhY2N0X2luZm8ubm9ybV9wYWdlcysr Ow0KPiA+ID4gICAgICAgICAgICAgIH0NCj4gPg0KPiA+IGlmIGEgcGFnZSB0aGF0IHdhcyBjYWNo ZWQgYnkgWEJaUkxFIGJ1dCBYQlpSTEUgb3ZlcmZsb3cscWVtdSBzaG91bGQgc2VuZA0KPiB0aGUg cGFnZSBpbiB0aGUgY2FjaGUgcmF0aGVyIHRoZW4gb3JpZ2luYWwgcGFnZS5CZWNhdXNlIHRoZSBv cmlnaW5hbCBwYWdlDQo+IG1pZ2h0IGNoYW5nZSAuDQo+IA0KPiBXaGljaCBpdCBhbHJlYWR5IGRv ZXMgLSBzZWUgdGhlIGxpbmUgYWJvdmUgd2hpY2ggaXM6DQo+ICAgICBwID0gZ2V0X2NhY2hlZF9k YXRhKFhCWlJMRS5jYWNoZSwgY3VycmVudF9hZGRyKTsNCj4gDQo+IFRoYXQgY2hhbmdlcyB0aGUg J3AnIHRvIHBvaW50IHRvIHRoZSBwYWdlIGluIHRoZSBjYWNoZSBhbmQgdGh1cyBmb3JjZXMgdGhh dA0KPiBxZW11X3B1dF9idWZmZXIgdG8gc2VuZCB0aGUgcGFnZSBpbiB0aGUgY2FjaGU7IG15IHBh dGNoIGRvZXNuJ3QgY2hhbmdlIHRoYXQsDQo+IGl0IGp1c3Qgc3RvcHMgaXQgdXNpbmcgdGhlIHFl bXVfcHV0X2J1ZmZlcl9hc3luYyBzbyB0aGF0IHRoZSBjYWNoZSBpcyByZWFkDQo+IGltbWVkaWF0 ZWx5IG5vdCBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUgd2hlbiB0aGUgY2FjaGUgbWF5IGhh dmUNCj4gY2hhbmdlZC4NCj4gDQo+IERhdmUNCj4gLS0NCj4gRHIuIERhdmlkIEFsYW4gR2lsYmVy dCAvIGRnaWxiZXJ0QHJlZGhhdC5jb20gLyBNYW5jaGVzdGVyLCBVSw0KVGhhbmtzLCB5b3UgYXJl IHJpZ2h0Lg0K