From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XU3eZ-0000rC-Ey
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 21:03:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XU3eU-0000gp-4E
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 21:03:27 -0400
Received: from szxga01-in.huawei.com ([119.145.14.64]:35813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XU3eT-0000dr-Dv
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 21:03:22 -0400
From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Date: Wed, 17 Sep 2014 01:02:55 +0000
Message-ID: <33183CC9F5247A488A2544077AF1902086DD69B2@SZXEMA503-MBS.china.huawei.com>
References: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com>
	<33183CC9F5247A488A2544077AF1902086DD646C@SZXEMA503-MBS.china.huawei.com>
	<1410877007.32607.9.camel@nilsson.home.kraxel.org>
	<87tx47a6d5.fsf@blackfin.pond.sub.org>
In-Reply-To: <87tx47a6d5.fsf@blackfin.pond.sub.org>
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Wednesday, September 17, 2014 12:16 AM
> To: Gerd Hoffmann
> Cc: Gonglei (Arei); Huangweidong (C); qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
>=20
> Gerd Hoffmann <kraxel@redhat.com> writes:
>=20
> >   Hi,
> >
> >> > Gonglei (2):
> >> >   redirect.c: Don't use qerror_report()
> >> >   dev-network: Don't use qerror_report_err()
> >
> >> Hi, Gerd
> >> Would you like to apply this patch series at present? Thanks!
> >
> > Picked it up now.  Originally dropped due to review comments from paolo=
,
> > but switching all usb over to realize is a bigger project indeed.
>=20
> Please don't, it degrades QMP errors.  Example:
>=20
>     { "execute": "device_add", "arguments": { "driver": "usb-redir" } }
>=20
> Reply before:
>=20
>     {"error": {"class": "GenericError", "desc": "Parameter 'chardev' is
> missing"}}
>=20
> After:
>=20
>     {"error": {"class": "GenericError", "desc": "Device initialization fa=
iled."}}
>=20
> with "Parameter 'chardev' is missing" barfed to stderr.

Hum.. Thanks for your information :)=20

Gerd, please drop this patch series, Thanks!

Best regards,
-Gonglei