From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XWai4-0004f2-OU
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:45:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XWahz-0008AT-Mu
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:45:32 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:61308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XWahz-00089G-3c
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 20:45:27 -0400
From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Date: Wed, 24 Sep 2014 00:44:58 +0000
Message-ID: <33183CC9F5247A488A2544077AF1902086DDA29D@SZXEMA503-MBS.china.huawei.com>
References: <1411477717-6988-1-git-send-email-arei.gonglei@huawei.com>
	<5421A7FA.3040706@redhat.com>
In-Reply-To: <5421A7FA.3040706@redhat.com>
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/7] add description field in
 ObjectProperty and PropertyInfo struct
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "mst@redhat.com" <mst@redhat.com>, Luonengjun <luonengjun@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "armbru@redhat.com" <armbru@redhat.com>, "aliguori@amazon.com" <aliguori@amazon.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "afaerber@suse.de" <afaerber@suse.de>

> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Wednesday, September 24, 2014 1:04 AM
> Subject: Re: [PATCH 0/7] add description field in ObjectProperty and
> PropertyInfo struct
>=20
> Il 23/09/2014 15:08, arei.gonglei@huawei.com ha scritto:
> > From: Gonglei <arei.gonglei@huawei.com>
> >
> > PATCH 1 and PATCH 2 are bugfixes. PATCH 3~7 add a description
> > field in both ObjectProperty and PropertyInfo struct.
> > The descriptions can serve as documentation in the code,
> > and they can be used to provide better help. For example:
> >
> > Before this patch series:
> >
> > $./qemu-system-x86_64 -device virtio-blk-pci,?
> >
> > virtio-blk-pci.iothread=3Dlink<iothread>
> > virtio-blk-pci.x-data-plane=3Dbool
> > virtio-blk-pci.scsi=3Dbool
> > virtio-blk-pci.config-wce=3Dbool
> > virtio-blk-pci.serial=3Dstr
> > virtio-blk-pci.secs=3Duint32
> > virtio-blk-pci.heads=3Duint32
> > virtio-blk-pci.cyls=3Duint32
> > virtio-blk-pci.discard_granularity=3Duint32
> > virtio-blk-pci.bootindex=3Dint32
> > virtio-blk-pci.opt_io_size=3Duint32
> > virtio-blk-pci.min_io_size=3Duint16
> > virtio-blk-pci.physical_block_size=3Duint16
> > virtio-blk-pci.logical_block_size=3Duint16
> > virtio-blk-pci.drive=3Dstr
> > virtio-blk-pci.virtio-backend=3Dchild<virtio-blk-device>
> > virtio-blk-pci.command_serr_enable=3Don/off
> > virtio-blk-pci.multifunction=3Don/off
> > virtio-blk-pci.rombar=3Duint32
> > virtio-blk-pci.romfile=3Dstr
> > virtio-blk-pci.addr=3Dpci-devfn
> > virtio-blk-pci.event_idx=3Don/off
> > virtio-blk-pci.indirect_desc=3Don/off
> > virtio-blk-pci.vectors=3Duint32
> > virtio-blk-pci.ioeventfd=3Don/off
> > virtio-blk-pci.class=3Duint32
> >
> > After:
> >
> > $./qemu-system-x86_64 -device virtio-blk-pci,?
> >
> > virtio-blk-pci.iothread=3Dlink<iothread>
> > virtio-blk-pci.x-data-plane=3Dbool (on/off)
> > virtio-blk-pci.scsi=3Dbool (on/off)
> > virtio-blk-pci.config-wce=3Dbool (on/off)
> > virtio-blk-pci.serial=3Dstr
> > virtio-blk-pci.secs=3Duint32
> > virtio-blk-pci.heads=3Duint32
> > virtio-blk-pci.cyls=3Duint32
> > virtio-blk-pci.discard_granularity=3Duint32
> > virtio-blk-pci.bootindex=3Dint32
> > virtio-blk-pci.opt_io_size=3Duint32
> > virtio-blk-pci.min_io_size=3Duint16
> > virtio-blk-pci.physical_block_size=3Duint16 (A power of two between 512=
 and
> 32768)
> > virtio-blk-pci.logical_block_size=3Duint16 (A power of two between 512 =
and
> 32768)
> > virtio-blk-pci.drive=3Dstr (ID of a drive to use as a backend)
> > virtio-blk-pci.virtio-backend=3Dchild<virtio-blk-device>
> > virtio-blk-pci.command_serr_enable=3Dbool (on/off)
> > virtio-blk-pci.multifunction=3Dbool (on/off)
> > virtio-blk-pci.rombar=3Duint32
> > virtio-blk-pci.romfile=3Dstr
> > virtio-blk-pci.addr=3Dint32 (The slot number of a pci device)
> > virtio-blk-pci.event_idx=3Dbool (on/off)
> > virtio-blk-pci.indirect_desc=3Dbool (on/off)
> > virtio-blk-pci.vectors=3Duint32
> > virtio-blk-pci.ioeventfd=3Dbool (on/off)
> > virtio-blk-pci.class=3Duint32
> >
> > Gonglei (7):
> >   qom: add error handler for object_property_print()
> >   qom: add error handler for object alias property
> >   qdev: add description field in PropertyInfo struct
> >   qom: add description field in ObjectProperty struct
> >   qdev: set the object property's description to the qdev property's.
> >   qmp: print descriptions of object properties
> >   qdev: drop legacy_name from qdev properties
> >
> >  hw/core/qdev-properties-system.c |  8 ++++----
> >  hw/core/qdev-properties.c        | 12 ++++++------
> >  hw/core/qdev.c                   |  3 +++
> >  include/hw/qdev-core.h           |  2 +-
> >  include/qom/object.h             | 15 +++++++++++++++
> >  qmp.c                            | 19 +++++++++++++++----
> >  qom/object.c                     | 33
> ++++++++++++++++++++++++++++++---
> >  target-ppc/translate_init.c      |  2 +-
> >  8 files changed, 75 insertions(+), 19 deletions(-)
> >
>=20
> Just one comment on patch 5.  The description can be improved, I can do
> it tomorrow.
>=20

Great! I'm looking forward to your reply. :)

Best regards,
-Gonglei

> Thanks!
>=20
> Paolo