From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYZls-0002ul-7J
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:09:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYZln-0005vP-E8
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:09:40 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:13225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYZlm-0005uW-PJ
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:09:35 -0400
From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Date: Mon, 29 Sep 2014 12:09:06 +0000
Message-ID: <33183CC9F5247A488A2544077AF1902086DDCCC8@SZXEMA503-MBS.china.huawei.com>
References: <1411721147-11712-1-git-send-email-arei.gonglei@huawei.com>
	<20140926162125.71ea6598.cornelia.huck@de.ibm.com>
	<33183CC9F5247A488A2544077AF1902086DDC6DD@SZXEMA503-MBS.china.huawei.com>
	<20140929125309.3b3483d0.cornelia.huck@de.ibm.com>
In-Reply-To: <20140929125309.3b3483d0.cornelia.huck@de.ibm.com>
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child
 recount in transports
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "mst@redhat.com" <mst@redhat.com>, "armbru@redhat.com" <armbru@redhat.com>, Luonengjun <luonengjun@huawei.com>, "agraf@suse.de" <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "borntraeger@de.ibm.com" <borntraeger@de.ibm.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "Huangpeng
	(Peter)" <peter.huangpeng@huawei.com>, "rth@twiddle.net" <rth@twiddle.net>

> From: Cornelia Huck [mailto:cornelia.huck@de.ibm.com]
> Sent: Monday, September 29, 2014 6:53 PM
> Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in trans=
ports
>=20
> On Sat, 27 Sep 2014 10:37:23 +0000
> "Gonglei (Arei)" <arei.gonglei@huawei.com> wrote:
>=20
> > > > One thing I noticed is that the various devices end up with similar
> > > > code in the end:
> > > >
> > > >      object_initialize(&dev->vdev, sizeof(dev->vdev), TYPE_WHATEVER=
);
> > > >      object_property_add_child(obj, "virtio-backend",
> > > OBJECT(&dev->vdev),
> > > > NULL);
> > > >      object_unref(OBJECT(&dev->vdev));
> > > >      qdev_alias_all_properties(DEVICE(&dev->vdev), obj);
> > > >
> > > > Would it make sense to add a helper function for that?
> > >
> >
> > Sorry, I'm afraid this is not helpful. Because dev and dev->vdev is dif=
ferent
> > for different virtio devices, like VirtIOBlkPCI(and its vdev is VirtIOB=
lock),
> > VirtIONetPCI(and its vdev is VirtIONet). They have no the same paramete=
rs
> > for above code segment. :)
>=20
> Hm...
>=20
> void virtio_instance_init_common(Object *proxydev,
>                                  DeviceState *vdev,
>                                  size_t vdevsize,
>                                  const char *vdevname)
> {
>     object_initialize(vdev, vdevsize, vdevname);
>     object_property_add_child(proxydev, "virtio-backend", OBJECT(vdev),
> NULL);
>     object_unref(OBJECT(vdev));
>     qdev_alias_all_properties(vdev, proxydev);
> }
>=20
> and have the initializers call
>=20
> virtio_instance_init_common(obj, DEVICE(&dev->vdev), sizeof(dev->vdev),
> TYPE_WHATEVER);
>=20
> ?

OK, it looks good that pass all parameters to one wrapper function.=20
Will do this in next version.

Thanks, Cornelia. :)

Best regards,
-Gonglei