From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYaDt-0000yy-Gb
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:38:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYaDk-0005Ae-Aq
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:38:37 -0400
Received: from szxga01-in.huawei.com ([119.145.14.64]:56416)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XYaDj-00052b-NK
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 08:38:28 -0400
From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Date: Mon, 29 Sep 2014 12:37:48 +0000
Message-ID: <33183CC9F5247A488A2544077AF1902086DDCD59@SZXEMA503-MBS.china.huawei.com>
References: <1411721147-11712-1-git-send-email-arei.gonglei@huawei.com>
	<20140926162125.71ea6598.cornelia.huck@de.ibm.com>
	<33183CC9F5247A488A2544077AF1902086DDC6DD@SZXEMA503-MBS.china.huawei.com>
	<20140929125309.3b3483d0.cornelia.huck@de.ibm.com>
	<54295159.4090209@redhat.com>
In-Reply-To: <54295159.4090209@redhat.com>
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child
 recount in transports
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: "Huangweidong
	(C)" <weidong.huang@huawei.com>, "mst@redhat.com" <mst@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "armbru@redhat.com" <armbru@redhat.com>, Luonengjun <luonengjun@huawei.com>, "agraf@suse.de" <agraf@suse.de>, "Huangpeng
	(Peter)" <peter.huangpeng@huawei.com>, "borntraeger@de.ibm.com" <borntraeger@de.ibm.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "rth@twiddle.net" <rth@twiddle.net>

> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> Sent: Monday, September 29, 2014 8:32 PM
> Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in trans=
ports
>=20
> Il 29/09/2014 12:53, Cornelia Huck ha scritto:
> > void virtio_instance_init_common(Object *proxydev,
> >                                  DeviceState *vdev,
> >                                  size_t vdevsize,
> >                                  const char *vdevname)
> > {
> >     object_initialize(vdev, vdevsize, vdevname);
> >     object_property_add_child(proxydev, "virtio-backend", OBJECT(vdev),
> NULL);
> >     object_unref(OBJECT(vdev));
> >     qdev_alias_all_properties(vdev, proxydev);
> > }
> >
> > and have the initializers call
> >
> > virtio_instance_init_common(obj, DEVICE(&dev->vdev), sizeof(dev->vdev),
> TYPE_WHATEVER);
>=20
> You cannot use DEVICE() here because dev->vdev has not been initialized
> yet.  But virtio_instance_init_common could just take a void*.
>=20
> Paolo

Good catch and suggestion, Thanks!

Best regards,
-Gonglei