From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjyg9-0001Tc-0H for qemu-devel@nongnu.org; Tue, 13 Sep 2016 21:07:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjyg5-0006ta-3E for qemu-devel@nongnu.org; Tue, 13 Sep 2016 21:07:56 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:50296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjyg4-0006ru-EV for qemu-devel@nongnu.org; Tue, 13 Sep 2016 21:07:53 -0400 From: "Gonglei (Arei)" Date: Wed, 14 Sep 2016 01:07:19 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020B03CABA9@SZXEMA503-MBS.china.huawei.com> References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-3-git-send-email-arei.gonglei@huawei.com> <20160913092050.GD30949@redhat.com> <8cfc0ce6-babb-6115-f64d-4f17074ae8f7@redhat.com> In-Reply-To: Content-Language: zh-CN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ola Liljedahl , Paolo Bonzini , "Daniel P. Berrange" Cc: "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Huangpeng (Peter)" , Luonengjun , "mst@redhat.com" , "stefanha@redhat.com" , "Huangweidong (C)" , "mike.caraman@nxp.com" , "agraf@suse.de" , "xin.zeng@intel.com" , Claudio Fontana , "nmorey@kalray.eu" , "vincent.jardin@6wind.com" Hi Ola, > -----Original Message----- > From: Ola Liljedahl [mailto:Ola.Liljedahl@arm.com] > Sent: Tuesday, September 13, 2016 7:53 PM > To: Paolo Bonzini; Daniel P. Berrange; Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; mst@redhat.com; stefanha@redhat.com; Huangweidong > (C); mike.caraman@nxp.com; agraf@suse.de; xin.zeng@intel.com; Claudio > Fontana; nmorey@kalray.eu; vincent.jardin@6wind.com > Subject: Re: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto q= ueue > handler >=20 >=20 >=20 >=20 >=20 > On 13/09/2016, 12:58, "virtio-dev@lists.oasis-open.org on behalf of Paolo > Bonzini" pbonzini@redhat.com> wrote: >=20 > > > > > >On 13/09/2016 11:20, Daniel P. Berrange wrote: > >>> > +typedef struct CryptoPacket CryptoPacket; > >>> > +typedef struct CryptoQueue CryptoQueue; > >>> > +typedef struct CryptoPacketBuf CryptoPacketBuf; > >>> > + > >>> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); > >> As previously, I'd expect naming of > >> > >> QCryptoCryptodevPacket > >> QCryptoCryptodevPacketBuf > >> QCryptoCryptodevQueue > >> > > > >Gonglei, > > > >you are copying a lot of code from network backends. > > > >I am not sure why you would need a queue for virtio-crypto rather than a > >direct connection between frontend and backend (and the backend would be > >QEMU crypto APIs, like Daniel suggested). > > What about backends implemented directly in HW? Bypass the middle man. > Make crypto offload meaningful for small size blocks. >=20 As I said in other reply, I only provide interfaces, you can realize them a= ccording to different backend cryptodevs. Regards, -Gonglei > < Ola >=20 > > > >Paolo > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > >For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > > >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you.