From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1k8T-0005XJ-Qu for qemu-devel@nongnu.org; Tue, 01 Nov 2016 21:14:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1k8P-0001Zl-R5 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 21:14:37 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:11115) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1k8N-0001S1-RC for qemu-devel@nongnu.org; Tue, 01 Nov 2016 21:14:33 -0400 From: "Gonglei (Arei)" Date: Wed, 2 Nov 2016 01:13:50 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020B041659B@SZXEMA503-MBS.china.huawei.com> References: <1477850917-1214-1-git-send-email-mst@redhat.com> <20161101192359-mutt-send-email-mst@kernel.org> In-Reply-To: <20161101192359-mutt-send-email-mst@kernel.org> Content-Language: zh-CN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Peter Maydell Cc: QEMU Developers > -----Original Message----- > From: Qemu-devel > [mailto:qemu-devel-bounces+arei.gonglei=3Dhuawei.com@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Wednesday, November 02, 2016 1:26 AM > To: Peter Maydell > Cc: QEMU Developers > Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features >=20 > On Tue, Nov 01, 2016 at 03:22:01PM +0000, Peter Maydell wrote: > > On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > > > The following changes since commit > 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-= 1' > into staging (2016-10-28 17:59:04 +0100) > > > > > > are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea= m > > > > > > for you to fetch changes up to > f082ec0225bd15c71e0b4697d2df3af7bad65d7f: > > > > > > acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:0= 6:25 > +0200) > > > > > > ---------------------------------------------------------------- > > > virtio, pc: fixes and features > > > > > > nvdimm hotplug support > > > virtio migration and ioeventfd rework > > > virtio crypto device > > > ipmi fixes > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > Hi; this fails to build on OSX with format string issues: > > > > /Users/pm215/src/qemu-for-merges/hw/virtio/virtio-crypto.c:770:20: > > error: format specifies type 'unsign > > ed short' but the argument has type 'uint32_t' (aka 'unsigned int') > > [-Werror,-Wformat] > > vcrypto->max_queues, VIRTIO_QUEUE_MAX); > > ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /Users/pm215/src/qemu-for-merges/include/qapi/error.h:163:35: note: > > expanded from macro 'error_setg' > > (fmt), ## __VA_ARGS__) > > ^ > > > > Fun fact: in struct vhost_dev, max_queues is a uint64_t; > > in struct VirtIONet it is a uint16_t; and in VirtIOCrypto > > it is a uint32_t... > > > > thanks > > -- PMM >=20 > Yes - I really think we should move that to virtio core > going forward. > Anyway, I fixed that up and pushed. >=20 Sorry about that. TBH that error log messge is copied from virtio-net.c and I didn't notice their types are different. For virtio-crypto, it should be = 'PRIu32'. Regards, -Gonglei