From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonglei (Arei)" Subject: RE: [PATCH] virtio-crypto: adjust priority of algorithm Date: Fri, 13 Jan 2017 09:24:43 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA18FD9A@DGGEMA505-MBX.china.huawei.com> References: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com> <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "herbert@gondor.apana.org.au" , "mst@redhat.com" To: Christian Borntraeger , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Return-path: In-Reply-To: <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> Content-Language: zh-CN List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: linux-crypto.vger.kernel.org > > From: Christian Borntraeger [mailto:borntraeger@de.ibm.com] > Sent: Friday, January 13, 2017 4:28 PM > To: Gonglei (Arei); virtualization@lists.linux-foundation.org; > linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: mst@redhat.com; herbert@gondor.apana.org.au > Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm > > ACK. Whoever takes this patch might want to fixup 3 typos. > Thanks, I'd better send v2 IMHO. :) Regards, -Gonglei > On 01/13/2017 07:25 AM, Gonglei wrote: > > > Some hardware accelerators (like intel aseni or the s390 > aesni > > cpacf functions) have lower priorities than virtio > > crypto, and those drivers are faster than the same in > > the host via virtio. So let's lower the priority of > > virtio-crypto's algorithm, make it's higher than sofeware > software > > implimentations but lower than the hardware ones. > implementations > > > > Suggested-by: Christian Borntraeger > > Signed-off-by: Gonglei > > --- > > drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > > index 6f40a42..4de4740 100644 > > --- a/drivers/crypto/virtio/virtio_crypto_algs.c > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c > > @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req( > > static struct crypto_alg virtio_crypto_algs[] = { { > > .cra_name = "cbc(aes)", > > .cra_driver_name = "virtio_crypto_aes_cbc", > > - .cra_priority = 501, > > + .cra_priority = 150, > > .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, > > .cra_blocksize = AES_BLOCK_SIZE, > > .cra_ctxsize = sizeof(struct virtio_crypto_ablkcipher_ctx), > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbdAMJZm convert rfc822-to-8bit (ORCPT ); Fri, 13 Jan 2017 04:25:42 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:2391 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751282AbdAMJZd (ORCPT ); Fri, 13 Jan 2017 04:25:33 -0500 From: "Gonglei (Arei)" To: Christian Borntraeger , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "mst@redhat.com" , "herbert@gondor.apana.org.au" Subject: RE: [PATCH] virtio-crypto: adjust priority of algorithm Thread-Topic: [PATCH] virtio-crypto: adjust priority of algorithm Thread-Index: AQHSbWX4IC1t/LrEEkKaiQAGF1sibaE1jSCAgACVUWA= Date: Fri, 13 Jan 2017 09:24:43 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA18FD9A@DGGEMA505-MBX.china.huawei.com> References: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com> <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> In-Reply-To: <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.18.62] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.58789CE2.006D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.109, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f8bf4ca236ac5485f85817c9b385ede6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > From: Christian Borntraeger [mailto:borntraeger@de.ibm.com] > Sent: Friday, January 13, 2017 4:28 PM > To: Gonglei (Arei); virtualization@lists.linux-foundation.org; > linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: mst@redhat.com; herbert@gondor.apana.org.au > Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm > > ACK. Whoever takes this patch might want to fixup 3 typos. > Thanks, I'd better send v2 IMHO. :) Regards, -Gonglei > On 01/13/2017 07:25 AM, Gonglei wrote: > > > Some hardware accelerators (like intel aseni or the s390 > aesni > > cpacf functions) have lower priorities than virtio > > crypto, and those drivers are faster than the same in > > the host via virtio. So let's lower the priority of > > virtio-crypto's algorithm, make it's higher than sofeware > software > > implimentations but lower than the hardware ones. > implementations > > > > Suggested-by: Christian Borntraeger > > Signed-off-by: Gonglei > > --- > > drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > > index 6f40a42..4de4740 100644 > > --- a/drivers/crypto/virtio/virtio_crypto_algs.c > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c > > @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req( > > static struct crypto_alg virtio_crypto_algs[] = { { > > .cra_name = "cbc(aes)", > > .cra_driver_name = "virtio_crypto_aes_cbc", > > - .cra_priority = 501, > > + .cra_priority = 150, > > .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, > > .cra_blocksize = AES_BLOCK_SIZE, > > .cra_ctxsize = sizeof(struct virtio_crypto_ablkcipher_ctx), > >