Re: [Qemu-devel] [RFC v1 5/9] virtio-crypto: update header file

From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"Huangweidong (C)" <weidong.huang@huawei.com>,
	"pasic@linux.vnet.ibm.com" <pasic@linux.vnet.ibm.com>,
	Luonengjun <luonengjun@huawei.com>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	Linqiangmin <linqiangmin@huawei.com>,
	"xin.zeng@intel.com" <xin.zeng@intel.com>,
	"Wubin (H)" <wu.wubin@huawei.com>
Subject: Re: [Qemu-devel] [RFC v1 5/9] virtio-crypto: update header file
Date: Wed, 17 May 2017 08:48:33 +0000	[thread overview]
Message-ID: <33183CC9F5247A488A2544077AF19020DA29B1CF@DGGEMA505-MBS.china.huawei.com> (raw)
In-Reply-To: <20170516154317.GS8498@stefanha-x1.localdomain>

>
> -----Original Message-----
> From: Stefan Hajnoczi [mailto:stefanha@redhat.com]
> Sent: Tuesday, May 16, 2017 11:43 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; mst@redhat.com; Huangweidong (C);
> pasic@linux.vnet.ibm.com; Luonengjun; cornelia.huck@de.ibm.com;
> Linqiangmin; xin.zeng@intel.com; Wubin (H)
> Subject: Re: [RFC v1 5/9] virtio-crypto: update header file
> 
> On Mon, May 08, 2017 at 07:38:20PM +0800, Gonglei wrote:
> > @@ -166,8 +175,8 @@ struct virtio_crypto_aead_session_para {
> >  	uint32_t algo;
> >  	/* length of key */
> >  	uint32_t key_len;
> > -	/* hash result length */
> > -	uint32_t hash_result_len;
> > +	/* Authentication tag length */
> > +	uint32_t tag_len;
> 
> Why is this field being renamed?

Oh, I just think the latter name ' tag_len' is more proper than 'hash_result_len',
and the current code don't touch this field.

Thanks,
-Gonglei