* [Qemu-devel] [PATCH] cryptodev: fix two typos in error message
@ 2017-06-29 11:57 Pu Hou
2017-06-29 13:39 ` Gonglei (Arei)
0 siblings, 1 reply; 3+ messages in thread
From: Pu Hou @ 2017-06-29 11:57 UTC (permalink / raw)
To: qemu-devel, arei.gonglei; +Cc: pasic, BAGRAMOV, Pu Hou
Currently we have the name of the backend 'cryptodev-builtin' misspelled
as 'cryptdov-builtin' in two potentially user facing error messages.
Let's fix this.
Furthermore The second mention of 'cryptodev-builtin' omits 'backend'.
Let's make things consistent by adding it.
Reported-by: Timur Bagramov <BAGRAMOV@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: Pu Hou <bjhoupu@linux.vnet.ibm.com>
---
backends/cryptodev-builtin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
index 657c0ba2f3..4e619dfca8 100644
--- a/backends/cryptodev-builtin.c
+++ b/backends/cryptodev-builtin.c
@@ -70,7 +70,7 @@ static void cryptodev_builtin_init(
if (queues != 1) {
error_setg(errp,
- "Only support one queue in cryptdov-builtin backend");
+ "Only support one queue in cryptodev-builtin backend");
return;
}
@@ -314,7 +314,7 @@ static int cryptodev_builtin_sym_operation(
if (op_info->op_type == VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING) {
error_setg(errp,
- "Algorithm chain is unsupported for cryptdoev-builtin");
+ "Algorithm chain is unsupported for cryptodev-builtin backend");
return -VIRTIO_CRYPTO_NOTSUPP;
}
--
2.11.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: fix two typos in error message
2017-06-29 11:57 [Qemu-devel] [PATCH] cryptodev: fix two typos in error message Pu Hou
@ 2017-06-29 13:39 ` Gonglei (Arei)
0 siblings, 0 replies; 3+ messages in thread
From: Gonglei (Arei) @ 2017-06-29 13:39 UTC (permalink / raw)
To: Pu Hou, qemu-devel; +Cc: pasic, BAGRAMOV
> -----Original Message-----
> From: Pu Hou [mailto:bjhoupu@linux.vnet.ibm.com]
> Sent: Thursday, June 29, 2017 7:58 PM
> To: qemu-devel@nongnu.org; Gonglei (Arei)
> Cc: pasic@linux.vnet.ibm.com; BAGRAMOV@de.ibm.com; Pu Hou
> Subject: [PATCH] cryptodev: fix two typos in error message
>
> Currently we have the name of the backend 'cryptodev-builtin' misspelled
> as 'cryptdov-builtin' in two potentially user facing error messages.
> Let's fix this.
>
> Furthermore The second mention of 'cryptodev-builtin' omits 'backend'.
> Let's make things consistent by adding it.
>
> Reported-by: Timur Bagramov <BAGRAMOV@de.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Signed-off-by: Pu Hou <bjhoupu@linux.vnet.ibm.com>
> ---
> backends/cryptodev-builtin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Queued, thanks.
Regards,
-Gonglei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] cryptodev: fix two typos in error message
@ 2017-06-29 11:53 Pu Hou
0 siblings, 0 replies; 3+ messages in thread
From: Pu Hou @ 2017-06-29 11:53 UTC (permalink / raw)
To: qemu-devel, arei.gonglei; +Cc: asic, BAGRAMOV, Pu Hou
Currently we have the name of the backend 'cryptodev-builtin' misspelled
as 'cryptdov-builtin' in two potentially user facing error messages.
Let's fix this.
Furthermore The second mention of 'cryptodev-builtin' omits 'backend'.
Let's make things consistent by adding it.
Reported-by: Timur Bagramov <BAGRAMOV@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: Pu Hou <bjhoupu@linux.vnet.ibm.com>
---
backends/cryptodev-builtin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
index 657c0ba2f3..4e619dfca8 100644
--- a/backends/cryptodev-builtin.c
+++ b/backends/cryptodev-builtin.c
@@ -70,7 +70,7 @@ static void cryptodev_builtin_init(
if (queues != 1) {
error_setg(errp,
- "Only support one queue in cryptdov-builtin backend");
+ "Only support one queue in cryptodev-builtin backend");
return;
}
@@ -314,7 +314,7 @@ static int cryptodev_builtin_sym_operation(
if (op_info->op_type == VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING) {
error_setg(errp,
- "Algorithm chain is unsupported for cryptdoev-builtin");
+ "Algorithm chain is unsupported for cryptodev-builtin backend");
return -VIRTIO_CRYPTO_NOTSUPP;
}
--
2.11.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-29 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 11:57 [Qemu-devel] [PATCH] cryptodev: fix two typos in error message Pu Hou
2017-06-29 13:39 ` Gonglei (Arei)
-- strict thread matches above, loose matches on Subject: below --
2017-06-29 11:53 Pu Hou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.