From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07B0C4332F for ; Mon, 28 Mar 2022 08:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239149AbiC1ILo (ORCPT ); Mon, 28 Mar 2022 04:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236254AbiC1ILl (ORCPT ); Mon, 28 Mar 2022 04:11:41 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 726D6527D2; Mon, 28 Mar 2022 01:10:01 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0E96B1F430E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648455000; bh=/nWwqk3sPy6vmwVbxGTUip5rp6cQqefeecpSJO7M4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UiJeHcrb22+gxlwFAcWUPiZHHp8/logMJ7mTY54Dc1dhEE8gp3W9RL0O7G2CeQXbV gIqH3zqEye8pXt/cRvpTwr9+Q8OjU5Dx0heK90tYwCh0FG6ooKJCrPf7lDXXZpsFOU iwY+2LC5L/DGNeGUnoN9ihJH5wnjerx0CcCMLOPISGODK27sNNctav+XfeXXZnT9LJ CHFwHtVxRjUBayuSZAllKSy96pw17v1+oZgJF5zYl3SpZC9S5LcITyy6uM2G5QoBXJ hgfBsPl3nn+kuliZ6N1Fg1z4XIIGmoYOMwZlhuvbmsSXO3z/csC/LfIC/IJsyFz+yx 8fyq0INsI78aQ== Message-ID: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> Date: Mon, 28 Mar 2022 10:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Content-Language: en-US To: Guillaume Ranquet , airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220327223927.20848-7-granquet@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A686EC433EF for ; Mon, 28 Mar 2022 08:10:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CABF10E564; Mon, 28 Mar 2022 08:10:03 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D19610E55C for ; Mon, 28 Mar 2022 08:10:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0E96B1F430E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648455000; bh=/nWwqk3sPy6vmwVbxGTUip5rp6cQqefeecpSJO7M4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UiJeHcrb22+gxlwFAcWUPiZHHp8/logMJ7mTY54Dc1dhEE8gp3W9RL0O7G2CeQXbV gIqH3zqEye8pXt/cRvpTwr9+Q8OjU5Dx0heK90tYwCh0FG6ooKJCrPf7lDXXZpsFOU iwY+2LC5L/DGNeGUnoN9ihJH5wnjerx0CcCMLOPISGODK27sNNctav+XfeXXZnT9LJ CHFwHtVxRjUBayuSZAllKSy96pw17v1+oZgJF5zYl3SpZC9S5LcITyy6uM2G5QoBXJ hgfBsPl3nn+kuliZ6N1Fg1z4XIIGmoYOMwZlhuvbmsSXO3z/csC/LfIC/IJsyFz+yx 8fyq0INsI78aQ== Message-ID: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> Date: Mon, 28 Mar 2022 10:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Content-Language: en-US To: Guillaume Ranquet , airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220327223927.20848-7-granquet@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Markus Schneider-Pargmann , linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, markyacoub@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 775D3C433EF for ; Mon, 28 Mar 2022 08:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RzPmtJcbERnPpyDseneJsmazX3D1GMLRFq8JrxIR+nA=; b=sqSxGivY2WPiWj P6c6tdNVD8fHISJanesVY4qmY1Qs35DmOkBQPpVK4UPbgxVc5XfItr47rfUhYdpLIutlJ2Jip/pXU zAauYZkckBahOAbY0oxbS/9T6cPuWNp5fTyQZpFQCXDdXr1ly/ae8YR4opCSJ16ZKVr3OF6rTzDEN DTTpaCWePfXnbllpPKu1iXc0gWoDXhfbjzh+bPadkFvCmk9TSnRfTs03N6CzZE8hL6P8NEPxfubj6 i7q55mUSB5hf+QdGYioSQFcPFm/9K0u7rlAPgRTf4uFdq1VzFGCKwZc8ugB5FIP/uvp6C8pCC+m24 2+urA7UOKMwDPoAtG5Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkUS-007lD2-9o; Mon, 28 Mar 2022 08:12:40 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkRt-007k0E-Ii; Mon, 28 Mar 2022 08:10:03 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0E96B1F430E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648455000; bh=/nWwqk3sPy6vmwVbxGTUip5rp6cQqefeecpSJO7M4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UiJeHcrb22+gxlwFAcWUPiZHHp8/logMJ7mTY54Dc1dhEE8gp3W9RL0O7G2CeQXbV gIqH3zqEye8pXt/cRvpTwr9+Q8OjU5Dx0heK90tYwCh0FG6ooKJCrPf7lDXXZpsFOU iwY+2LC5L/DGNeGUnoN9ihJH5wnjerx0CcCMLOPISGODK27sNNctav+XfeXXZnT9LJ CHFwHtVxRjUBayuSZAllKSy96pw17v1+oZgJF5zYl3SpZC9S5LcITyy6uM2G5QoBXJ hgfBsPl3nn+kuliZ6N1Fg1z4XIIGmoYOMwZlhuvbmsSXO3z/csC/LfIC/IJsyFz+yx 8fyq0INsI78aQ== Message-ID: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> Date: Mon, 28 Mar 2022 10:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Content-Language: en-US To: Guillaume Ranquet , airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220327223927.20848-7-granquet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_011001_831929_6CD7A196 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C365C433F5 for ; Mon, 28 Mar 2022 08:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vqb8Ki2wG0+w5tGsC39eML07b8WJaTNtF3h34ECeTKQ=; b=JP7s/VzuUeul8W 9QJsdVe4euPCbGNHtu1igfs/nqkVuIy4Itf0BwnCijHJZMGfd7ce/gg38LStuh6jsukzE0kz8wYU2 yDzm9+36fS8bZeV5Gr6M637mtro3eA14Inlz7IZyNa/BB4ujiiIQt3UeH1uCFz4rvv5Ft+i+yuO4e o+eW5H1s4ypAj1pLrCvQXg6vsonOvi7JXiPJ7RGIGB7qKHAmFVuEKdMdO6dJsOFqMKgcyBVwVsNN9 4zqb9FE8otrTO+NyiRxWBGvJWJ0zrrtNnyTvMNioUGalsl/9+bTIlXMUvlGSJiRYGSxEvcd06MBwr UHXjj2kvkUuO+qLaaBKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkUY-007lFZ-CM; Mon, 28 Mar 2022 08:12:46 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkRt-007k0E-Ii; Mon, 28 Mar 2022 08:10:03 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0E96B1F430E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648455000; bh=/nWwqk3sPy6vmwVbxGTUip5rp6cQqefeecpSJO7M4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UiJeHcrb22+gxlwFAcWUPiZHHp8/logMJ7mTY54Dc1dhEE8gp3W9RL0O7G2CeQXbV gIqH3zqEye8pXt/cRvpTwr9+Q8OjU5Dx0heK90tYwCh0FG6ooKJCrPf7lDXXZpsFOU iwY+2LC5L/DGNeGUnoN9ihJH5wnjerx0CcCMLOPISGODK27sNNctav+XfeXXZnT9LJ CHFwHtVxRjUBayuSZAllKSy96pw17v1+oZgJF5zYl3SpZC9S5LcITyy6uM2G5QoBXJ hgfBsPl3nn+kuliZ6N1Fg1z4XIIGmoYOMwZlhuvbmsSXO3z/csC/LfIC/IJsyFz+yx 8fyq0INsI78aQ== Message-ID: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> Date: Mon, 28 Mar 2022 10:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Content-Language: en-US To: Guillaume Ranquet , airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220327223927.20848-7-granquet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_011001_831929_6CD7A196 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65CEAC433F5 for ; Mon, 28 Mar 2022 08:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YA9CpnKBkqf995MVNeiRRbHpYJ7HxULOEhBrpYO3cMs=; b=P80TU2NSvxrUkS 1LbsQrSV9oXomp0HkvUA4EoSxro23+Qf5DWClxTovuc0nTvHn/aW/Mjno4+TMWV2CBfPcEfEq8aSZ fhvGVEwUNWToM3IId9TeRI7KuYVjbNbtvYUo/MeiLqBeC5ciAGYQaG7/rb9QEPTdN87H3TWCg9ED1 G+cBidZXVKlPV2te0WQhT14Q7KNACrm1/EzYf7/xmA1OGRFc8bNOHD8h4cX5TeUtrdFz90YlH90mb 45OX9pL8NQb5/WGB4MPBHMpUm/PAceKlbG0vpYD2La7WzTXpsSLOXz2hC11xo7/5MTyr073paUDUJ tV7i1eLfOXVYsQTRVTtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkTN-007kiv-5j; Mon, 28 Mar 2022 08:11:34 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYkRt-007k0E-Ii; Mon, 28 Mar 2022 08:10:03 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0E96B1F430E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648455000; bh=/nWwqk3sPy6vmwVbxGTUip5rp6cQqefeecpSJO7M4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UiJeHcrb22+gxlwFAcWUPiZHHp8/logMJ7mTY54Dc1dhEE8gp3W9RL0O7G2CeQXbV gIqH3zqEye8pXt/cRvpTwr9+Q8OjU5Dx0heK90tYwCh0FG6ooKJCrPf7lDXXZpsFOU iwY+2LC5L/DGNeGUnoN9ihJH5wnjerx0CcCMLOPISGODK27sNNctav+XfeXXZnT9LJ CHFwHtVxRjUBayuSZAllKSy96pw17v1+oZgJF5zYl3SpZC9S5LcITyy6uM2G5QoBXJ hgfBsPl3nn+kuliZ6N1Fg1z4XIIGmoYOMwZlhuvbmsSXO3z/csC/LfIC/IJsyFz+yx 8fyq0INsI78aQ== Message-ID: <33212024-ae93-32c3-7890-09006057ff49@collabora.com> Date: Mon, 28 Mar 2022 10:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Content-Language: en-US To: Guillaume Ranquet , airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-7-granquet@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220327223927.20848-7-granquet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_011001_831929_6CD7A196 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel