From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net v5] net/ipv6: Add anycast addresses to a global hashtable Date: Wed, 31 Oct 2018 20:53:57 -0600 Message-ID: <3328ed3b-0c7f-e763-bfe7-0cef8ddcbb03@gmail.com> References: <20181030.113147.173837020180526004.davem@davemloft.net> <75a6a4bb-a8f3-4996-a157-825a5834ae52@gmail.com> <20181030.161916.2155476722804506340.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Alexey Kuznetsov , yoshfuji@linux-ipv6.org To: Jeff Barnhill <0xeffeff@gmail.com>, davem@davemloft.net Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:39661 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbeKALzA (ORCPT ); Thu, 1 Nov 2018 07:55:00 -0400 Received: by mail-pl1-f193.google.com with SMTP id b5-v6so7596151pla.6 for ; Wed, 31 Oct 2018 19:54:01 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/31/18 6:02 PM, Jeff Barnhill wrote: > I'll follow this email with a new patch using ifacaddr6 instead of > creating a new struct. I ended up using fib6_nh.nh_dev to get the net, > instead of adding a back pointer to idev. It seems that idev was > recently removed in lieu of this, so if this is incorrect, please let > me know. Hopefully, I got the locking correct. That's correct. Make sure that the anycast code can not be accessed for reject routes which will not have a device set. Should be ok, but double check.